Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove 'prerender' from document VisibilityState #732

Merged
merged 1 commit into from
Sep 23, 2019
Merged

Remove 'prerender' from document VisibilityState #732

merged 1 commit into from
Sep 23, 2019

Conversation

kripod
Copy link
Contributor

@kripod kripod commented Jun 18, 2019

@saschanaz
Copy link
Contributor

npm run build && npm run baseline-accept should be done to fix the test.

@kripod
Copy link
Contributor Author

kripod commented Jul 16, 2019

@saschanaz Unfortunately, I get the following issues when running those commands:

> npm run build && npm run baseline-accept

> tsjs-lib-generator@ build D:\Development\Projects\TSJS-lib-generator
> tsc --p ./tsconfig.json && node ./lib/index.js

node_modules/@types/node/index.d.ts:74:11 - error TS2300: Duplicate identifier 'IteratorResult'.

74 interface IteratorResult<T> { }
             ~~~~~~~~~~~~~~

  node_modules/typescript/lib/lib.es2015.iterable.d.ts:41:6
    41 type IteratorResult<T, TReturn = any> = IteratorYieldResult<T> | IteratorReturnResult<TReturn>;
            ~~~~~~~~~~~~~~
    'IteratorResult' was also declared here.

node_modules/typescript/lib/lib.es2015.iterable.d.ts:41:6 - error TS2300: Duplicate identifier 'IteratorResult'.

41 type IteratorResult<T, TReturn = any> = IteratorYieldResult<T> | IteratorReturnResult<TReturn>;
        ~~~~~~~~~~~~~~

  node_modules/@types/node/index.d.ts:74:11
    74 interface IteratorResult<T> { }
                 ~~~~~~~~~~~~~~
    'IteratorResult' was also declared here.

@saschanaz
Copy link
Contributor

Try rebasing + npm i and do it again, as it's fixed in #737.

@kripod
Copy link
Contributor Author

kripod commented Jul 16, 2019

@saschanaz Thanks for the tip, everything seems to work now.

@saschanaz
Copy link
Contributor

Tests pass, great! But I'm afraid that something is broken when merging and now this PR has some duplicated commits from the master branch. Would you try git merge again?

@kripod
Copy link
Contributor Author

kripod commented Jul 27, 2019

@saschanaz I just recreated the entire PR with a force push to avoid issues.

@kripod
Copy link
Contributor Author

kripod commented Aug 20, 2019

@saschanaz Sorry for interrupting, but may I ask if there is anything I may help with to get this PR merged?

@saschanaz
Copy link
Contributor

Pinging @sandersn

@kripod
Copy link
Contributor Author

kripod commented Sep 19, 2019

@saschanaz @sandersn I'm sorry to disturb again, but may I ask if there are any blocking factors to resolve regarding this PR?

@saschanaz
Copy link
Contributor

saschanaz commented Sep 19, 2019 via email •
edited
Loading

@sandersn
Copy link
Member

Thanks for your patience! It's been a busy release.

@sandersn sandersn merged commit bfae33e into microsoft:master Sep 23, 2019
@kripod kripod deleted the patch-1 branch September 23, 2019 21:29
@kripod kripod mentioned this pull request Sep 23, 2019
Closed
@sandersn sandersn mentioned this pull request Sep 26, 2019
Merged
@qinyuhang
Copy link

I'm sorry but I failed to see why U remove prerender, It's still on in MDN https://developer.mozilla.org/en-US/docs/Web/API/Document/visibilityState

@kripod
Copy link
Contributor Author

kripod commented Oct 29, 2019

@qinyuhang It’s marked as deprecated and has already been removed from the corresponding spec.

@HolgerJeromin
Copy link
Contributor

I marked it as deprecated in MDN.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove 'prerender' value from VisibilityState
5 participants
@kripod @saschanaz @sandersn @qinyuhang @HolgerJeromin