Repository navigation
Use plaintext part of the MDN template - #2078
Closed
Kagami Sascha Rosylight (saschanaz) wants to merge 3 commits into
Closed
Kagami Sascha Rosylight (saschanaz) wants to merge 3 commits into
Kagami Sascha Rosylight (saschanaz) wants to merge 3 commits into
Conversation
Contributor
|
Thanks for the PR! This section of the codebase is owned by Kagami Sascha Rosylight (@saschanaz) - if they write a comment saying "LGTM" then it will be merged. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // For all other cases, the last argument is the plaintext | ||
| return trimEnds(args.at(-1)!); | ||
| }) | ||
| // Keep link text but remove URLs |
Contributor
There was a problem hiding this comment.
Technically you can add links in the comments. So why not include links?
Just a suggestion
Contributor
Author
There was a problem hiding this comment.
That part is from your PR 😛
We can do it, but not here.
Contributor
There was a problem hiding this comment.
That part is from your PR 😛
We can do it, but not here.
Correct 😃
I will open another PR for it
The existing regex was expecting `{{domxref(text)}}` form and did not dela with `{{domxref(link, text}}` form. This patch fixes that.
Many more lines added but regex was reduced. Despite that I think it's now more readable.
Kagami Sascha Rosylight (saschanaz)
force-pushed
the
fix-comment-plaintext
branch
from
July 20, 2025 21:46
634f18f to
9b19c0b
Compare
Adam Naji (Bashamega)
approved these changes
Jul 21, 2025
Jake Bailey (jakebailey)
approved these changes
Jul 21, 2025
Contributor
Author
|
Looking it again, it should probably be wrapped as a code than plaintext. |
Closed
Merged
Contributor
Author
|
Superceded by #2171 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #2077.