Repository navigation
Enable JSX auto-insert in content-mapped files - #64572
Merged
Merged
Conversation
typescript-automation
Bot
added
For Uncommitted Bug
Co-authored-by: RyanCavanaugh <[email protected]>
Co-authored-by: RyanCavanaugh <[email protected]>
Copilot
AI
changed the title
[WIP] Fix closing JSX tags not inserted in content-mapped files
Enable JSX auto-insert in content-mapped files
Oct 1, 2026
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused changes correctly address content-mapped auto-insert registration and listener cleanup without introducing unresolved issues.
Review effort: Balanced
Findings: None
What changed in this PR
Enables JSX auto-insert for content-mapped files and prevents stale event subscriptions during feature re-registration.
Changes:
- Registers auto-insert using the dynamically expanded document selector.
- Disposes
Conditionupdate listeners correctly.
| File | Description |
|---|---|
packages/vscode-typescript/src/client.ts |
Moves auto-insert into selector-scoped feature registration. |
packages/vscode-typescript/src/languageFeatures/util/dependentRegistration.ts |
Tracks and disposes condition update listeners. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Member
|
This seems like a good fix but I'm a bit confused how it fixes the linked issue. |
Member
Ryan Cavanaugh (RyanCavanaugh)
marked this pull request as ready for review
October 2, 2026 16:27
Ryan Cavanaugh (RyanCavanaugh)
approved these changes
Oct 2, 2026
Andrew Branch (andrewbranch)
approved these changes
Oct 2, 2026
Andrew Branch (andrewbranch)
left a comment
Andrew Branch (andrewbranch)
left a comment
Member
There was a problem hiding this comment.
I think at the time I was thinking this was a VS-only feature from the custom message name, but obviously the code is in our VS Code extension, so I guess I didn't think about it hard enough 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JSX closing tags were not requested for content-mapped files because auto-insert used only the static JavaScript/TypeScript document selector.
Changes