Fix crash in language service when using on inherited properties of self-extend#6227
Merged
Fix crash in language service when using on inherited properties of self-extend#6227
Conversation
Member
|
This is not a sufficient fix. I can break this by creating an arbitrarily long loop of heritage clauses. Here's an example: interface C extends D {
/*1*/propC: number;
}
interface D extends C {
/*2*/propD: string;
}Both occurrence locations cause a crash. |
Member
There was a problem hiding this comment.
I think you'll just need to pass along a cache for this; also, can you make the result parameter come last?
added 2 commits
January 8, 2016 03:34
Contributor
Author
|
@DanielRosenwasser any more comment? |
Member
There was a problem hiding this comment.
Add a /*previousIterationSymbolsCache*/
Member
|
Apart from the comments: 🍪 🍰 🍬 💯 |
yuit
added a commit
that referenced
this pull request
Jan 14, 2016
Fix crash in language service when using on inherited properties of self-extend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #4581