Skip to content

Do not require import attributes for JSON imports in --module node16 #60673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
andrewbranch merged 2 commits into from
Dec 4, 2024
Merged

Do not require import attributes for JSON imports in --module node16 #60673

andrewbranch merged 2 commits into from
Dec 4, 2024

Conversation

@andrewbranch
Copy link
Member

@andrewbranch andrewbranch commented Dec 3, 2024 •
edited
Loading

Fixes #60589

@typescript-bot typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Dec 3, 2024
@andrewbranch
Copy link
Member Author

andrewbranch commented Dec 3, 2024

@typescript-bot cherry-pick this to release-5.7

@typescript-bot
Copy link
Collaborator

typescript-bot commented Dec 3, 2024 •
edited
Loading

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
cherry-pick this to release-5.7 ✅ Started ✅ Results

@typescript-bot typescript-bot mentioned this pull request Dec 3, 2024
Merged
@typescript-bot
Copy link
Collaborator

typescript-bot commented Dec 3, 2024

Hey, @andrewbranch! I've created #60674 for you.

@andrewbranch andrewbranch merged commit 9bf5aa7 into microsoft:main Dec 4, 2024
32 checks passed
@andrewbranch andrewbranch deleted the bug/60589 branch December 4, 2024 16:47
@cwaldren-ld cwaldren-ld mentioned this pull request Dec 4, 2024
Merged
DanielRosenwasser pushed a commit that referenced this pull request Dec 4, 2024
@typescript-bot @andrewbranch
🤖 Pick PR #60673 (Do not require import attributes fo...) into releas…
97fa216 
…e-5.7 (#60674)

Co-authored-by: Andrew Branch <[email protected]>
@silverwind silverwind mentioned this pull request Dec 8, 2024
Closed
@sandersn sandersn removed this from PR Backlog Apr 22, 2025
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jakebailey jakebailey jakebailey approved these changes

@DanielRosenwasser DanielRosenwasser Awaiting requested review from DanielRosenwasser

Assignees

@andrewbranch andrewbranch

Labels

Author: Team For Milestone Bug PRs that fix a bug with a specific milestone

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Module resolution: Regression in JSON import using Node16 resolution

3 participants

@andrewbranch @typescript-bot @jakebailey