Skip to content

Revert #57896#58857

Merged
andrewbranch merged 2 commits intomicrosoft:mainfrom
andrewbranch:revert-57896
Jun 13, 2024
Merged

Revert #57896#58857
andrewbranch merged 2 commits intomicrosoft:mainfrom
andrewbranch:revert-57896

Conversation

@andrewbranch
Copy link
Copy Markdown
Member

@andrewbranch andrewbranch commented Jun 13, 2024

My attempt (#58831) to just disable #57896 was incomplete, so this is the full revert instead.

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jun 13, 2024
@typescript-bot
Copy link
Copy Markdown
Collaborator

typescript-bot commented Jun 13, 2024

Looks like you're introducing a change to the public API surface area. If this includes breaking changes, please document them on our wiki's API Breaking Changes page.

Also, please make sure @DanielRosenwasser and @RyanCavanaugh are aware of the changes, just as a heads up.

@jakebailey
Copy link
Copy Markdown
Member

jakebailey commented Jun 13, 2024

Does this also undo Wesley's change? Or does that still work?

@andrewbranch
Copy link
Copy Markdown
Member Author

andrewbranch commented Jun 13, 2024

The only interaction between my work and #58176 is how often package.jsons that one of us is doing a lookup for is already cached because of a lookup that the other is doing.

@andrewbranch
Copy link
Copy Markdown
Member Author

andrewbranch commented Jun 13, 2024

@typescript-bot cherry-pick to release-5.5

@typescript-bot
Copy link
Copy Markdown
Collaborator

typescript-bot commented Jun 13, 2024 •
edited
Loading

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
cherry-pick to release-5.5 ✅ Started ❌ Results

@typescript-bot
Copy link
Copy Markdown
Collaborator

typescript-bot commented Jun 13, 2024

Hey, @andrewbranch! I was unable to cherry-pick this PR.

Check the logs at: https://github.com/microsoft/TypeScript/actions/runs/9508013806

jakebailey
jakebailey approved these changes Jun 13, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@jakebailey jakebailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢

@andrewbranch andrewbranch mentioned this pull request Jun 13, 2024
Merged
@andrewbranch andrewbranch merged commit 5628973 into microsoft:main Jun 13, 2024
@andrewbranch andrewbranch deleted the revert-57896 branch June 13, 2024 23:40
@DanielRosenwasser DanielRosenwasser added this to the TypeScript 5.5.2 milestone Jun 14, 2024
DanielRosenwasser pushed a commit that referenced this pull request Jun 14, 2024
@andrewbranch
Pick #58857 to release-5.5 (#58858)
39c9eeb
@andrewbranch andrewbranch mentioned this pull request Jul 9, 2024
Closed
@sandersn sandersn removed this from PR Backlog Apr 22, 2025
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jakebailey jakebailey jakebailey approved these changes

@sheetalkamat sheetalkamat Awaiting requested review from sheetalkamat

@DanielRosenwasser DanielRosenwasser Awaiting requested review from DanielRosenwasser

Assignees

@andrewbranch andrewbranch

Labels

Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

None yet

Milestone

TypeScript 5.5.2

Development

Successfully merging this pull request may close these issues.

5 participants

@andrewbranch @typescript-bot @jakebailey @sandersn @DanielRosenwasser