Skip to content
Merged
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
79961d4
Add --noCheck flag, mirroring --noEmit, allowing emitting transpiling…
weswigham Mar 24, 2024
540ce28
Test .d.ts emit on noCheck (js is pretty hopelessly broken without di…
weswigham Mar 24, 2024
3f89f5c
Fix harness issues, js declaration emit issues with out of order chec…
weswigham Mar 24, 2024
bf82544
Add errors on using noCheck with noEmit and without emitDeclarationOn…
weswigham Mar 25, 2024
a3d4f73
Format
weswigham Mar 25, 2024
ce65c79
Merge branch 'main' into nocheck
weswigham Mar 27, 2024
736eac2
Update baselines with main
weswigham Mar 27, 2024
5c5e8e0
Remove command-line accesible noCheck option, API only until JS is done
weswigham Mar 27, 2024
b33afe7
Merge branch 'main' into nocheck
weswigham Mar 27, 2024
1a05d96
Remove unused baseline
weswigham Mar 27, 2024
051a1d1
Add private option description so if `build` is invoked via API with …
weswigham Mar 28, 2024
1231be1
Increase comment verbosity
weswigham Mar 28, 2024
3e29a42
Merge branch 'main' into nocheck
weswigham Apr 10, 2024
2bda238
Add -b test for noCheck, change strategy used to make flag api-only
weswigham Apr 11, 2024
7332613
Comment, capture current normal behavior of build/incremental (an opt…
weswigham Apr 11, 2024
41f82f1
Diffs
weswigham Apr 11, 2024
5c9c333
Format
weswigham Apr 11, 2024
72bd93c
Actually accept more useful diff names
weswigham Apr 11, 2024
e0d7b4e
Cleanup
weswigham Apr 11, 2024
8c667f4
Merge branch 'main' into nocheck
weswigham Apr 12, 2024
e0dfe56
Merge branch 'main' into nocheck
weswigham Apr 24, 2024
2f65540
Enable noCheck for transpileDeclaration
weswigham Apr 24, 2024
0f1b4c6
Remove builder change
weswigham Apr 24, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add private option description so if build is invoked via API with …
…`noCheck`, it is serialized correctly
  • Loading branch information
weswigham committed Mar 28, 2024
commit 051a1d16e87bb418e44d1dd56a1d689cd3982fe0
18 changes: 17 additions & 1 deletion src/compiler/commandLineParser.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1578,6 +1578,22 @@ export const optionDeclarations: CommandLineOption[] = [
...commandOptionsWithoutBuild,
];

// These aren't available via CLI or config (yet), but we still want to handle them correctly
/** @internal */
export const privateOptionDeclarations: CommandLineOption[] = [
{
name: "noCheck",
type: "boolean",
showInSimplifiedHelpView: true,
category: Diagnostics.Emit,
Comment thread
weswigham marked this conversation as resolved.
Outdated
description: Diagnostics.Disable_full_type_checking_only_critical_parse_and_emit_errors_will_be_reported,
transpileOptionValue: undefined,
defaultValueDescription: false,
affectsSemanticDiagnostics: true,
affectsBuildInfo: true,
},
];

/** @internal */
export const semanticDiagnosticsOptionDeclarations: readonly CommandLineOption[] = optionDeclarations.filter(option => !!option.affectsSemanticDiagnostics);

Expand Down Expand Up @@ -1695,7 +1711,7 @@ let optionsNameMapCache: OptionsNameMap;

/** @internal */
export function getOptionsNameMap(): OptionsNameMap {
return optionsNameMapCache ||= createOptionNameMap(optionDeclarations);
return optionsNameMapCache ||= createOptionNameMap([...optionDeclarations, ...privateOptionDeclarations]);
}

const compilerOptionsAlternateMode: AlternateModeDiagnostics = {
Expand Down