Update typescript dep to v5.4.2, other dependencies#57664
Merged
jakebailey merged 4 commits intomicrosoft:mainfrom Mar 6, 2024
Merged
Update typescript dep to v5.4.2, other dependencies#57664jakebailey merged 4 commits intomicrosoft:mainfrom
jakebailey merged 4 commits intomicrosoft:mainfrom
Conversation
typescript-bot
added
Author: Team
For Uncommitted Bug
jakebailey
commented
Mar 6, 2024
| } | ||
| else if (!isString(opt.type)) { | ||
| return convertJsonOptionOfCustomType(opt as CommandLineOptionOfCustomType, value as string, errors, valueExpression, sourceFile); | ||
| return convertJsonOptionOfCustomType(opt, value as string, errors, valueExpression, sourceFile); |
Member
Author
There was a problem hiding this comment.
Yay narrowing improvements!
sheetalkamat
approved these changes
Mar 6, 2024
RyanCavanaugh
approved these changes
Mar 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TypeScript v5.4.2 is out. Update that dependency, and then the rest of our dependencies.