fix(dts): JsxSpreadAttribute - remove name from types#54599
Merged
DanielRosenwasser merged 2 commits intomicrosoft:mainfrom Jun 21, 2023
Merged
fix(dts): JsxSpreadAttribute - remove name from types#54599DanielRosenwasser merged 2 commits intomicrosoft:mainfrom
JsxSpreadAttribute - remove name from types#54599DanielRosenwasser merged 2 commits intomicrosoft:mainfrom
Conversation
typescript-bot
added
the
For Uncommitted Bug
Collaborator
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
jakebailey
approved these changes
Jun 12, 2023
Member
jakebailey
left a comment
jakebailey
left a comment
There was a problem hiding this comment.
This definitely looks like an oops to me; the property is unused and not present in the factory functions. Probably this should be backported so people don't try and do something with it.
gabritto
approved these changes
Jun 20, 2023
DanielRosenwasser
added
the
Breaking Change
Member
|
@typescript-bot cherry-pick this to release-5.1 |
Collaborator
|
Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into |
Collaborator
|
Hey @DanielRosenwasser, I've opened #54720 for you. |
typescript-bot
pushed a commit
to typescript-bot/TypeScript
that referenced
this pull request
Jun 21, 2023
DanielRosenwasser
pushed a commit
that referenced
this pull request
Jun 26, 2023
…e-5.1 (#54720) Co-authored-by: David Sherret <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this was accidentally added in https://github.com/microsoft/TypeScript/pull/47356/files#diff-e9fd483341eea176a38fbd370590e1dc65ce2d9bf70bfd317c5407f04dba9560R3264