Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regression in WeakMap constructor type #54592

Merged
merged 1 commit into from
Jun 9, 2023
Merged

Fix regression in WeakMap constructor type #54592

merged 1 commit into from
Jun 9, 2023

Conversation

rbuckton
Copy link
Member

@rbuckton rbuckton commented Jun 9, 2023

@rbuckton rbuckton requested a review from sandersn June 9, 2023 20:33
@rbuckton rbuckton marked this pull request as ready for review June 9, 2023 20:33
@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jun 9, 2023
@rbuckton rbuckton mentioned this pull request Jun 9, 2023
Merged
@acutmore
Copy link
Contributor

acutmore commented Jun 9, 2023

Thanks @rbuckton !

@rbuckton rbuckton merged commit 72406c6 into main Jun 9, 2023
@rbuckton rbuckton deleted the fix-weakmap-constructor branch June 9, 2023 21:17
@matthew-dean
Copy link

Is this released? I'm still getting issues with Argument of type 'symbol' is not assignable to parameter of type 'object'

@jakebailey
Copy link
Member

Yes, in TS 5.2 if you have your lib set to es2023. Playground Link

If you are having problems, consider filing an issue as old merged PRs are not a great place for bug reporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielRosenwasser DanielRosenwasser DanielRosenwasser approved these changes

@sandersn sandersn Awaiting requested review from sandersn

Assignees

@rbuckton rbuckton

Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rbuckton @acutmore @matthew-dean @jakebailey @DanielRosenwasser @typescript-bot