Switch from corepack to a global npm install for now#54578
Merged
jakebailey merged 2 commits intomicrosoft:mainfrom Jun 8, 2023
Merged
Switch from corepack to a global npm install for now#54578jakebailey merged 2 commits intomicrosoft:mainfrom
jakebailey merged 2 commits intomicrosoft:mainfrom
Conversation
andrewbranch
approved these changes
Jun 8, 2023
Member
|
@typescript-bot cherry-pick to release-5.1 |
Collaborator
|
Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into |
Collaborator
|
Hey @DanielRosenwasser, I've opened #54787 for you. |
typescript-bot
pushed a commit
to typescript-bot/TypeScript
that referenced
this pull request
Jun 26, 2023
DanielRosenwasser
pushed a commit
that referenced
this pull request
Jun 26, 2023
…e-5.1 (#54787) Co-authored-by: Jake Bailey <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm installed with corepack in some CI workflows is failing with a segfault. I have yet to see anyone else reporting this on node, npm, corepack, github actions, anywhere.
For now, just disable corepack and instead use an npm global install of the
packageManagerproperty. This property is a valid package name plus version so is a decent way to install a package manager of a particular version.