Type definitions for 'Symbols as WeakMap keys' (#76) #54195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
the
For Uncommitted Bug
typescript-bot
added
For Milestone Bug
leoelm
force-pushed
the
le/symbol-as-weak-keys
branch
from
723ec0d to
0f47664
Compare
rbuckton
approved these changes
Jun 8, 2023
leoelm
force-pushed
the
le/symbol-as-weak-keys
branch
from
0f47664 to
03938b9
Compare
|
Rebase is now done and all seems to be looking good still. |
Support symbols in WeakMap, WeakSet, WeakRef and FinalizationRegistry Signed-off-by: Leo Elmecker <[email protected]>
leoelm
force-pushed
the
le/symbol-as-weak-keys
branch
from
03938b9 to
8db37ee
Compare
rbuckton
approved these changes
Jun 9, 2023
| */ | ||
| set(key: K, value: V): this; | ||
| } | ||
|
|
||
| interface WeakMapConstructor { | ||
| new <K extends object = object, V = any>(entries?: readonly (readonly [K, V])[] | null): WeakMap<K, V>; | ||
| readonly prototype: WeakMap<object, any>; | ||
| new <K extends WeakKey = WeakKey, V = any>(entries?: readonly [K, V][] | null): WeakMap<K, V>; |
There was a problem hiding this comment.
Regression from #50449.
There was a problem hiding this comment.
Ah, thanks for catching this. I missed it in the review.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #52534.
Adding symbol type support to
WeakMap,WeakSet,WeakRefandFinalizationRegistry.The above has been achieved by retrospectively introducing an interface,
WeakTypesused for the definition of compatible types for the above mentioned structures.