Always substitute indexed generic mapped type when getting constraint from indexed access#53066
Merged
weswigham merged 1 commit intoMar 21, 2023
Conversation
… from indexed access
typescript-bot
added
the
For Milestone Bug
Andarist
commented
Mar 2, 2023
|
|
||
| function getConstraintFromIndexedAccess(type: IndexedAccessType) { | ||
| if (isMappedTypeGenericIndexedAccess(type)) { | ||
| if (isMappedTypeGenericIndexedAccess(type) || isGenericMappedType(type.objectType)) { |
Contributor
Author
There was a problem hiding this comment.
If the indexed access is allowed - then I think it's always safe to substitute as when the indexType is invalid then the error is reported elsewhere anyway.
Member
|
@typescript-bot test this |
Contributor
|
Heya @weswigham, I've started to run the extended test suite on this PR at 20c9d3a. You can monitor the build here. |
Contributor
|
Heya @weswigham, I've started to run the parallelized Definitely Typed test suite on this PR at 20c9d3a. You can monitor the build here. Update: The results are in! |
Contributor
|
Heya @weswigham, I've started to run the perf test suite on this PR at 20c9d3a. You can monitor the build here. Update: The results are in! |
Contributor
|
Heya @weswigham, I've started to run the diff-based top-repos suite on this PR at 20c9d3a. You can monitor the build here. Update: The results are in! |
Contributor
|
Hey @weswigham, the results of running the DT tests are ready. |
Contributor
|
@weswigham Here are the results of running the top-repos suite comparing Everything looks good! |
Contributor
|
@weswigham Here they are:
CompilerComparison Report - main..53066
System
Hosts
Scenarios
TSServerComparison Report - main..53066
System
Hosts
Scenarios
StartupComparison Report - main..53066
System
Hosts
Scenarios
Developer Information: |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Andarist
deleted the
fix/generic-mapped-type-substitution-indexed-access
branch
Member
|
@Andarist @weswigham Stumbled on this PR that I hadn't seen before. Something is not right here: type Remap<K extends string> = {
[P in K as `_${P}`]: P;
};
type Key = "foo" | "bar" | "baz";
function qq1<K extends string>(obj: Remap<K>, key: keyof Remap<K>) {
let s: `_${string}` = obj[key]; // Error expected here
}
function qq2(obj: Remap<Key>, key: keyof Remap<Key>) {
let s: `_${string}` = obj[key]; // Error (as expected)
}I think your comment here is really only true when the name type isn't a remapping. |
Andarist
added a commit
to Andarist/TypeScript
that referenced
this pull request
Jan 28, 2024
…nstraint from indexed access (microsoft#53066)" This reverts commit abb4052.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #50030