-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run tests on all OSs #52350
Run tests on all OSs #52350
Conversation
Wow, after multiple reruns, I think |
The above is hopefully better after #52382 (the PR saved a significant amount on that test). We'll see if it passes or if there's still more to find. |
Marking this as ready-for-review; it seems to be working with that performance bump from reused Printers. |
Oh, hm, it was actually macOS this last time that was slow. It's a minute or so faster now but not really in range of other machines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'd probably be fine with only testing all OSes on latest node
, coverage-wise, but the full matrix is fine, since, y'know, it's not like we're getting billed, right? 😆 (...do we have a GHA max worker limit?)
We totally don't; Python's typeshed repo (equivalent to DT) runs 54 jobs per PR/commit. One reason I would be testing on the full matrix is that we've seen breaks like how Node upgraded its |
Well, I guess "latest" would get us those breaks, yeah. But I don't think there's really a downside of testing everything. |
Rechecking, the timeout is 40s for any singular test; with that one expensive test everything else seems to run under that limit. I was worried because the macOS builder takes 20 minutes (as opposed to 10-15 for other OSs), but an overall long time isn't bad so long as each individual test can run. I was assuming there was a total-time timeout but nope. |
declarationEmitPrivatePromiseLikeInterface is still flaky, it seems. Will have to keep profiling it. |
Up until now, we only tested Linux in CI. It seems like a good idea to test all of our supported platforms and versions (especially since we get it "for free" in parallel).