Skip to content

Fix assertion functions accessed via wildcard imports #51324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jakebailey merged 4 commits into from
Oct 28, 2022
Merged

Fix assertion functions accessed via wildcard imports #51324

jakebailey merged 4 commits into from
Oct 28, 2022

Conversation

@jakebailey
Copy link
Member

@jakebailey jakebailey commented Oct 27, 2022

Fixes #35004

This comes down to us resolving the symbol in some conditions but not others, which led to an inconsistent experience; these assertions were legal so long as the leftmost symbol wasn't a namespace import. If you imported a wildcard import via another module's named exports, it was legal, but using a wildcard import to access that same export was not.

Hoping to get this in to 4.9 so it can in be our LKG for 5.0; this will allow me to convert the Debug namespace into a module (which will then enable scope hoisting and perf boosts).

@typescript-bot typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Oct 27, 2022
@jakebailey
Copy link
Member Author

jakebailey commented Oct 27, 2022

@typescript-bot test this
@typescript-bot user test this inline
@typescript-bot run dt
@typescript-bot perf test this faster
@typescript-bot test top100

@typescript-bot
Copy link
Collaborator

typescript-bot commented Oct 27, 2022 •
edited
Loading

Heya @jakebailey, I've started to run the extended test suite on this PR at d5be437. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Oct 27, 2022 •
edited
Loading

Heya @jakebailey, I've started to run the abridged perf test suite on this PR at d5be437. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Oct 27, 2022 •
edited
Loading

Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at d5be437. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Oct 27, 2022 •
edited
Loading

Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at d5be437. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Oct 27, 2022 •
edited
Loading

Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at d5be437. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Oct 27, 2022

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/51324/merge:

Everything looks good!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Oct 27, 2022

@jakebailey
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..51324

Metric main 51324 Delta Best Worst
Angular - node (v16.17.1, x64)
Memory used 353,415k (± 0.02%) 353,444k (± 0.02%) +28k (+ 0.01%) 353,262k 353,517k
Parse Time 1.92s (± 1.43%) 1.93s (± 0.63%) +0.01s (+ 0.52%) 1.90s 1.96s
Bind Time 0.75s (± 0.86%) 0.75s (± 0.89%) +0.00s (+ 0.13%) 0.74s 0.77s
Check Time 5.67s (± 0.35%) 5.72s (± 0.60%) +0.04s (+ 0.76%) 5.65s 5.80s
Emit Time 6.13s (± 0.81%) 6.09s (± 0.39%) -0.04s (- 0.67%) 6.03s 6.15s
Total Time 14.47s (± 0.45%) 14.49s (± 0.35%) +0.02s (+ 0.12%) 14.41s 14.66s
Compiler-Unions - node (v16.17.1, x64)
Memory used 198,389k (± 0.57%) 197,941k (± 0.52%) -449k (- 0.23%) 196,363k 200,651k
Parse Time 0.78s (± 0.43%) 0.79s (± 0.63%) +0.00s (+ 0.64%) 0.77s 0.79s
Bind Time 0.46s (± 1.09%) 0.46s (± 1.13%) +0.00s (+ 0.88%) 0.45s 0.47s
Check Time 6.39s (± 0.29%) 6.47s (± 0.84%) +0.07s (+ 1.16%) 6.36s 6.58s
Emit Time 2.27s (± 0.65%) 2.28s (± 0.76%) +0.01s (+ 0.22%) 2.24s 2.32s
Total Time 9.90s (± 0.19%) 9.99s (± 0.72%) +0.09s (+ 0.90%) 9.84s 10.13s
Monaco - node (v16.17.1, x64)
Memory used 331,182k (± 0.01%) 331,228k (± 0.01%) +45k (+ 0.01%) 331,181k 331,354k
Parse Time 1.43s (± 0.54%) 1.43s (± 0.66%) +0.01s (+ 0.42%) 1.42s 1.46s
Bind Time 0.69s (± 0.81%) 0.70s (± 0.71%) +0.01s (+ 1.16%) 0.69s 0.71s
Check Time 5.46s (± 0.48%) 5.48s (± 0.47%) +0.03s (+ 0.49%) 5.44s 5.53s
Emit Time 3.25s (± 0.45%) 3.26s (± 0.32%) +0.00s (+ 0.09%) 3.24s 3.28s
Total Time 10.83s (± 0.38%) 10.87s (± 0.25%) +0.04s (+ 0.36%) 10.80s 10.92s
TFS - node (v16.17.1, x64)
Memory used 294,068k (± 0.02%) 294,102k (± 0.01%) +35k (+ 0.01%) 293,944k 294,152k
Parse Time 1.23s (± 1.42%) 1.26s (± 1.59%) +0.03s (+ 2.78%) 1.22s 1.31s
Bind Time 0.64s (± 0.57%) 0.64s (± 0.62%) +0.01s (+ 0.79%) 0.63s 0.65s
Check Time 5.10s (± 0.40%) 5.14s (± 0.36%) +0.04s (+ 0.86%) 5.09s 5.19s
Emit Time 3.49s (± 0.57%) 3.51s (± 0.61%) +0.03s (+ 0.75%) 3.47s 3.56s
Total Time 10.45s (± 0.28%) 10.56s (± 0.41%) +0.11s (+ 1.04%) 10.49s 10.67s
material-ui - node (v16.17.1, x64)
Memory used 439,317k (± 0.01%) 439,324k (± 0.01%) +7k (+ 0.00%) 439,260k 439,488k
Parse Time 1.73s (± 1.18%) 1.76s (± 0.98%) +0.03s (+ 1.79%) 1.72s 1.80s
Bind Time 0.54s (± 0.83%) 0.54s (± 1.07%) +0.00s (+ 0.93%) 0.53s 0.56s
Check Time 12.46s (± 0.28%) 12.57s (± 0.74%) +0.11s (+ 0.87%) 12.42s 12.76s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 14.73s (± 0.34%) 14.88s (± 0.57%) +0.15s (+ 0.99%) 14.73s 15.05s
xstate - node (v16.17.1, x64)
Memory used 555,047k (± 0.02%) 554,957k (± 0.01%) -90k (- 0.02%) 554,888k 555,143k
Parse Time 2.30s (± 0.43%) 2.33s (± 0.62%) +0.03s (+ 1.35%) 2.30s 2.35s
Bind Time 0.89s (± 1.77%) 0.90s (± 1.75%) +0.01s (+ 1.12%) 0.88s 0.95s
Check Time 1.43s (± 0.96%) 1.44s (± 0.66%) +0.01s (+ 0.35%) 1.42s 1.46s
Emit Time 0.07s (± 3.23%) 0.07s (± 0.00%) +0.00s (+ 1.45%) 0.07s 0.07s
Total Time 4.69s (± 0.32%) 4.73s (± 0.54%) +0.04s (+ 0.83%) 4.67s 4.77s

System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-126-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • Angular - node (v16.17.1, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Monaco - node (v16.17.1, x64)
  • TFS - node (v16.17.1, x64)
  • material-ui - node (v16.17.1, x64)
  • xstate - node (v16.17.1, x64)
Benchmark Name Iterations
Current 51324 10
Baseline main 10

Developer Information:

Download Benchmark

@typescript-bot
Copy link
Collaborator

typescript-bot commented Oct 27, 2022

Heya @jakebailey, I've run the RWC suite on this PR - assuming you're on the TS core team, you can view the resulting diff here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Oct 27, 2022

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/51324/merge:

Everything looks good!

@DanielRosenwasser
Copy link
Member

DanielRosenwasser commented Oct 27, 2022

Hm.

@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Oct 27, 2022 •
edited
Loading

Heya @DanielRosenwasser, I've started to run the perf test suite on this PR at d5be437. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Oct 27, 2022

@DanielRosenwasser
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..51324
Metric main 51324 Delta Best Worst
Angular - node (v18.10.0, x64)
Memory used 353,959k (± 0.03%) 353,950k (± 0.02%) -9k (- 0.00%) 353,734k 354,046k
Parse Time 1.57s (± 0.83%) 1.57s (± 0.77%) +0.00s (+ 0.06%) 1.55s 1.60s
Bind Time 0.61s (± 0.73%) 0.61s (± 0.94%) +0.00s (+ 0.33%) 0.60s 0.62s
Check Time 4.42s (± 0.47%) 4.41s (± 0.62%) -0.01s (- 0.29%) 4.35s 4.45s
Emit Time 4.92s (± 0.37%) 4.93s (± 0.52%) +0.01s (+ 0.22%) 4.89s 4.98s
Total Time 11.51s (± 0.20%) 11.52s (± 0.38%) +0.00s (+ 0.03%) 11.42s 11.59s
Compiler-Unions - node (v18.10.0, x64)
Memory used 200,232k (± 0.84%) 199,889k (± 0.85%) -344k (- 0.17%) 195,705k 201,426k
Parse Time 0.60s (± 0.74%) 0.61s (± 1.23%) +0.01s (+ 0.83%) 0.59s 0.62s
Bind Time 0.36s (± 0.92%) 0.36s (± 1.44%) +0.00s (+ 0.28%) 0.35s 0.37s
Check Time 5.37s (± 0.36%) 5.37s (± 0.45%) -0.00s (- 0.07%) 5.31s 5.41s
Emit Time 1.81s (± 0.74%) 1.82s (± 1.19%) +0.00s (+ 0.11%) 1.76s 1.86s
Total Time 8.14s (± 0.32%) 8.14s (± 0.49%) +0.00s (+ 0.02%) 8.02s 8.23s
Monaco - node (v18.10.0, x64)
Memory used 331,782k (± 0.02%) 331,822k (± 0.02%) +41k (+ 0.01%) 331,718k 331,943k
Parse Time 1.17s (± 0.79%) 1.17s (± 1.01%) +0.00s (+ 0.34%) 1.15s 1.21s
Bind Time 0.56s (± 0.89%) 0.56s (± 0.85%) +0.00s (+ 0.18%) 0.55s 0.57s
Check Time 4.32s (± 0.94%) 4.31s (± 0.42%) -0.00s (- 0.12%) 4.27s 4.36s
Emit Time 2.64s (± 0.76%) 2.63s (± 0.77%) -0.01s (- 0.30%) 2.58s 2.68s
Total Time 8.68s (± 0.74%) 8.67s (± 0.39%) -0.01s (- 0.14%) 8.62s 8.77s
TFS - node (v18.10.0, x64)
Memory used 294,746k (± 0.01%) 294,759k (± 0.01%) +13k (+ 0.00%) 294,656k 294,809k
Parse Time 0.93s (± 0.81%) 0.93s (± 0.98%) -0.00s (- 0.54%) 0.91s 0.95s
Bind Time 0.59s (± 3.46%) 0.61s (± 4.06%) +0.02s (+ 3.92%) 0.55s 0.65s
Check Time 4.02s (± 0.55%) 4.02s (± 0.53%) 0.00s ( 0.00%) 3.98s 4.07s
Emit Time 2.63s (± 0.67%) 2.64s (± 0.85%) +0.01s (+ 0.23%) 2.60s 2.68s
Total Time 8.17s (± 0.45%) 8.20s (± 0.49%) +0.03s (+ 0.31%) 8.07s 8.26s
material-ui - node (v18.10.0, x64)
Memory used 439,993k (± 0.01%) 439,980k (± 0.02%) -13k (- 0.00%) 439,848k 440,187k
Parse Time 1.36s (± 0.52%) 1.36s (± 1.38%) +0.00s (+ 0.29%) 1.34s 1.43s
Bind Time 0.45s (± 1.28%) 0.45s (± 0.83%) -0.01s (- 1.11%) 0.44s 0.45s
Check Time 10.88s (± 0.97%) 10.87s (± 0.46%) -0.01s (- 0.13%) 10.74s 10.97s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 12.69s (± 0.85%) 12.68s (± 0.46%) -0.01s (- 0.09%) 12.53s 12.80s
xstate - node (v18.10.0, x64)
Memory used 557,297k (± 0.01%) 557,328k (± 0.01%) +31k (+ 0.01%) 557,185k 557,540k
Parse Time 1.91s (± 0.40%) 1.93s (± 0.60%) +0.01s (+ 0.57%) 1.90s 1.95s
Bind Time 0.69s (± 1.96%) 0.70s (± 2.71%) +0.01s (+ 1.89%) 0.67s 0.74s
Check Time 1.10s (± 0.77%) 1.10s (± 1.09%) +0.00s (+ 0.27%) 1.08s 1.13s
Emit Time 0.06s (± 0.00%) 0.06s (± 0.00%) 0.00s ( 0.00%) 0.06s 0.06s
Total Time 3.76s (± 0.67%) 3.78s (± 0.69%) +0.03s (+ 0.67%) 3.72s 3.82s
Angular - node (v16.17.1, x64)
Memory used 353,435k (± 0.01%) 353,481k (± 0.01%) +47k (+ 0.01%) 353,424k 353,532k
Parse Time 1.90s (± 0.80%) 1.92s (± 0.72%) +0.02s (+ 0.89%) 1.89s 1.94s
Bind Time 0.75s (± 0.59%) 0.75s (± 0.53%) -0.00s (- 0.13%) 0.74s 0.76s
Check Time 5.71s (± 0.59%) 5.71s (± 0.51%) +0.00s (+ 0.05%) 5.65s 5.77s
Emit Time 6.10s (± 0.92%) 6.10s (± 0.86%) -0.01s (- 0.11%) 6.02s 6.20s
Total Time 14.46s (± 0.58%) 14.48s (± 0.54%) +0.02s (+ 0.10%) 14.34s 14.64s
Compiler-Unions - node (v16.17.1, x64)
Memory used 198,089k (± 0.49%) 198,047k (± 0.49%) -42k (- 0.02%) 197,302k 200,677k
Parse Time 0.78s (± 0.63%) 0.78s (± 0.87%) 0.00s ( 0.00%) 0.77s 0.80s
Bind Time 0.46s (± 0.97%) 0.45s (± 1.09%) -0.00s (- 0.66%) 0.45s 0.47s
Check Time 6.42s (± 0.42%) 6.44s (± 0.58%) +0.03s (+ 0.42%) 6.35s 6.51s
Emit Time 2.26s (± 0.92%) 2.29s (± 1.26%) +0.02s (+ 1.02%) 2.21s 2.35s
Total Time 9.92s (± 0.33%) 9.97s (± 0.53%) +0.05s (+ 0.51%) 9.86s 10.07s
Monaco - node (v16.17.1, x64)
Memory used 331,194k (± 0.01%) 331,225k (± 0.01%) +32k (+ 0.01%) 331,112k 331,325k
Parse Time 1.43s (± 0.40%) 1.44s (± 0.99%) +0.01s (+ 0.42%) 1.41s 1.48s
Bind Time 0.69s (± 0.65%) 0.69s (± 0.75%) +0.00s (+ 0.15%) 0.68s 0.70s
Check Time 5.49s (± 0.71%) 5.49s (± 0.45%) +0.00s (+ 0.05%) 5.43s 5.54s
Emit Time 3.26s (± 0.55%) 3.26s (± 0.56%) -0.01s (- 0.25%) 3.20s 3.29s
Total Time 10.87s (± 0.49%) 10.87s (± 0.30%) +0.01s (+ 0.06%) 10.79s 10.93s
TFS - node (v16.17.1, x64)
Memory used 294,081k (± 0.01%) 294,088k (± 0.02%) +7k (+ 0.00%) 293,952k 294,152k
Parse Time 1.23s (± 1.20%) 1.22s (± 1.44%) -0.01s (- 0.81%) 1.18s 1.26s
Bind Time 0.64s (± 0.47%) 0.64s (± 0.63%) +0.00s (+ 0.16%) 0.63s 0.65s
Check Time 5.12s (± 0.31%) 5.13s (± 0.40%) +0.01s (+ 0.25%) 5.07s 5.16s
Emit Time 3.49s (± 0.67%) 3.48s (± 0.86%) -0.01s (- 0.20%) 3.42s 3.56s
Total Time 10.47s (± 0.35%) 10.46s (± 0.53%) -0.01s (- 0.07%) 10.35s 10.58s
material-ui - node (v16.17.1, x64)
Memory used 439,299k (± 0.01%) 439,322k (± 0.01%) +24k (+ 0.01%) 439,206k 439,515k
Parse Time 1.72s (± 0.78%) 1.73s (± 1.26%) +0.01s (+ 0.70%) 1.69s 1.77s
Bind Time 0.54s (± 0.87%) 0.54s (± 0.55%) -0.00s (- 0.37%) 0.53s 0.54s
Check Time 12.54s (± 0.56%) 12.47s (± 0.40%) -0.07s (- 0.57%) 12.35s 12.60s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 14.80s (± 0.52%) 14.74s (± 0.30%) -0.06s (- 0.41%) 14.66s 14.86s
xstate - node (v16.17.1, x64)
Memory used 554,970k (± 0.00%) 555,031k (± 0.01%) +61k (+ 0.01%) 554,890k 555,205k
Parse Time 2.31s (± 0.39%) 2.31s (± 0.33%) 0.00s ( 0.00%) 2.29s 2.32s
Bind Time 0.89s (± 1.60%) 0.88s (± 1.19%) -0.01s (- 0.68%) 0.87s 0.92s
Check Time 1.43s (± 0.62%) 1.43s (± 0.63%) -0.01s (- 0.56%) 1.40s 1.45s
Emit Time 0.07s (± 5.08%) 0.07s (± 4.37%) +0.00s (+ 1.49%) 0.06s 0.07s
Total Time 4.69s (± 0.27%) 4.68s (± 0.38%) -0.00s (- 0.06%) 4.65s 4.74s
Angular - node (v14.15.1, x64)
Memory used 347,637k (± 0.01%) 347,624k (± 0.01%) -14k (- 0.00%) 347,575k 347,681k
Parse Time 2.10s (± 1.32%) 2.08s (± 0.75%) -0.02s (- 1.00%) 2.04s 2.11s
Bind Time 0.80s (± 0.65%) 0.80s (± 0.77%) +0.00s (+ 0.25%) 0.79s 0.81s
Check Time 5.97s (± 0.49%) 6.00s (± 0.52%) +0.03s (+ 0.47%) 5.95s 6.09s
Emit Time 6.29s (± 0.86%) 6.30s (± 0.64%) +0.01s (+ 0.21%) 6.22s 6.38s
Total Time 15.16s (± 0.44%) 15.17s (± 0.33%) +0.02s (+ 0.10%) 15.12s 15.31s
Compiler-Unions - node (v14.15.1, x64)
Memory used 190,922k (± 0.68%) 190,336k (± 0.01%) -586k (- 0.31%) 190,263k 190,398k
Parse Time 0.86s (± 0.46%) 0.86s (± 0.58%) -0.01s (- 0.58%) 0.85s 0.87s
Bind Time 0.49s (± 0.69%) 0.49s (± 0.81%) -0.00s (- 0.41%) 0.48s 0.50s
Check Time 6.74s (± 0.50%) 6.72s (± 0.56%) -0.01s (- 0.21%) 6.66s 6.80s
Emit Time 2.44s (± 0.81%) 2.42s (± 0.47%) -0.01s (- 0.53%) 2.40s 2.44s
Total Time 10.53s (± 0.31%) 10.50s (± 0.46%) -0.03s (- 0.28%) 10.40s 10.61s
Monaco - node (v14.15.1, x64)
Memory used 326,551k (± 0.01%) 326,587k (± 0.00%) +37k (+ 0.01%) 326,550k 326,616k
Parse Time 1.58s (± 0.59%) 1.58s (± 0.67%) +0.00s (+ 0.19%) 1.57s 1.61s
Bind Time 0.73s (± 0.71%) 0.73s (± 1.21%) +0.00s (+ 0.41%) 0.72s 0.76s
Check Time 5.77s (± 0.50%) 5.78s (± 0.45%) +0.01s (+ 0.16%) 5.72s 5.84s
Emit Time 3.41s (± 1.12%) 3.39s (± 0.86%) -0.02s (- 0.64%) 3.33s 3.45s
Total Time 11.50s (± 0.42%) 11.49s (± 0.47%) -0.01s (- 0.07%) 11.36s 11.58s
TFS - node (v14.15.1, x64)
Memory used 289,705k (± 0.01%) 289,752k (± 0.01%) +48k (+ 0.02%) 289,699k 289,804k
Parse Time 1.29s (± 0.62%) 1.29s (± 0.60%) -0.00s (- 0.08%) 1.28s 1.31s
Bind Time 0.80s (± 0.62%) 0.80s (± 0.72%) -0.00s (- 0.25%) 0.79s 0.82s
Check Time 5.42s (± 0.60%) 5.40s (± 0.39%) -0.01s (- 0.28%) 5.36s 5.47s
Emit Time 3.64s (± 0.66%) 3.64s (± 0.39%) -0.00s (- 0.05%) 3.61s 3.67s
Total Time 11.16s (± 0.43%) 11.13s (± 0.21%) -0.02s (- 0.18%) 11.09s 11.18s
material-ui - node (v14.15.1, x64)
Memory used 435,455k (± 0.01%) 435,445k (± 0.01%) -10k (- 0.00%) 435,407k 435,507k
Parse Time 1.89s (± 0.56%) 1.90s (± 0.73%) +0.00s (+ 0.16%) 1.87s 1.93s
Bind Time 0.58s (± 0.38%) 0.58s (± 0.95%) +0.00s (+ 0.52%) 0.57s 0.59s
Check Time 12.81s (± 0.39%) 12.88s (± 0.73%) +0.07s (+ 0.56%) 12.74s 13.19s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.28s (± 0.32%) 15.36s (± 0.60%) +0.08s (+ 0.50%) 15.20s 15.65s
xstate - node (v14.15.1, x64)
Memory used 544,078k (± 0.00%) 544,073k (± 0.00%) -6k (- 0.00%) 544,032k 544,145k
Parse Time 2.62s (± 0.54%) 2.61s (± 0.69%) -0.01s (- 0.34%) 2.58s 2.66s
Bind Time 0.98s (± 0.94%) 0.98s (± 0.69%) +0.00s (+ 0.20%) 0.97s 1.00s
Check Time 1.52s (± 0.54%) 1.51s (± 0.46%) -0.01s (- 0.92%) 1.49s 1.52s
Emit Time 0.07s (± 0.00%) 0.07s (± 0.00%) 0.00s ( 0.00%) 0.07s 0.07s
Total Time 5.20s (± 0.33%) 5.18s (± 0.31%) -0.02s (- 0.35%) 5.15s 5.22s
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-126-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v18.10.0, x64)
  • Angular - node (v16.17.1, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v18.10.0, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v18.10.0, x64)
  • Monaco - node (v16.17.1, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v18.10.0, x64)
  • TFS - node (v16.17.1, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v18.10.0, x64)
  • material-ui - node (v16.17.1, x64)
  • material-ui - node (v14.15.1, x64)
  • xstate - node (v18.10.0, x64)
  • xstate - node (v16.17.1, x64)
  • xstate - node (v14.15.1, x64)
Benchmark Name Iterations
Current 51324 10
Baseline main 10

TSServer

Comparison Report - main..51324
Metric main 51324 Delta Best Worst
Compiler-UnionsTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 1,061ms (± 0.31%) 1,068ms (± 0.99%) +7ms (+ 0.68%) 1,051ms 1,101ms
Req 2 - geterr 2,716ms (± 0.58%) 2,731ms (± 0.67%) +16ms (+ 0.58%) 2,698ms 2,786ms
Req 3 - references 192ms (± 1.21%) 192ms (± 2.38%) +0ms (+ 0.10%) 188ms 210ms
Req 4 - navto 147ms (± 0.97%) 149ms (± 1.86%) +2ms (+ 1.29%) 145ms 159ms
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) 0 ( 0.00%) 1,356 1,356
Req 5 - completionInfo 44ms (± 0.51%) 45ms (± 2.38%) +1ms (+ 2.73%) 44ms 48ms
CompilerTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 1,132ms (± 0.67%) 1,133ms (± 0.54%) +2ms (+ 0.15%) 1,122ms 1,151ms
Req 2 - geterr 1,600ms (± 0.42%) 1,609ms (± 0.51%) +9ms (+ 0.59%) 1,587ms 1,633ms
Req 3 - references 197ms (± 0.75%) 197ms (± 0.59%) +0ms (+ 0.15%) 194ms 199ms
Req 4 - navto 160ms (± 1.82%) 159ms (± 0.91%) -2ms (- 0.94%) 157ms 162ms
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) 0 ( 0.00%) 1,518 1,518
Req 5 - completionInfo 83ms (± 4.05%) 83ms (± 3.89%) -1ms (- 0.84%) 79ms 94ms
xstateTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 1,626ms (± 0.56%) 1,622ms (± 0.73%) -4ms (- 0.26%) 1,605ms 1,651ms
Req 2 - geterr 577ms (± 0.94%) 575ms (± 0.48%) -2ms (- 0.26%) 569ms 581ms
Req 3 - references 52ms (± 0.97%) 52ms (± 2.77%) +1ms (+ 1.55%) 51ms 58ms
Req 4 - navto 207ms (± 0.77%) 205ms (± 0.73%) -1ms (- 0.58%) 203ms 210ms
Req 5 - completionInfo count 3,209 (± 0.00%) 3,209 (± 0.00%) 0 ( 0.00%) 3,209 3,209
Req 5 - completionInfo 210ms (± 2.20%) 209ms (± 1.64%) -1ms (- 0.67%) 202ms 216ms
Compiler-UnionsTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 1,337ms (± 0.65%) 1,325ms (± 0.33%) -12ms (- 0.91%) 1,313ms 1,333ms
Req 2 - geterr 3,281ms (± 0.42%) 3,265ms (± 0.55%) -16ms (- 0.48%) 3,243ms 3,322ms
Req 3 - references 221ms (± 0.79%) 221ms (± 1.09%) -1ms (- 0.23%) 218ms 229ms
Req 4 - navto 158ms (± 0.60%) 159ms (± 0.84%) +1ms (+ 0.38%) 156ms 162ms
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) 0 ( 0.00%) 1,356 1,356
Req 5 - completionInfo 60ms (±18.01%) 61ms (±18.54%) +1ms (+ 0.83%) 52ms 94ms
CompilerTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 1,404ms (± 0.49%) 1,409ms (± 0.48%) +5ms (+ 0.33%) 1,397ms 1,426ms
Req 2 - geterr 2,109ms (± 0.51%) 2,114ms (± 0.58%) +5ms (+ 0.24%) 2,091ms 2,148ms
Req 3 - references 231ms (± 0.80%) 231ms (± 0.48%) -1ms (- 0.26%) 228ms 234ms
Req 4 - navto 174ms (± 6.08%) 169ms (± 0.66%) -4ms (- 2.42%) 167ms 172ms
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) 0 ( 0.00%) 1,518 1,518
Req 5 - completionInfo 53ms (± 0.95%) 54ms (± 5.70%) +1ms (+ 2.67%) 51ms 63ms
xstateTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 1,935ms (± 0.52%) 1,922ms (± 0.37%) -13ms (- 0.69%) 1,913ms 1,942ms
Req 2 - geterr 730ms (± 0.61%) 733ms (± 0.73%) +3ms (+ 0.45%) 724ms 746ms
Req 3 - references 61ms (± 1.44%) 60ms (± 0.74%) -1ms (- 1.79%) 59ms 61ms
Req 4 - navto 208ms (± 0.89%) 210ms (± 0.97%) +3ms (+ 1.20%) 205ms 214ms
Req 5 - completionInfo count 3,209 (± 0.00%) 3,209 (± 0.00%) 0 ( 0.00%) 3,209 3,209
Req 5 - completionInfo 258ms (± 0.94%) 259ms (± 0.88%) +1ms (+ 0.50%) 255ms 265ms
Compiler-UnionsTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 1,452ms (± 0.65%) 1,452ms (± 0.22%) 0ms ( 0.00%) 1,445ms 1,458ms
Req 2 - geterr 3,529ms (± 0.44%) 3,542ms (± 1.01%) +13ms (+ 0.37%) 3,478ms 3,609ms
Req 3 - references 233ms (± 0.58%) 234ms (± 0.38%) +1ms (+ 0.47%) 232ms 236ms
Req 4 - navto 173ms (± 0.75%) 172ms (± 0.88%) -0ms (- 0.17%) 168ms 175ms
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) 0 ( 0.00%) 1,356 1,356
Req 5 - completionInfo 55ms (± 0.87%) 55ms (± 1.60%) +0ms (+ 0.55%) 54ms 57ms
CompilerTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 1,532ms (± 0.62%) 1,536ms (± 0.68%) +4ms (+ 0.26%) 1,512ms 1,562ms
Req 2 - geterr 2,319ms (± 0.33%) 2,329ms (± 0.31%) +10ms (+ 0.44%) 2,311ms 2,343ms
Req 3 - references 245ms (± 0.40%) 246ms (± 0.83%) +1ms (+ 0.41%) 241ms 250ms
Req 4 - navto 183ms (± 0.64%) 184ms (± 0.70%) +1ms (+ 0.60%) 181ms 186ms
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) 0 ( 0.00%) 1,518 1,518
Req 5 - completionInfo 55ms (± 0.95%) 56ms (± 1.22%) +1ms (+ 1.28%) 54ms 57ms
xstateTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 2,160ms (± 0.60%) 2,157ms (± 0.51%) -3ms (- 0.12%) 2,142ms 2,195ms
Req 2 - geterr 760ms (± 0.51%) 763ms (± 0.42%) +3ms (+ 0.36%) 754ms 770ms
Req 3 - references 66ms (± 1.91%) 66ms (± 2.70%) +0ms (+ 0.30%) 64ms 70ms
Req 4 - navto 229ms (± 0.58%) 230ms (± 0.76%) +1ms (+ 0.48%) 226ms 233ms
Req 5 - completionInfo count 3,209 (± 0.00%) 3,209 (± 0.00%) 0 ( 0.00%) 3,209 3,209
Req 5 - completionInfo 281ms (± 0.53%) 286ms (± 3.82%) +6ms (+ 2.07%) 277ms 330ms
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-126-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Compiler-UnionsTSServer - node (v18.10.0, x64)
  • Compiler-UnionsTSServer - node (v16.17.1, x64)
  • Compiler-UnionsTSServer - node (v14.15.1, x64)
  • CompilerTSServer - node (v18.10.0, x64)
  • CompilerTSServer - node (v16.17.1, x64)
  • CompilerTSServer - node (v14.15.1, x64)
  • xstateTSServer - node (v18.10.0, x64)
  • xstateTSServer - node (v16.17.1, x64)
  • xstateTSServer - node (v14.15.1, x64)
Benchmark Name Iterations
Current 51324 10
Baseline main 10

Developer Information:

Download Benchmark

@jakebailey
Copy link
Member Author

jakebailey commented Oct 27, 2022

Seems like the perf difference was just noise.

@jakebailey
Copy link
Member Author

jakebailey commented Oct 27, 2022

Of course, I am left wondering why our deltas don't have error bars, only the raw numbers.

@jakebailey
Copy link
Member Author

jakebailey commented Oct 28, 2022

Using this PR to test my new benchmark.

@typescript-bot perf test this

@typescript-bot

This comment was marked as outdated.

Sign in to view
@typescript-bot

This comment was marked as outdated.

Sign in to view
@jakebailey
Copy link
Member Author

jakebailey commented Oct 28, 2022

I oopsed.

@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Oct 28, 2022 •
edited
Loading

Heya @jakebailey, I've started to run the perf test suite on this PR at d5be437. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Oct 28, 2022

@jakebailey
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..51324
Metric main 51324 Delta Best Worst
Angular - node (v18.10.0, x64)
Memory used 353,950k (± 0.02%) 353,936k (± 0.02%) -14k (- 0.00%) 353,748k 354,053k
Parse Time 1.55s (± 0.81%) 1.55s (± 0.59%) -0.00s (- 0.32%) 1.54s 1.57s
Bind Time 0.61s (± 0.66%) 0.61s (± 1.27%) +0.00s (+ 0.33%) 0.60s 0.63s
Check Time 4.42s (± 0.43%) 4.42s (± 0.46%) -0.00s (- 0.05%) 4.39s 4.48s
Emit Time 4.93s (± 0.64%) 4.92s (± 0.61%) -0.01s (- 0.20%) 4.84s 4.97s
Total Time 11.51s (± 0.23%) 11.50s (± 0.37%) -0.01s (- 0.11%) 11.41s 11.62s
Compiler-Unions - node (v18.10.0, x64)
Memory used 199,674k (± 0.96%) 199,656k (± 0.95%) -18k (- 0.01%) 195,670k 201,433k
Parse Time 0.60s (± 0.96%) 0.60s (± 0.92%) +0.00s (+ 0.33%) 0.59s 0.61s
Bind Time 0.36s (± 0.92%) 0.36s (± 1.60%) +0.00s (+ 0.83%) 0.35s 0.38s
Check Time 5.35s (± 0.68%) 5.37s (± 0.62%) +0.02s (+ 0.30%) 5.28s 5.41s
Emit Time 1.82s (± 0.71%) 1.80s (± 0.73%) -0.02s (- 1.15%) 1.78s 1.84s
Total Time 8.14s (± 0.50%) 8.13s (± 0.54%) -0.01s (- 0.07%) 8.02s 8.19s
Monaco - node (v18.10.0, x64)
Memory used 331,743k (± 0.02%) 331,780k (± 0.02%) +37k (+ 0.01%) 331,679k 331,907k
Parse Time 1.17s (± 0.50%) 1.17s (± 0.58%) -0.00s (- 0.09%) 1.15s 1.18s
Bind Time 0.56s (± 1.45%) 0.56s (± 0.85%) -0.00s (- 0.54%) 0.55s 0.57s
Check Time 4.31s (± 0.39%) 4.31s (± 0.73%) -0.00s (- 0.02%) 4.25s 4.41s
Emit Time 2.62s (± 0.79%) 2.64s (± 0.46%) +0.02s (+ 0.61%) 2.62s 2.68s
Total Time 8.66s (± 0.33%) 8.67s (± 0.49%) +0.01s (+ 0.08%) 8.58s 8.77s
TFS - node (v18.10.0, x64)
Memory used 294,730k (± 0.01%) 294,776k (± 0.01%) +46k (+ 0.02%) 294,725k 294,841k
Parse Time 0.94s (± 1.34%) 0.93s (± 0.78%) -0.01s (- 0.75%) 0.92s 0.95s
Bind Time 0.59s (± 3.38%) 0.58s (± 3.39%) -0.01s (- 1.36%) 0.55s 0.62s
Check Time 4.04s (± 0.61%) 4.02s (± 0.41%) -0.02s (- 0.50%) 3.97s 4.06s
Emit Time 2.66s (± 0.67%) 2.64s (± 0.91%) -0.02s (- 0.90%) 2.59s 2.69s
Total Time 8.22s (± 0.57%) 8.17s (± 0.47%) -0.05s (- 0.64%) 8.10s 8.26s
material-ui - node (v18.10.0, x64)
Memory used 439,916k (± 0.01%) 439,928k (± 0.02%) +12k (+ 0.00%) 439,813k 440,074k
Parse Time 1.37s (± 1.18%) 1.35s (± 0.82%) -0.01s (- 0.95%) 1.33s 1.38s
Bind Time 0.44s (± 1.01%) 0.45s (± 1.06%) +0.01s (+ 1.13%) 0.44s 0.46s
Check Time 10.96s (± 0.91%) 10.88s (± 0.83%) -0.08s (- 0.72%) 10.72s 11.14s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 12.77s (± 0.75%) 12.68s (± 0.73%) -0.09s (- 0.70%) 12.54s 12.96s
xstate - node (v18.10.0, x64)
Memory used 557,195k (± 0.01%) 557,263k (± 0.02%) +69k (+ 0.01%) 557,118k 557,488k
Parse Time 1.91s (± 0.23%) 1.91s (± 0.47%) -0.00s (- 0.05%) 1.89s 1.93s
Bind Time 0.68s (± 2.22%) 0.68s (± 1.20%) -0.00s (- 0.29%) 0.66s 0.70s
Check Time 1.11s (± 1.20%) 1.11s (± 1.05%) -0.01s (- 0.72%) 1.09s 1.14s
Emit Time 0.06s (± 0.00%) 0.06s (± 0.00%) 0.00s ( 0.00%) 0.06s 0.06s
Total Time 3.76s (± 0.54%) 3.75s (± 0.53%) -0.01s (- 0.35%) 3.71s 3.80s
Angular - node (v16.17.1, x64)
Memory used 353,351k (± 0.02%) 353,384k (± 0.01%) +32k (+ 0.01%) 353,223k 353,453k
Parse Time 1.90s (± 0.59%) 1.92s (± 0.90%) +0.02s (+ 0.95%) 1.89s 1.98s
Bind Time 0.75s (± 0.48%) 0.75s (± 0.89%) -0.01s (- 0.93%) 0.73s 0.76s
Check Time 5.69s (± 0.70%) 5.68s (± 0.38%) -0.01s (- 0.25%) 5.65s 5.75s
Emit Time 6.11s (± 0.80%) 6.08s (± 0.48%) -0.03s (- 0.51%) 6.00s 6.12s
Total Time 14.46s (± 0.42%) 14.42s (± 0.21%) -0.04s (- 0.26%) 14.34s 14.47s
Compiler-Unions - node (v16.17.1, x64)
Memory used 197,742k (± 0.37%) 198,711k (± 0.60%) +969k (+ 0.49%) 197,368k 200,736k
Parse Time 0.78s (± 0.67%) 0.78s (± 0.63%) +0.01s (+ 0.64%) 0.78s 0.80s
Bind Time 0.45s (± 0.80%) 0.45s (± 0.80%) +0.00s (+ 0.00%) 0.45s 0.46s
Check Time 6.46s (± 0.70%) 6.41s (± 0.57%) -0.05s (- 0.82%) 6.36s 6.53s
Emit Time 2.30s (± 1.13%) 2.27s (± 0.64%) -0.03s (- 1.26%) 2.24s 2.30s
Total Time 10.00s (± 0.44%) 9.92s (± 0.37%) -0.08s (- 0.82%) 9.84s 10.01s
Monaco - node (v16.17.1, x64)
Memory used 331,198k (± 0.01%) 331,240k (± 0.01%) +42k (+ 0.01%) 331,136k 331,308k
Parse Time 1.43s (± 0.80%) 1.44s (± 0.76%) +0.01s (+ 0.35%) 1.42s 1.46s
Bind Time 0.69s (± 0.75%) 0.69s (± 0.43%) -0.00s (- 0.15%) 0.68s 0.69s
Check Time 5.47s (± 0.44%) 5.49s (± 0.57%) +0.02s (+ 0.31%) 5.44s 5.55s
Emit Time 3.25s (± 0.40%) 3.25s (± 0.64%) +0.00s (+ 0.06%) 3.20s 3.31s
Total Time 10.84s (± 0.25%) 10.86s (± 0.31%) +0.02s (+ 0.19%) 10.77s 10.93s
TFS - node (v16.17.1, x64)
Memory used 294,099k (± 0.02%) 294,103k (± 0.01%) +4k (+ 0.00%) 293,967k 294,189k
Parse Time 1.24s (± 0.78%) 1.22s (± 1.15%) -0.02s (- 1.45%) 1.19s 1.25s
Bind Time 0.65s (± 1.00%) 0.64s (± 0.52%) -0.01s (- 1.23%) 0.63s 0.65s
Check Time 5.13s (± 0.65%) 5.13s (± 0.37%) +0.00s (+ 0.06%) 5.10s 5.19s
Emit Time 3.49s (± 0.65%) 3.46s (± 0.77%) -0.03s (- 0.86%) 3.39s 3.51s
Total Time 10.51s (± 0.41%) 10.46s (± 0.37%) -0.05s (- 0.52%) 10.40s 10.59s
material-ui - node (v16.17.1, x64)
Memory used 439,288k (± 0.01%) 439,270k (± 0.01%) -18k (- 0.00%) 439,174k 439,328k
Parse Time 1.75s (± 1.38%) 1.71s (± 0.85%) -0.04s (- 2.17%) 1.68s 1.76s
Bind Time 0.54s (± 0.74%) 0.54s (± 1.07%) -0.00s (- 0.18%) 0.53s 0.55s
Check Time 12.52s (± 0.60%) 12.50s (± 0.78%) -0.02s (- 0.15%) 12.35s 12.73s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 14.81s (± 0.48%) 14.75s (± 0.65%) -0.06s (- 0.40%) 14.60s 14.99s
xstate - node (v16.17.1, x64)
Memory used 555,016k (± 0.02%) 554,979k (± 0.01%) -37k (- 0.01%) 554,874k 555,134k
Parse Time 2.31s (± 0.43%) 2.31s (± 0.44%) +0.00s (+ 0.17%) 2.29s 2.34s
Bind Time 0.89s (± 1.26%) 0.88s (± 0.70%) -0.01s (- 0.90%) 0.87s 0.90s
Check Time 1.44s (± 0.70%) 1.43s (± 0.43%) -0.01s (- 0.35%) 1.42s 1.44s
Emit Time 0.07s (± 3.23%) 0.07s (± 5.51%) 🟩-0.00s (- 4.35%) 0.06s 0.07s
Total Time 4.70s (± 0.43%) 4.70s (± 0.19%) -0.01s (- 0.15%) 4.67s 4.71s
Angular - node (v14.15.1, x64)
Memory used 347,588k (± 0.01%) 347,575k (± 0.01%) -13k (- 0.00%) 347,505k 347,665k
Parse Time 2.09s (± 0.64%) 2.08s (± 0.62%) -0.01s (- 0.33%) 2.07s 2.13s
Bind Time 0.81s (± 0.85%) 0.80s (± 1.08%) -0.00s (- 0.37%) 0.79s 0.83s
Check Time 6.00s (± 0.65%) 5.96s (± 0.36%) -0.03s (- 0.57%) 5.93s 6.02s
Emit Time 6.26s (± 0.73%) 6.29s (± 0.85%) +0.03s (+ 0.45%) 6.21s 6.44s
Total Time 15.16s (± 0.46%) 15.14s (± 0.35%) -0.02s (- 0.13%) 15.05s 15.29s
Compiler-Unions - node (v14.15.1, x64)
Memory used 191,516k (± 0.90%) 191,498k (± 0.91%) -18k (- 0.01%) 190,262k 196,200k
Parse Time 0.86s (± 0.75%) 0.86s (± 0.89%) -0.01s (- 0.81%) 0.84s 0.87s
Bind Time 0.49s (± 1.18%) 0.49s (± 0.81%) -0.00s (- 0.41%) 0.48s 0.50s
Check Time 6.76s (± 0.73%) 6.75s (± 0.67%) -0.01s (- 0.16%) 6.65s 6.86s
Emit Time 2.44s (± 0.86%) 2.44s (± 0.75%) -0.00s (- 0.16%) 2.39s 2.47s
Total Time 10.56s (± 0.61%) 10.53s (± 0.60%) -0.03s (- 0.24%) 10.39s 10.68s
Monaco - node (v14.15.1, x64)
Memory used 326,529k (± 0.01%) 326,589k (± 0.01%) +60k (+ 0.02%) 326,553k 326,626k
Parse Time 1.58s (± 0.67%) 1.58s (± 0.48%) -0.00s (- 0.06%) 1.56s 1.59s
Bind Time 0.74s (± 0.68%) 0.73s (± 0.46%) -0.00s (- 0.27%) 0.73s 0.74s
Check Time 5.78s (± 0.55%) 5.77s (± 0.54%) -0.01s (- 0.17%) 5.70s 5.82s
Emit Time 3.40s (± 0.47%) 3.38s (± 0.82%) -0.01s (- 0.38%) 3.34s 3.46s
Total Time 11.49s (± 0.28%) 11.46s (± 0.43%) -0.02s (- 0.19%) 11.37s 11.58s
TFS - node (v14.15.1, x64)
Memory used 289,733k (± 0.01%) 289,750k (± 0.01%) +17k (+ 0.01%) 289,679k 289,807k
Parse Time 1.30s (± 1.15%) 1.29s (± 0.82%) -0.01s (- 1.08%) 1.26s 1.31s
Bind Time 0.80s (± 1.25%) 0.79s (± 1.46%) -0.01s (- 1.24%) 0.75s 0.81s
Check Time 5.42s (± 0.44%) 5.39s (± 0.25%) -0.03s (- 0.61%) 5.37s 5.42s
Emit Time 3.63s (± 0.87%) 3.63s (± 0.76%) +0.00s (+ 0.06%) 3.58s 3.73s
Total Time 11.16s (± 0.32%) 11.10s (± 0.42%) -0.05s (- 0.47%) 11.04s 11.28s
material-ui - node (v14.15.1, x64)
Memory used 435,425k (± 0.01%) 435,423k (± 0.01%) -2k (- 0.00%) 435,369k 435,497k
Parse Time 1.89s (± 0.54%) 1.89s (± 0.29%) +0.00s (+ 0.16%) 1.87s 1.90s
Bind Time 0.59s (± 1.01%) 0.58s (± 1.11%) -0.00s (- 0.68%) 0.57s 0.60s
Check Time 12.83s (± 0.72%) 12.84s (± 0.92%) +0.01s (+ 0.05%) 12.60s 13.21s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.30s (± 0.63%) 15.30s (± 0.78%) +0.01s (+ 0.05%) 15.08s 15.69s
xstate - node (v14.15.1, x64)
Memory used 543,992k (± 0.00%) 544,002k (± 0.00%) +10k (+ 0.00%) 543,970k 544,043k
Parse Time 2.60s (± 0.32%) 2.60s (± 0.45%) +0.00s (+ 0.12%) 2.58s 2.63s
Bind Time 0.99s (± 1.74%) 0.98s (± 0.97%) -0.01s (- 0.91%) 0.96s 1.00s
Check Time 1.53s (± 0.63%) 1.51s (± 0.55%) -0.01s (- 0.92%) 1.50s 1.54s
Emit Time 0.07s (± 3.14%) 0.07s (± 0.00%) -0.00s (- 1.41%) 0.07s 0.07s
Total Time 5.19s (± 0.54%) 5.18s (± 0.27%) -0.02s (- 0.33%) 5.14s 5.20s
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-126-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v18.10.0, x64)
  • Angular - node (v16.17.1, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v18.10.0, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v18.10.0, x64)
  • Monaco - node (v16.17.1, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v18.10.0, x64)
  • TFS - node (v16.17.1, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v18.10.0, x64)
  • material-ui - node (v16.17.1, x64)
  • material-ui - node (v14.15.1, x64)
  • xstate - node (v18.10.0, x64)
  • xstate - node (v16.17.1, x64)
  • xstate - node (v14.15.1, x64)
Benchmark Name Iterations
Current 51324 10
Baseline main 10

TSServer

Comparison Report - main..51324
Metric main 51324 Delta Best Worst
Compiler-UnionsTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 1,067ms (± 0.54%) 1,062ms (± 0.67%) -6ms (- 0.53%) 1,046ms 1,084ms
Req 2 - geterr 2,727ms (± 0.61%) 2,721ms (± 0.79%) -7ms (- 0.24%) 2,681ms 2,778ms
Req 3 - references 192ms (± 1.27%) 191ms (± 0.87%) -1ms (- 0.31%) 187ms 196ms
Req 4 - navto 148ms (± 1.56%) 146ms (± 1.27%) -2ms (- 1.02%) 143ms 150ms
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) 0 ( 0.00%) 1,356 1,356
Req 5 - completionInfo 44ms (± 1.02%) 44ms (± 1.53%) -0ms (- 0.23%) 43ms 45ms
CompilerTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 1,139ms (± 0.42%) 1,131ms (± 0.95%) -8ms (- 0.69%) 1,112ms 1,164ms
Req 2 - geterr 1,614ms (± 0.49%) 1,611ms (± 0.60%) -3ms (- 0.19%) 1,586ms 1,634ms
Req 3 - references 198ms (± 0.53%) 198ms (± 0.59%) -1ms (- 0.40%) 194ms 199ms
Req 4 - navto 161ms (± 1.63%) 160ms (± 1.53%) -1ms (- 0.44%) 154ms 165ms
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) 0 ( 0.00%) 1,518 1,518
Req 5 - completionInfo 85ms (± 4.36%) 80ms (± 3.32%) 🟩-5ms (- 5.56%) 76ms 87ms
xstateTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 1,625ms (± 0.54%) 1,629ms (± 0.85%) +4ms (+ 0.22%) 1,605ms 1,657ms
Req 2 - geterr 576ms (± 0.56%) 569ms (± 0.37%) -6ms (- 1.06%) 567ms 576ms
Req 3 - references 53ms (± 2.30%) 51ms (± 0.96%) -1ms (- 2.10%) 51ms 53ms
Req 4 - navto 207ms (± 1.02%) 207ms (± 0.91%) +0ms (+ 0.10%) 203ms 210ms
Req 5 - completionInfo count 3,209 (± 0.00%) 3,209 (± 0.00%) 0 ( 0.00%) 3,209 3,209
Req 5 - completionInfo 208ms (± 1.81%) 207ms (± 1.16%) -1ms (- 0.48%) 203ms 214ms
Compiler-UnionsTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 1,325ms (± 0.62%) 1,322ms (± 0.51%) -4ms (- 0.27%) 1,303ms 1,331ms
Req 2 - geterr 3,271ms (± 0.72%) 3,297ms (± 1.07%) +26ms (+ 0.79%) 3,240ms 3,416ms
Req 3 - references 222ms (± 0.55%) 220ms (± 0.84%) -1ms (- 0.54%) 216ms 225ms
Req 4 - navto 159ms (± 0.64%) 158ms (± 0.63%) -1ms (- 0.38%) 156ms 160ms
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) 0 ( 0.00%) 1,356 1,356
Req 5 - completionInfo 53ms (± 1.46%) 53ms (± 0.65%) -0ms (- 0.75%) 52ms 53ms
CompilerTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 1,415ms (± 0.73%) 1,406ms (± 0.41%) -9ms (- 0.65%) 1,393ms 1,422ms
Req 2 - geterr 2,112ms (± 0.52%) 2,113ms (± 0.46%) +1ms (+ 0.03%) 2,100ms 2,141ms
Req 3 - references 233ms (± 0.49%) 231ms (± 0.56%) -3ms (- 1.07%) 228ms 234ms
Req 4 - navto 171ms (± 1.00%) 169ms (± 1.09%) -2ms (- 1.00%) 166ms 174ms
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) 0 ( 0.00%) 1,518 1,518
Req 5 - completionInfo 54ms (± 5.28%) 51ms (± 0.96%) 🟩-2ms (- 3.93%) 51ms 53ms
xstateTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 1,932ms (± 0.32%) 1,928ms (± 0.49%) -4ms (- 0.19%) 1,913ms 1,950ms
Req 2 - geterr 733ms (± 0.50%) 732ms (± 0.56%) -1ms (- 0.16%) 723ms 742ms
Req 3 - references 60ms (± 0.96%) 61ms (± 0.82%) +0ms (+ 0.33%) 60ms 62ms
Req 4 - navto 208ms (± 0.46%) 209ms (± 0.67%) +2ms (+ 0.72%) 206ms 212ms
Req 5 - completionInfo count 3,209 (± 0.00%) 3,209 (± 0.00%) 0 ( 0.00%) 3,209 3,209
Req 5 - completionInfo 258ms (± 0.69%) 257ms (± 0.98%) -1ms (- 0.43%) 250ms 262ms
Compiler-UnionsTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 1,462ms (± 0.43%) 1,453ms (± 0.56%) -8ms (- 0.57%) 1,438ms 1,476ms
Req 2 - geterr 3,551ms (± 0.49%) 3,527ms (± 0.26%) -24ms (- 0.68%) 3,510ms 3,550ms
Req 3 - references 234ms (± 0.91%) 233ms (± 0.71%) -2ms (- 0.68%) 227ms 236ms
Req 4 - navto 174ms (± 0.91%) 172ms (± 0.44%) -1ms (- 0.81%) 171ms 174ms
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) 0 ( 0.00%) 1,356 1,356
Req 5 - completionInfo 56ms (± 1.61%) 56ms (± 1.61%) 0ms ( 0.00%) 54ms 58ms
CompilerTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 1,533ms (± 1.12%) 1,529ms (± 0.61%) -4ms (- 0.25%) 1,507ms 1,548ms
Req 2 - geterr 2,328ms (± 0.46%) 2,318ms (± 0.47%) -10ms (- 0.42%) 2,298ms 2,339ms
Req 3 - references 245ms (± 0.72%) 247ms (± 0.89%) +2ms (+ 0.61%) 241ms 251ms
Req 4 - navto 183ms (± 0.83%) 185ms (± 0.74%) +2ms (+ 0.82%) 181ms 188ms
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) 0 ( 0.00%) 1,518 1,518
Req 5 - completionInfo 55ms (± 1.12%) 55ms (± 1.21%) +0ms (+ 0.73%) 54ms 57ms
xstateTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 2,139ms (± 0.71%) 2,145ms (± 0.42%) +6ms (+ 0.29%) 2,123ms 2,163ms
Req 2 - geterr 758ms (± 0.49%) 761ms (± 0.45%) +4ms (+ 0.48%) 755ms 769ms
Req 3 - references 69ms (± 3.07%) 66ms (± 1.70%) 🟩-3ms (- 4.06%) 64ms 69ms
Req 4 - navto 230ms (± 0.82%) 230ms (± 0.82%) 0ms ( 0.00%) 226ms 234ms
Req 5 - completionInfo count 3,209 (± 0.00%) 3,209 (± 0.00%) 0 ( 0.00%) 3,209 3,209
Req 5 - completionInfo 279ms (± 4.86%) 276ms (± 0.97%) -3ms (- 0.97%) 268ms 279ms
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-126-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Compiler-UnionsTSServer - node (v18.10.0, x64)
  • Compiler-UnionsTSServer - node (v16.17.1, x64)
  • Compiler-UnionsTSServer - node (v14.15.1, x64)
  • CompilerTSServer - node (v18.10.0, x64)
  • CompilerTSServer - node (v16.17.1, x64)
  • CompilerTSServer - node (v14.15.1, x64)
  • xstateTSServer - node (v18.10.0, x64)
  • xstateTSServer - node (v16.17.1, x64)
  • xstateTSServer - node (v14.15.1, x64)
Benchmark Name Iterations
Current 51324 10
Baseline main 10

Startup

Comparison Report - main..51324
Metric main 51324 Delta Best Worst
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-126-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • tsc-startup - node (v16.17.1, x64)
  • tsserver-startup - node (v16.17.1, x64)
  • tsserverlibrary-startup - node (v16.17.1, x64)
  • typescript-startup - node (v16.17.1, x64)
Benchmark Name Iterations
Current 51324 10
Baseline main 10

Developer Information:

Download Benchmark

@jakebailey
Copy link
Member Author

jakebailey commented Oct 28, 2022

Well, I give up on that benchmark for now. Will fix it later. Merging.

@jakebailey jakebailey merged commit 3d2b401 into microsoft:main Oct 28, 2022
@jakebailey jakebailey deleted the fix-35004 branch October 28, 2022 03:27
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DanielRosenwasser DanielRosenwasser DanielRosenwasser approved these changes

@weswigham weswigham Awaiting requested review from weswigham

@andrewbranch andrewbranch Awaiting requested review from andrewbranch

Assignees

@jakebailey jakebailey

Labels

Author: Team For Milestone Bug PRs that fix a bug with a specific milestone

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Assertion functions don't work with wildcard imports

3 participants

@jakebailey @typescript-bot @DanielRosenwasser