Conversation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the emit for a
for..instatement containing ayieldwhen emitting a downlevel generator to more accurately align with EnumerateObjectProperties, which states (emphasis added):This is achieved by adding an extra
if (!(key in obj)) continuetest at the top of the transformed loop body so that we can skip over deleted properties. We don't make any changes to handle newly added properties since that is spec'd to be implementation defined behavior (per the "not guaranteed" statement in the above condition).Fixes #49808