Set impliedNodeFormat on sourceFile we get from host to ensure the field is set correctly#50977
Merged
sheetalkamat merged 8 commits intomainfrom Oct 31, 2022
Merged
Set impliedNodeFormat on sourceFile we get from host to ensure the field is set correctly#50977sheetalkamat merged 8 commits intomainfrom
sheetalkamat merged 8 commits intomainfrom
Conversation
typescript-bot
added
the
For Milestone Bug
DanielRosenwasser
approved these changes
Sep 28, 2022
sheetalkamat
changed the title
DanielRosenwasser
approved these changes
Sep 28, 2022
weswigham
reviewed
Sep 28, 2022
weswigham
reviewed
Sep 28, 2022
amcasey
approved these changes
Oct 31, 2022
Member
|
@typescript-bot cherry-pick this to release-4.9 |
Collaborator
|
Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into |
Collaborator
|
Hey @DanielRosenwasser, I've opened #51363 for you. |
typescript-bot
pushed a commit
to typescript-bot/TypeScript
that referenced
this pull request
Oct 31, 2022
Component commits: 05d739b Add test that fails c8ebfb8 Handle impliedNodeFormat when handling sourceFileCache Fixes microsoft#50872 5c98b9c Revert the fix 651a47f Make sure impliedNodeFormat is set for the sourceFile 2c22989 Revert "Make sure impliedNodeFormat is set for the sourceFile" This reverts commit 651a47f. 92bf32d Revert "Revert the fix" This reverts commit 5c98b9c. 5f7bc05 Merge branch 'main' into tsBuildImpliedNodeFormat 4bd8b9b Swap the keys for map
Member
|
I don't know if this will work after-the-fact but @typescript-bot user test tsserver |
Collaborator
|
Heya @DanielRosenwasser, I've started to run the diff-based user code test suite (tsserver) on this PR at 4bd8b9b. You can monitor the build here. |
Collaborator
|
Heya @DanielRosenwasser, I've started to run the diff-based top-repos suite (tsserver) on this PR at 4bd8b9b. You can monitor the build here. |
DanielRosenwasser
pushed a commit
that referenced
this pull request
Oct 31, 2022
Component commits: 05d739b Add test that fails c8ebfb8 Handle impliedNodeFormat when handling sourceFileCache Fixes #50872 5c98b9c Revert the fix 651a47f Make sure impliedNodeFormat is set for the sourceFile 2c22989 Revert "Make sure impliedNodeFormat is set for the sourceFile" This reverts commit 651a47f. 92bf32d Revert "Revert the fix" This reverts commit 5c98b9c. 5f7bc05 Merge branch 'main' into tsBuildImpliedNodeFormat 4bd8b9b Swap the keys for map Co-authored-by: Sheetal Nandi <[email protected]>
This fixes issue with using same source file between two programs when impliedNodeFormat was different in tsbuild mode.
Fixes #50872