Skip to content

Handle more places where package direcroy is converted to canonical file path#50740

Merged
sheetalkamat merged 2 commits intomainfrom
nodeNextFileCasing
Sep 12, 2022
Merged

Handle more places where package direcroy is converted to canonical file path#50740
sheetalkamat merged 2 commits intomainfrom
nodeNextFileCasing

Conversation

@sheetalkamat
Copy link
Copy Markdown
Member

@sheetalkamat sheetalkamat commented Sep 12, 2022 •
edited
Loading

  1. Make sure package info is not queried on canonical file path
  2. Verify packageDirectory before sending package info with same pacageDirectory from cache. This should ensure the packageJsonInfo should always have packageDirectory matching the case with requested path

Fixes: #50557 (comment)

Loading
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@weswigham weswigham weswigham approved these changes

@andrewbranch andrewbranch Awaiting requested review from andrewbranch

+1 more reviewer

@amcasey amcasey amcasey left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@sheetalkamat sheetalkamat

Labels

Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

None yet

Milestone

TypeScript 4.8.4

Development

Successfully merging this pull request may close these issues.

5 participants

@sheetalkamat @typescript-bot @weswigham @amcasey @andrewbranch