Fix bugs in module specifier generation with paths/typesVersions#49792
Merged
andrewbranch merged 6 commits intomicrosoft:mainfrom Aug 3, 2022
Merged
Fix bugs in module specifier generation with paths/typesVersions#49792andrewbranch merged 6 commits intomicrosoft:mainfrom
paths/typesVersions#49792andrewbranch merged 6 commits intomicrosoft:mainfrom
Conversation
typescript-bot
added
Author: Team
For Milestone Bug
Member
Author
|
@typescript-bot perf test this |
Collaborator
|
Heya @andrewbranch, I've started to run the perf test suite on this PR at 45f4adc. You can monitor the build here. Update: The results are in! |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Collaborator
|
@andrewbranch Here they are:
CompilerComparison Report - main..49792
System
Hosts
Scenarios
TSServerComparison Report - main..49792
System
Hosts
Scenarios
Developer Information: |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| validateEnding({ ending, value }) | ||
| ) { | ||
| const matchedStar = value.substring(prefix.length, value.length - suffix.length); | ||
| return key.replace("*", matchedStar); |
Check failure
Code scanning / CodeQL
Incomplete string escaping or encoding
jakebailey
approved these changes
Aug 3, 2022
| // importNameCodeFix_typesVersions.ts for an example.) | ||
| const mainExportFile = toPath(mainFileRelative, packageRootPath, getCanonicalFileName); | ||
| if (removeFileExtension(mainExportFile) === removeFileExtension(getCanonicalFileName(moduleFileToTry))) { | ||
| // ^ An arbitrary removal of file extension for this comparison is almost certainly wrong |
Member
There was a problem hiding this comment.
Is this intended to be a TODO?
Member
Author
There was a problem hiding this comment.
More of a hint for a future developer investigating bugs in this area—a TODO only if prompted by a user report.
|
|
||
| // Simplify the full file path to something that can be resolved by Node. | ||
|
|
||
| const preferences = getPreferences(host, userPreferences, options, importingSourceFile); |
Member
There was a problem hiding this comment.
Is this used outside the if block, or is it so cheap that it just doesn't matter where it is?
Member
Author
There was a problem hiding this comment.
I assume I had a reason to move it; maybe refactored away in later edits, but it is trivially cheap.
Member
Author
|
Thanks for the review! I forgot this was the one with the big table. Writing that out actually helped my clarify my mental model of module specifier generation a lot, which was a topic I thought I already understood well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was much more difficult to do correctly than I expected, but it fixes more than what I set out to fix.
Fixes #49034
Fixes #49290