Account for type parameters in missing function codefix #49727
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaKGoldberg
force-pushed
the
codefix-missing-function-generic
branch
from
107164d to
e157bff
Compare
JoshuaKGoldberg
commented
Jun 29, 2022
sandersn
requested changes
Jul 18, 2022
Member
sandersn
left a comment
sandersn
left a comment
There was a problem hiding this comment.
Initial comments, although I still need to read getArgumentTypesAndTypeParameters more closely
tests/cases/fourslash/incompleteFunctionCallCodefixTypeKeyof.ts
Outdated
Show resolved
Hide resolved
tests/cases/fourslash/incompleteFunctionCallCodefixTypeParameterConstrained.ts
Outdated
Show resolved
Hide resolved
tests/cases/fourslash/incompleteFunctionCallCodefixTypeParameterNarrowed.ts
Show resolved
Hide resolved
5 tasks
Co-authored-by: Nathan Shively-Sanders <[email protected]>
sandersn
approved these changes
Jul 26, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to any explicit type parameters, also accounts for any type parameters in the types of arguments.
I noticed both callers ofEdit: no longer true as of #50004. Reverted.typeToAutoImportableTypeNodeusechecker.getBaseTypeOfLiteralType, so I deduplicated & moved that inside the function.Fixes #49693