Respect importModuleSpecifierEnding inside node_modules packages#48995
Merged
andrewbranch merged 2 commits intomicrosoft:mainfrom May 6, 2022
Merged
Respect importModuleSpecifierEnding inside node_modules packages#48995andrewbranch merged 2 commits intomicrosoft:mainfrom
andrewbranch merged 2 commits intomicrosoft:mainfrom
Conversation
typescript-bot
added
Author: Team
For Milestone Bug
andrewbranch
commented
May 6, 2022
sandersn
reviewed
May 6, 2022
| // @Filename: /a.ts | ||
| //// customElement/**/ | ||
|
|
||
| verify.importFixModuleSpecifiers("", ["lit/decorators.js"], { importModuleSpecifierEnding: "js" }) |
Member
There was a problem hiding this comment.
should there be a test for .cjs/.mjs as well, since you mentioned that they were broken before?
Member
There was a problem hiding this comment.
also, are there already tests for filename/package conflicts? I assume yes.
Member
Author
There was a problem hiding this comment.
There are .cjs tests. Filename/package conflicts aren’t related to this change, I think.
| } | ||
|
|
||
| function tryGetModuleNameAsNodeModule({ path, isRedirect }: ModulePath, { getCanonicalFileName, sourceDirectory }: Info, importingSourceFile: SourceFile , host: ModuleSpecifierResolutionHost, options: CompilerOptions, packageNameOnly?: boolean, overrideMode?: ModuleKind.ESNext | ModuleKind.CommonJS): string | undefined { | ||
| function tryGetModuleNameAsNodeModule({ path, isRedirect }: ModulePath, { getCanonicalFileName, sourceDirectory }: Info, importingSourceFile: SourceFile , host: ModuleSpecifierResolutionHost, options: CompilerOptions, userPreferences: UserPreferences, packageNameOnly?: boolean, overrideMode?: ModuleKind.ESNext | ModuleKind.CommonJS): string | undefined { |
sheetalkamat
approved these changes
May 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #48991