Harden combineProjectOutputForReferences against empty results #48978
+7
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Getting an empty result doesn't seem expected, but a deeper fix doesn't make sense until microsoft#48619 is merged. Fixes microsoft#48963
typescript-bot
added
Author: Team
For Milestone Bug
DanielRosenwasser
approved these changes
May 5, 2022
amcasey
added a commit
to amcasey/TypeScript
that referenced
this pull request
May 26, 2022
The old regression test didn't catch the corresponding bug in the new code because it hit the fast path where there's only a single project.
amcasey
added a commit
that referenced
this pull request
May 27, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting an empty result doesn't seem expected, but a deeper fix doesn't make sense until #48619 is merged.
Fixes #48963