Remove unnecessary check in getNarrowableTypeForReference#47953
Merged
ahejlsberg merged 2 commits intomainfrom Feb 18, 2022
Merged
Remove unnecessary check in getNarrowableTypeForReference#47953ahejlsberg merged 2 commits intomainfrom
ahejlsberg merged 2 commits intomainfrom
Conversation
typescript-bot
added
Author: Team
For Milestone Bug
Member
Author
|
@RyanCavanaugh @DanielRosenwasser We'll want to cherry pick this one. |
RyanCavanaugh
approved these changes
Feb 18, 2022
Member
|
@typescript-bot cherry-pick this to release-4.6 |
Collaborator
|
Heya @RyanCavanaugh, I've started to run the task to cherry-pick this into |
Collaborator
|
Hey @RyanCavanaugh, I've opened #47957 for you. |
typescript-bot
pushed a commit
to typescript-bot/TypeScript
that referenced
this pull request
Feb 18, 2022
DanielRosenwasser
pushed a commit
that referenced
this pull request
Feb 19, 2022
Component commits: aa1c25d Remove unnecessary check in getNarrowableTypeForReference f4dcf88 Add regression test Co-authored-by: Anders Hejlsberg <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #47890.