🤖 Pick PR #47738 (Eliminate redundant or meaningless ...) into release-4.6#47907
Conversation
Component commits: 628da10 Eliminate redundant or meaningless elaborations in type relations a009ee1 Accept new baselines a65794c Add resetErrorInfo (though, oddly, shouldn't be necessary) f269f42 Less aggressive reduction in second pass union/intersection checks 1312e8a Accept new baselines b82966f Restructure and back off a little bit more f0b8742 Only cache union/intersection relations once 9404e06 Accept new baselines 4866ce5 Properly cache identity relations, clean up error reporting 2670b26 Move more logic to cached side of relation checks adb37a5 Optimize and remove more redundant elaborations 16b986b Accept new baselines 1c69acb Remove unnecessary error state capture 530c876 More optimizing 25a71c4 Cache isWeakType computation c427a46 Revert "Cache isWeakType computation" This reverts commit 25a71c4. 1d70b01 Address CR feedback 28439f7 Merge branch 'main' into fix47668 # Conflicts: # src/compiler/diagnosticMessages.json c472ba5 Accept new baselines
typescript-bot
added
the
For Uncommitted Bug
|
@DanielRosenwasser 👍 / 👎 ? |
|
To save anyone exploring some time, the intent is to fix #46900, and the picked PR is supposed to fix that issue according to the comment at #47897 (comment)
Ordinarily we would hold off on bringing this change in so late, but the refactoring generally seemed cleaner, safer, and apparently seems to fix the problem. |
4 participants
This cherry-pick was triggered by a request on #47738
Please review the diff and merge if no changes are unexpected.
You can view the cherry-pick log here.
cc @RyanCavanaugh