Fix for crash in navbar with double ambient modules#47395
Merged
DanielRosenwasser merged 2 commits intomainfrom Jan 12, 2022
Merged
Fix for crash in navbar with double ambient modules#47395DanielRosenwasser merged 2 commits intomainfrom
DanielRosenwasser merged 2 commits intomainfrom
Conversation
DanielRosenwasser
requested review from
RyanCavanaugh,
gabritto and
jakebailey
typescript-bot
added
Author: Team
For Milestone Bug
jakebailey
approved these changes
Jan 12, 2022
Member
Author
|
@typescript-bot cherry-pick this to release-4.5 |
Collaborator
|
Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into |
Collaborator
|
Hey @DanielRosenwasser, I've opened #47421 for you. |
typescript-bot
pushed a commit
to typescript-bot/TypeScript
that referenced
this pull request
Jan 13, 2022
DanielRosenwasser
added a commit
that referenced
this pull request
Jan 13, 2022
Component commits: f230a5a Add failing test. 3ba8469 Guard against undefined module bodies in navbar/navtree. Co-authored-by: Daniel Rosenwasser <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #47394.
Fixes #38058.