Fix checker initialization crash with esModuleInterop and global merges resolving to ImportEquals aliases#47348
Merged
andrewbranch merged 2 commits intomicrosoft:mainfrom Jan 11, 2022
Merged
Conversation
…esolving to ImportEquals aliases
typescript-bot
added
Author: Team
For Uncommitted Bug
DanielRosenwasser
approved these changes
Jan 7, 2022
Member
DanielRosenwasser
left a comment
DanielRosenwasser
left a comment
There was a problem hiding this comment.
This is an appropriate change. Thank you for finding the repro!
Longer-term, I would like to think through something that makes us resilient to the sort of ordering sensitivity we experienced here. Maybe the test case is enough for now, but ideally we would have a way to enforce discipline to avoid pulling on types before symbol merging has finished. Maybe @ahejlsberg has thoughts on this.
Member
|
@typescript-bot cherry-pick this to release-4.5 |
Collaborator
|
Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into |
Collaborator
|
Hey @DanielRosenwasser, I've opened #47349 for you. |
typescript-bot
pushed a commit
to typescript-bot/TypeScript
that referenced
this pull request
Jan 7, 2022
sandersn
approved these changes
Jan 11, 2022
This was referenced Jan 11, 2022
Closed
DanielRosenwasser
pushed a commit
that referenced
this pull request
Jan 12, 2022
Component commits: 755e1cb Add minimal failing test d52b9d3 Fix checker initialization crash with esModuleInterop global merges resolving to ImportEquals aliases Co-authored-by: Andrew Branch <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #47299