Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit class fields as-is with target: es2022 #47018

Merged
merged 2 commits into from
Dec 16, 2021
Merged

Emit class fields as-is with target: es2022 #47018

merged 2 commits into from
Dec 16, 2021

Conversation

saschanaz
Copy link
Contributor

Fixes #47017

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Dec 4, 2021
@saschanaz saschanaz mentioned this pull request Dec 13, 2021
Merged
@sandersn sandersn merged commit 20e86da into microsoft:main Dec 16, 2021
@saschanaz saschanaz deleted the class-field-es2022 branch December 16, 2021 23:22
@a-tarasyuk
Copy link
Contributor

a-tarasyuk commented Dec 17, 2021 •
edited
Loading

It seems this PR breaks the build. Not sure, maybe need to update the baseline.

@sandersn
Copy link
Member

Yep, it's because of the other recent PR that de-dupes private field errors. I'll update the baselines and send a PR.

@a-tarasyuk
Copy link
Contributor

@sandersn I can make PR, with updated baselines.

@sandersn
Copy link
Member

Don't worry, I've got it.

sandersn added a commit that referenced this pull request Dec 17, 2021
@sandersn
Fix baselines from bad merge
6d9c12e 
Conflict between #47018 and #46824, both of which changed the behaviour of private fields.
@a-tarasyuk
Copy link
Contributor

Oke, thanks.

@sandersn sandersn mentioned this pull request Dec 17, 2021
Merged
sandersn added a commit that referenced this pull request Dec 17, 2021
@sandersn
Fix baselines from bad merge (#47177)
8a5d476 
Conflict between #47018 and #46824, both of which changed the behaviour of private fields.
mprobst pushed a commit to mprobst/TypeScript that referenced this pull request Jan 10, 2022
@saschanaz @mprobst
Emit class fields as-is with target: es2022 (microsoft#47018)
9ee41ae 
* Emit class fields as-is with `target: es2022`

Closes microsoft#47017

* wave 2
mprobst pushed a commit to mprobst/TypeScript that referenced this pull request Jan 10, 2022
@sandersn @mprobst
Fix baselines from bad merge (microsoft#47177)
8e831d8 
Conflict between microsoft#47018 and microsoft#46824, both of which changed the behaviour of private fields.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandersn sandersn sandersn approved these changes

Assignees
No one assigned
Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Emit class fields as-is with target: es2022
4 participants
@saschanaz @a-tarasyuk @sandersn @typescript-bot