Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate SourceMap mappings string using array of character codes and fewer String.fromCharCode calls #44031

Merged
merged 3 commits into from
May 18, 2021
Merged

Generate SourceMap mappings string using array of character codes and fewer String.fromCharCode calls #44031

merged 3 commits into from
May 18, 2021

Conversation

dmichon-msft
Copy link
Contributor

@dmichon-msft dmichon-msft commented May 10, 2021 •
edited
Loading

This is an alternate approach to #43987 that works in ES5, for perf comparison.

Ultimately where this is saving CPU cycles is in avoiding native hops for instantiating new strings, and in allocating fewer "cons string" objects from the concatenations.

Fixes #43999

@typescript-bot typescript-bot added the For Milestone Bug PRs that fix a bug with a specific milestone label May 10, 2021
@dmichon-msft
Copy link
Contributor Author

@typescript-bot perf test this

DanielRosenwasser
DanielRosenwasser reviewed May 10, 2021
View reviewed changes
@dmichon-msft
Copy link
Contributor Author

@typescript-bot perf test this

1 similar comment
@DanielRosenwasser
Copy link
Member

@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented May 10, 2021 •
edited
Loading

Heya @DanielRosenwasser, I've started to run the perf test suite on this PR at 34a0217. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

@DanielRosenwasser
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..44031

Metric master 44031 Delta Best Worst
Angular - node (v10.16.3, x64)
Memory used 344,737k (± 0.02%) 344,685k (± 0.02%) -52k (- 0.01%) 344,533k 344,784k
Parse Time 1.93s (± 0.39%) 1.92s (± 0.58%) -0.01s (- 0.62%) 1.89s 1.94s
Bind Time 0.84s (± 0.44%) 0.84s (± 0.66%) -0.01s (- 0.83%) 0.83s 0.85s
Check Time 5.26s (± 0.51%) 5.25s (± 0.52%) -0.01s (- 0.15%) 5.21s 5.34s
Emit Time 5.60s (± 0.49%) 5.54s (± 1.35%) -0.06s (- 1.09%) 5.48s 5.83s
Total Time 13.63s (± 0.33%) 13.54s (± 0.77%) -0.09s (- 0.66%) 13.44s 13.94s
Compiler-Unions - node (v10.16.3, x64)
Memory used 200,315k (± 0.05%) 200,311k (± 0.03%) -4k (- 0.00%) 200,152k 200,463k
Parse Time 0.79s (± 1.01%) 0.79s (± 0.71%) -0.00s (- 0.51%) 0.78s 0.80s
Bind Time 0.53s (± 1.87%) 0.53s (± 0.89%) -0.00s (- 0.56%) 0.52s 0.54s
Check Time 7.63s (± 0.53%) 7.52s (± 0.46%) -0.12s (- 1.53%) 7.43s 7.57s
Emit Time 2.47s (± 0.87%) 2.27s (± 0.51%) 🟩-0.20s (- 8.01%) 2.24s 2.29s
Total Time 11.43s (± 0.42%) 11.10s (± 0.35%) -0.33s (- 2.86%) 10.98s 11.17s
Monaco - node (v10.16.3, x64)
Memory used 341,714k (± 0.02%) 341,688k (± 0.02%) -26k (- 0.01%) 341,559k 341,804k
Parse Time 1.57s (± 0.88%) 1.55s (± 0.57%) -0.01s (- 0.83%) 1.53s 1.57s
Bind Time 0.74s (± 0.75%) 0.74s (± 0.70%) -0.00s (- 0.13%) 0.73s 0.76s
Check Time 5.41s (± 0.51%) 5.38s (± 0.59%) -0.03s (- 0.57%) 5.31s 5.45s
Emit Time 2.98s (± 1.12%) 2.97s (± 0.65%) -0.02s (- 0.50%) 2.94s 3.03s
Total Time 10.70s (± 0.43%) 10.64s (± 0.44%) -0.06s (- 0.55%) 10.55s 10.79s
TFS - node (v10.16.3, x64)
Memory used 304,233k (± 0.02%) 304,242k (± 0.02%) +9k (+ 0.00%) 304,084k 304,355k
Parse Time 1.22s (± 0.67%) 1.21s (± 0.58%) -0.01s (- 0.49%) 1.19s 1.22s
Bind Time 0.70s (± 0.71%) 0.71s (± 0.67%) +0.00s (+ 0.28%) 0.70s 0.72s
Check Time 4.80s (± 0.58%) 4.81s (± 0.47%) +0.01s (+ 0.23%) 4.77s 4.86s
Emit Time 3.13s (± 0.96%) 3.15s (± 1.72%) +0.03s (+ 0.83%) 3.00s 3.29s
Total Time 9.85s (± 0.47%) 9.88s (± 0.67%) +0.03s (+ 0.27%) 9.73s 10.07s
material-ui - node (v10.16.3, x64)
Memory used 473,753k (± 0.01%) 473,818k (± 0.01%) +64k (+ 0.01%) 473,689k 473,933k
Parse Time 1.96s (± 0.67%) 1.94s (± 0.69%) -0.02s (- 1.07%) 1.91s 1.97s
Bind Time 0.66s (± 0.91%) 0.65s (± 1.02%) -0.00s (- 0.46%) 0.64s 0.67s
Check Time 14.85s (± 0.62%) 14.77s (± 0.43%) -0.08s (- 0.55%) 14.62s 14.91s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 17.47s (± 0.59%) 17.37s (± 0.34%) -0.10s (- 0.59%) 17.24s 17.52s
Angular - node (v12.1.0, x64)
Memory used 322,362k (± 0.04%) 322,248k (± 0.03%) -114k (- 0.04%) 322,060k 322,465k
Parse Time 1.91s (± 0.58%) 1.90s (± 0.71%) -0.01s (- 0.42%) 1.87s 1.93s
Bind Time 0.83s (± 0.85%) 0.82s (± 0.70%) -0.01s (- 0.72%) 0.81s 0.83s
Check Time 5.16s (± 0.47%) 5.15s (± 0.27%) -0.01s (- 0.21%) 5.12s 5.18s
Emit Time 5.82s (± 0.68%) 5.71s (± 0.60%) -0.10s (- 1.77%) 5.64s 5.79s
Total Time 13.71s (± 0.35%) 13.58s (± 0.40%) -0.13s (- 0.94%) 13.44s 13.67s
Compiler-Unions - node (v12.1.0, x64)
Memory used 187,395k (± 0.14%) 187,470k (± 0.12%) +75k (+ 0.04%) 187,095k 187,869k
Parse Time 0.78s (± 0.79%) 0.77s (± 0.61%) -0.01s (- 1.41%) 0.76s 0.78s
Bind Time 0.53s (± 1.25%) 0.53s (± 0.65%) -0.01s (- 1.13%) 0.52s 0.53s
Check Time 7.07s (± 0.83%) 7.03s (± 0.62%) -0.04s (- 0.59%) 6.97s 7.15s
Emit Time 2.47s (± 2.08%) 2.27s (± 1.21%) 🟩-0.19s (- 7.86%) 2.24s 2.37s
Total Time 10.85s (± 0.72%) 10.61s (± 0.58%) -0.25s (- 2.27%) 10.51s 10.78s
Monaco - node (v12.1.0, x64)
Memory used 324,020k (± 0.02%) 324,077k (± 0.01%) +56k (+ 0.02%) 324,016k 324,185k
Parse Time 1.56s (± 0.44%) 1.54s (± 0.62%) -0.01s (- 0.71%) 1.53s 1.57s
Bind Time 0.72s (± 0.66%) 0.72s (± 0.62%) +0.01s (+ 0.70%) 0.71s 0.73s
Check Time 5.21s (± 0.41%) 5.21s (± 0.65%) +0.00s (+ 0.04%) 5.16s 5.30s
Emit Time 3.03s (± 0.44%) 3.01s (± 0.48%) -0.02s (- 0.73%) 2.98s 3.04s
Total Time 10.52s (± 0.18%) 10.49s (± 0.43%) -0.03s (- 0.26%) 10.41s 10.60s
TFS - node (v12.1.0, x64)
Memory used 288,749k (± 0.03%) 288,716k (± 0.02%) -33k (- 0.01%) 288,542k 288,824k
Parse Time 1.22s (± 0.84%) 1.21s (± 0.48%) -0.01s (- 0.49%) 1.20s 1.23s
Bind Time 0.69s (± 0.80%) 0.69s (± 0.84%) +0.00s (+ 0.14%) 0.68s 0.71s
Check Time 4.71s (± 0.58%) 4.69s (± 0.32%) -0.02s (- 0.38%) 4.67s 4.73s
Emit Time 3.12s (± 1.21%) 3.12s (± 0.38%) +0.00s (+ 0.16%) 3.11s 3.16s
Total Time 9.74s (± 0.52%) 9.72s (± 0.29%) -0.02s (- 0.20%) 9.68s 9.80s
material-ui - node (v12.1.0, x64)
Memory used 451,578k (± 0.06%) 451,752k (± 0.02%) +174k (+ 0.04%) 451,604k 451,922k
Parse Time 1.95s (± 0.46%) 1.95s (± 0.68%) -0.01s (- 0.36%) 1.93s 1.98s
Bind Time 0.65s (± 0.58%) 0.64s (± 0.63%) -0.01s (- 0.93%) 0.63s 0.65s
Check Time 13.49s (± 0.88%) 13.30s (± 0.80%) -0.19s (- 1.45%) 13.15s 13.61s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 16.09s (± 0.76%) 15.88s (± 0.68%) -0.21s (- 1.31%) 15.71s 16.18s
Angular - node (v14.15.1, x64)
Memory used 321,014k (± 0.00%) 320,878k (± 0.09%) -136k (- 0.04%) 319,768k 321,062k
Parse Time 1.92s (± 0.39%) 1.90s (± 0.63%) -0.02s (- 0.89%) 1.87s 1.93s
Bind Time 0.87s (± 0.54%) 0.87s (± 0.57%) -0.01s (- 0.80%) 0.86s 0.88s
Check Time 5.18s (± 0.49%) 5.16s (± 0.77%) -0.02s (- 0.31%) 5.10s 5.30s
Emit Time 5.86s (± 0.43%) 5.83s (± 1.46%) -0.03s (- 0.44%) 5.72s 6.07s
Total Time 13.83s (± 0.37%) 13.76s (± 0.84%) -0.07s (- 0.48%) 13.60s 14.09s
Compiler-Unions - node (v14.15.1, x64)
Memory used 188,025k (± 0.63%) 187,390k (± 0.58%) -635k (- 0.34%) 186,383k 189,684k
Parse Time 0.81s (± 0.72%) 0.80s (± 0.61%) -0.00s (- 0.37%) 0.79s 0.81s
Bind Time 0.56s (± 0.71%) 0.56s (± 0.53%) -0.00s (- 0.53%) 0.55s 0.56s
Check Time 7.18s (± 0.68%) 7.14s (± 0.44%) -0.04s (- 0.61%) 7.08s 7.22s
Emit Time 2.46s (± 1.26%) 2.25s (± 0.71%) 🟩-0.21s (- 8.49%) 2.22s 2.30s
Total Time 11.01s (± 0.57%) 10.75s (± 0.42%) -0.26s (- 2.35%) 10.67s 10.86s
Monaco - node (v14.15.1, x64)
Memory used 323,137k (± 0.00%) 323,131k (± 0.00%) -6k (- 0.00%) 323,103k 323,163k
Parse Time 1.58s (± 0.69%) 1.57s (± 0.60%) -0.01s (- 0.95%) 1.55s 1.59s
Bind Time 0.75s (± 0.53%) 0.75s (± 1.12%) +0.00s (+ 0.27%) 0.74s 0.77s
Check Time 5.21s (± 0.65%) 5.19s (± 0.40%) -0.02s (- 0.38%) 5.13s 5.23s
Emit Time 3.09s (± 0.86%) 3.10s (± 0.36%) +0.01s (+ 0.26%) 3.07s 3.11s
Total Time 10.63s (± 0.56%) 10.61s (± 0.28%) -0.02s (- 0.24%) 10.53s 10.67s
TFS - node (v14.15.1, x64)
Memory used 287,667k (± 0.00%) 287,659k (± 0.01%) -8k (- 0.00%) 287,594k 287,737k
Parse Time 1.27s (± 1.17%) 1.26s (± 1.02%) -0.00s (- 0.39%) 1.23s 1.29s
Bind Time 0.72s (± 0.72%) 0.72s (± 0.47%) -0.00s (- 0.28%) 0.71s 0.72s
Check Time 4.74s (± 0.49%) 4.74s (± 0.50%) -0.01s (- 0.13%) 4.69s 4.79s
Emit Time 3.24s (± 1.21%) 3.22s (± 0.78%) -0.02s (- 0.62%) 3.17s 3.29s
Total Time 9.97s (± 0.55%) 9.94s (± 0.37%) -0.03s (- 0.33%) 9.88s 10.02s
material-ui - node (v14.15.1, x64)
Memory used 449,982k (± 0.01%) 449,902k (± 0.07%) -81k (- 0.02%) 448,606k 450,092k
Parse Time 2.00s (± 0.69%) 1.99s (± 0.75%) -0.02s (- 0.95%) 1.96s 2.02s
Bind Time 0.70s (± 0.74%) 0.70s (± 0.64%) -0.00s (- 0.14%) 0.69s 0.71s
Check Time 13.62s (± 1.03%) 13.52s (± 1.26%) -0.10s (- 0.73%) 13.35s 14.18s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 16.33s (± 0.84%) 16.21s (± 1.01%) -0.12s (- 0.72%) 16.07s 16.85s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-206-generic
Architecturex64
Available Memory16 GB
Available Memory6 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v10.16.3, x64)
  • Compiler-Unions - node (v12.1.0, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v10.16.3, x64)
  • material-ui - node (v12.1.0, x64)
  • material-ui - node (v14.15.1, x64)
Benchmark Name Iterations
Current 44031 10
Baseline master 10

Developer Information:

Download Benchmark

@DanielRosenwasser
Copy link
Member

Not bad!

@dmichon-msft
Copy link
Contributor Author

I admit I didn't expect it to be almost exactly the same perf as the Uint8Array approach

@DanielRosenwasser
Copy link
Member

DanielRosenwasser commented May 10, 2021 •
edited
Loading

Yeah, I am very surprised and I don't know how to make sense of this. I think you can take this out of draft state if you're interested.

Just as a heads up, your commits don't seem to be associated with your GitHub account. While this isn't technically a problem, you might care if you want more appropriate attribution. You can either make sure your GitHub account is associated with the email address that you're using for your commits, or rebase and amend your commits to fix the author name and email.

@DanielRosenwasser
Copy link
Member

@dmichon-msft how did you figure this out?

amcasey
amcasey reviewed May 10, 2021
View reviewed changes
@DanielRosenwasser
Copy link
Member

@typescript-bot perf test this.

@typescript-bot
Copy link
Collaborator

typescript-bot commented May 10, 2021 •
edited
Loading

Heya @DanielRosenwasser, I've started to run the perf test suite on this PR at ce3e87d. You can monitor the build here.

Update: The results are in!

@DanielRosenwasser
Copy link
Member

DanielRosenwasser commented May 10, 2021 •
edited
Loading

As of 34a0217, here's what I got on

node --max-old-space-size=4096 --require ../heap.js built/local/tsc.js -p ./src/compiler --outFile rofl/lol.js

Type: space
Time: May 10, 2021 at 11:54pm (UTC)
Showing nodes accounting for 458.07MB, 87.19% of 525.36MB total
Dropped 508 nodes (cum <= 2.63MB)
      flat  flat%   sum%        cum   cum%
   58.09MB 11.06% 11.06%    58.09MB 11.06%  appendBase64VLQ
   38.07MB  7.25% 18.30%    96.16MB 18.30%  addMapping
      37MB  7.04% 25.35%       37MB  7.04%  createBaseNode
      35MB  6.66% 32.01%       35MB  6.66%  write
   28.50MB  5.43% 37.44%    30.51MB  5.81%  createIdentifier
   24.45MB  4.65% 42.09%    24.45MB  4.65%  slice
   15.50MB  2.95% 45.04%       17MB  3.24%  createNodeArray
   13.90MB  2.65% 47.69%    13.90MB  2.65%  set
   13.50MB  2.57% 50.26%    14.01MB  2.67%  Map

I'll try with ce3e87d.

Update: still pretty similar:

Type: space
Time: May 11, 2021 at 12:02am (UTC)
Showing nodes accounting for 447.24MB, 87.14% of 513.26MB total
Dropped 503 nodes (cum <= 2.57MB)
      flat  flat%   sum%        cum   cum%
   58.09MB 11.32% 11.32%    58.09MB 11.32%  appendBase64VLQ
   39.50MB  7.70% 19.01%    39.50MB  7.70%  createBaseNode
   38.07MB  7.42% 26.43%    96.16MB 18.74%  addMapping
   30.01MB  5.85% 32.28%    33.02MB  6.43%  createIdentifier
   27.49MB  5.36% 37.63%    27.49MB  5.36%  slice
   26.50MB  5.16% 42.80%    26.50MB  5.16%  write
   17.50MB  3.41% 46.21%    18.01MB  3.51%  Map
   15.54MB  3.03% 49.24%    15.54MB  3.03%  set
   13.50MB  2.63% 51.87%    13.50MB  2.63%  createNodeArray

@dmichon-msft
Copy link
Contributor Author

Looks like I'd screwed up my local git config due to some script testing a while back. Fixed.

@typescript-bot
Copy link
Collaborator

@DanielRosenwasser
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..44031

Metric master 44031 Delta Best Worst
Angular - node (v10.16.3, x64)
Memory used 344,737k (± 0.02%) 344,667k (± 0.02%) -70k (- 0.02%) 344,568k 344,886k
Parse Time 1.93s (± 0.39%) 1.91s (± 0.35%) -0.02s (- 1.04%) 1.89s 1.92s
Bind Time 0.84s (± 0.44%) 0.84s (± 0.48%) -0.00s (- 0.47%) 0.83s 0.85s
Check Time 5.26s (± 0.51%) 5.25s (± 0.48%) -0.01s (- 0.15%) 5.19s 5.32s
Emit Time 5.60s (± 0.49%) 5.52s (± 0.51%) -0.07s (- 1.30%) 5.47s 5.58s
Total Time 13.63s (± 0.33%) 13.52s (± 0.40%) -0.11s (- 0.78%) 13.40s 13.64s
Compiler-Unions - node (v10.16.3, x64)
Memory used 200,315k (± 0.05%) 200,233k (± 0.05%) -81k (- 0.04%) 199,866k 200,378k
Parse Time 0.79s (± 1.01%) 0.79s (± 0.89%) -0.00s (- 0.38%) 0.78s 0.81s
Bind Time 0.53s (± 1.87%) 0.52s (± 1.82%) -0.01s (- 1.69%) 0.50s 0.54s
Check Time 7.63s (± 0.53%) 7.57s (± 0.74%) -0.06s (- 0.76%) 7.50s 7.75s
Emit Time 2.47s (± 0.87%) 2.29s (± 0.81%) 🟩-0.18s (- 7.45%) 2.26s 2.34s
Total Time 11.43s (± 0.42%) 11.17s (± 0.66%) -0.26s (- 2.27%) 11.06s 11.41s
Monaco - node (v10.16.3, x64)
Memory used 341,714k (± 0.02%) 341,691k (± 0.02%) -23k (- 0.01%) 341,575k 341,862k
Parse Time 1.57s (± 0.88%) 1.55s (± 0.38%) -0.01s (- 0.83%) 1.54s 1.57s
Bind Time 0.74s (± 0.75%) 0.74s (± 1.11%) +0.00s (+ 0.27%) 0.73s 0.76s
Check Time 5.41s (± 0.51%) 5.37s (± 0.42%) -0.05s (- 0.85%) 5.31s 5.42s
Emit Time 2.98s (± 1.12%) 2.97s (± 0.56%) -0.01s (- 0.20%) 2.95s 3.02s
Total Time 10.70s (± 0.43%) 10.64s (± 0.32%) -0.06s (- 0.58%) 10.55s 10.74s
TFS - node (v10.16.3, x64)
Memory used 304,233k (± 0.02%) 304,217k (± 0.02%) -15k (- 0.01%) 304,081k 304,321k
Parse Time 1.22s (± 0.67%) 1.21s (± 0.55%) -0.01s (- 0.58%) 1.20s 1.22s
Bind Time 0.70s (± 0.71%) 0.71s (± 0.70%) +0.00s (+ 0.14%) 0.70s 0.72s
Check Time 4.80s (± 0.58%) 4.79s (± 0.55%) -0.01s (- 0.27%) 4.73s 4.84s
Emit Time 3.13s (± 0.96%) 3.15s (± 1.90%) +0.02s (+ 0.74%) 3.00s 3.28s
Total Time 9.85s (± 0.47%) 9.85s (± 0.66%) +0.00s (+ 0.01%) 9.70s 10.03s
material-ui - node (v10.16.3, x64)
Memory used 473,753k (± 0.01%) 473,812k (± 0.02%) +59k (+ 0.01%) 473,623k 473,986k
Parse Time 1.96s (± 0.67%) 1.95s (± 0.95%) -0.01s (- 0.61%) 1.92s 2.00s
Bind Time 0.66s (± 0.91%) 0.65s (± 0.89%) -0.01s (- 0.91%) 0.64s 0.66s
Check Time 14.85s (± 0.62%) 14.79s (± 0.89%) -0.06s (- 0.42%) 14.58s 15.10s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 17.47s (± 0.59%) 17.39s (± 0.86%) -0.08s (- 0.48%) 17.16s 17.73s
Angular - node (v12.1.0, x64)
Memory used 322,362k (± 0.04%) 322,231k (± 0.08%) -131k (- 0.04%) 321,207k 322,542k
Parse Time 1.91s (± 0.58%) 1.89s (± 0.39%) -0.02s (- 0.89%) 1.87s 1.90s
Bind Time 0.83s (± 0.85%) 0.82s (± 0.44%) -0.00s (- 0.60%) 0.82s 0.83s
Check Time 5.16s (± 0.47%) 5.15s (± 0.68%) -0.01s (- 0.19%) 5.09s 5.25s
Emit Time 5.82s (± 0.68%) 5.72s (± 0.68%) -0.10s (- 1.67%) 5.64s 5.81s
Total Time 13.71s (± 0.35%) 13.58s (± 0.47%) -0.13s (- 0.93%) 13.47s 13.76s
Compiler-Unions - node (v12.1.0, x64)
Memory used 187,395k (± 0.14%) 187,302k (± 0.16%) -94k (- 0.05%) 186,691k 187,822k
Parse Time 0.78s (± 0.79%) 0.77s (± 0.98%) -0.01s (- 0.90%) 0.76s 0.79s
Bind Time 0.53s (± 1.25%) 0.53s (± 1.05%) -0.01s (- 0.94%) 0.52s 0.54s
Check Time 7.07s (± 0.83%) 7.01s (± 0.89%) -0.06s (- 0.90%) 6.93s 7.17s
Emit Time 2.47s (± 2.08%) 2.29s (± 0.93%) 🟩-0.18s (- 7.29%) 2.24s 2.33s
Total Time 10.85s (± 0.72%) 10.60s (± 0.69%) -0.25s (- 2.34%) 10.49s 10.78s
Monaco - node (v12.1.0, x64)
Memory used 324,020k (± 0.02%) 324,029k (± 0.02%) +9k (+ 0.00%) 323,914k 324,158k
Parse Time 1.56s (± 0.44%) 1.54s (± 0.36%) -0.02s (- 1.09%) 1.53s 1.55s
Bind Time 0.72s (± 0.66%) 0.72s (± 0.81%) 0.00s ( 0.00%) 0.71s 0.73s
Check Time 5.21s (± 0.41%) 5.19s (± 0.47%) -0.02s (- 0.44%) 5.14s 5.25s
Emit Time 3.03s (± 0.44%) 3.02s (± 0.65%) -0.01s (- 0.43%) 2.99s 3.08s
Total Time 10.52s (± 0.18%) 10.46s (± 0.29%) -0.05s (- 0.49%) 10.40s 10.55s
TFS - node (v12.1.0, x64)
Memory used 288,749k (± 0.03%) 288,680k (± 0.02%) -70k (- 0.02%) 288,543k 288,796k
Parse Time 1.22s (± 0.84%) 1.22s (± 1.14%) -0.00s (- 0.33%) 1.18s 1.24s
Bind Time 0.69s (± 0.80%) 0.69s (± 0.86%) +0.00s (+ 0.29%) 0.68s 0.71s
Check Time 4.71s (± 0.58%) 4.71s (± 0.30%) -0.01s (- 0.15%) 4.67s 4.73s
Emit Time 3.12s (± 1.21%) 3.13s (± 0.57%) +0.01s (+ 0.32%) 3.08s 3.17s
Total Time 9.74s (± 0.52%) 9.74s (± 0.30%) +0.00s (+ 0.01%) 9.67s 9.81s
material-ui - node (v12.1.0, x64)
Memory used 451,578k (± 0.06%) 451,736k (± 0.01%) +158k (+ 0.04%) 451,655k 451,830k
Parse Time 1.95s (± 0.46%) 1.95s (± 0.53%) -0.01s (- 0.31%) 1.93s 1.97s
Bind Time 0.65s (± 0.58%) 0.64s (± 0.97%) -0.01s (- 0.93%) 0.63s 0.65s
Check Time 13.49s (± 0.88%) 13.39s (± 1.25%) -0.10s (- 0.76%) 13.17s 13.99s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 16.09s (± 0.76%) 15.98s (± 1.09%) -0.12s (- 0.73%) 15.75s 16.60s
Angular - node (v14.15.1, x64)
Memory used 321,014k (± 0.00%) 321,008k (± 0.00%) -6k (- 0.00%) 320,969k 321,035k
Parse Time 1.92s (± 0.39%) 1.91s (± 0.52%) -0.01s (- 0.37%) 1.89s 1.93s
Bind Time 0.87s (± 0.54%) 0.87s (± 0.66%) -0.00s (- 0.34%) 0.86s 0.88s
Check Time 5.18s (± 0.49%) 5.14s (± 0.43%) -0.04s (- 0.71%) 5.11s 5.19s
Emit Time 5.86s (± 0.43%) 5.79s (± 1.30%) -0.06s (- 1.11%) 5.72s 6.07s
Total Time 13.83s (± 0.37%) 13.71s (± 0.58%) -0.12s (- 0.84%) 13.61s 13.96s
Compiler-Unions - node (v14.15.1, x64)
Memory used 188,025k (± 0.63%) 187,410k (± 0.59%) -615k (- 0.33%) 186,365k 189,680k
Parse Time 0.81s (± 0.72%) 0.80s (± 0.37%) -0.01s (- 0.62%) 0.80s 0.81s
Bind Time 0.56s (± 0.71%) 0.55s (± 0.90%) -0.01s (- 1.07%) 0.55s 0.57s
Check Time 7.18s (± 0.68%) 7.15s (± 0.63%) -0.03s (- 0.35%) 7.05s 7.26s
Emit Time 2.46s (± 1.26%) 2.26s (± 0.65%) 🟩-0.20s (- 8.29%) 2.24s 2.30s
Total Time 11.01s (± 0.57%) 10.77s (± 0.47%) -0.24s (- 2.16%) 10.65s 10.89s
Monaco - node (v14.15.1, x64)
Memory used 323,137k (± 0.00%) 323,122k (± 0.01%) -15k (- 0.00%) 323,084k 323,186k
Parse Time 1.58s (± 0.69%) 1.57s (± 0.49%) -0.01s (- 0.82%) 1.56s 1.59s
Bind Time 0.75s (± 0.53%) 0.74s (± 0.67%) -0.00s (- 0.53%) 0.74s 0.76s
Check Time 5.21s (± 0.65%) 5.18s (± 0.33%) -0.04s (- 0.67%) 5.14s 5.23s
Emit Time 3.09s (± 0.86%) 3.06s (± 0.42%) -0.02s (- 0.78%) 3.03s 3.09s
Total Time 10.63s (± 0.56%) 10.56s (± 0.23%) -0.07s (- 0.69%) 10.51s 10.64s
TFS - node (v14.15.1, x64)
Memory used 287,667k (± 0.00%) 287,647k (± 0.01%) -20k (- 0.01%) 287,577k 287,692k
Parse Time 1.27s (± 1.17%) 1.26s (± 1.11%) -0.01s (- 0.47%) 1.23s 1.29s
Bind Time 0.72s (± 0.72%) 0.71s (± 0.69%) -0.01s (- 0.70%) 0.71s 0.73s
Check Time 4.74s (± 0.49%) 4.72s (± 0.50%) -0.03s (- 0.55%) 4.66s 4.77s
Emit Time 3.24s (± 1.21%) 3.23s (± 0.97%) -0.02s (- 0.46%) 3.18s 3.34s
Total Time 9.97s (± 0.55%) 9.92s (± 0.48%) -0.05s (- 0.52%) 9.84s 10.09s
material-ui - node (v14.15.1, x64)
Memory used 449,982k (± 0.01%) 449,849k (± 0.06%) -133k (- 0.03%) 448,851k 450,079k
Parse Time 2.00s (± 0.69%) 1.98s (± 0.56%) -0.02s (- 1.05%) 1.96s 2.00s
Bind Time 0.70s (± 0.74%) 0.70s (± 0.32%) +0.00s (+ 0.00%) 0.69s 0.70s
Check Time 13.62s (± 1.03%) 13.60s (± 0.68%) -0.02s (- 0.15%) 13.43s 13.78s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 16.33s (± 0.84%) 16.29s (± 0.61%) -0.04s (- 0.25%) 16.12s 16.48s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-206-generic
Architecturex64
Available Memory16 GB
Available Memory6 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v10.16.3, x64)
  • Compiler-Unions - node (v12.1.0, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v10.16.3, x64)
  • material-ui - node (v12.1.0, x64)
  • material-ui - node (v14.15.1, x64)
Benchmark Name Iterations
Current 44031 10
Baseline master 10

Developer Information:

Download Benchmark

amcasey
amcasey reviewed May 11, 2021
View reviewed changes
@dmichon-msft
Copy link
Contributor Author

I'm pretty sure the overhead being saved by this PR and #43987 are both almost entirely in the repeated calls to String.fromCharCode during the base64 VLQ encoding, and am therefore not convinced that we'd save much if we tried the same approach for general text emit, but I'd be happy to be wrong. It's always bothered me that code generation is so much slower than AST parsing in JavaScript (the TypeScript compiler is not at all alone here; escodegen is slower than esprima, etc.).

@DanielRosenwasser
Copy link
Member

@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented May 11, 2021 •
edited
Loading

Heya @DanielRosenwasser, I've started to run the perf test suite on this PR at 228f3eb. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

@DanielRosenwasser
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..44031

Metric master 44031 Delta Best Worst
Angular - node (v10.16.3, x64)
Memory used 344,737k (± 0.02%) 344,718k (± 0.02%) -19k (- 0.01%) 344,551k 344,978k
Parse Time 1.93s (± 0.39%) 1.91s (± 0.31%) -0.01s (- 0.67%) 1.90s 1.93s
Bind Time 0.84s (± 0.44%) 0.84s (± 0.35%) -0.01s (- 0.83%) 0.83s 0.84s
Check Time 5.26s (± 0.51%) 5.24s (± 0.40%) -0.01s (- 0.25%) 5.20s 5.28s
Emit Time 5.60s (± 0.49%) 5.49s (± 0.76%) -0.11s (- 1.91%) 5.44s 5.64s
Total Time 13.63s (± 0.33%) 13.48s (± 0.41%) -0.14s (- 1.05%) 13.42s 13.66s
Compiler-Unions - node (v10.16.3, x64)
Memory used 200,315k (± 0.05%) 200,282k (± 0.04%) -33k (- 0.02%) 200,121k 200,462k
Parse Time 0.79s (± 1.01%) 0.78s (± 0.97%) -0.01s (- 0.88%) 0.77s 0.80s
Bind Time 0.53s (± 1.87%) 0.52s (± 1.18%) -0.01s (- 2.25%) 0.51s 0.54s
Check Time 7.63s (± 0.53%) 7.50s (± 0.67%) -0.13s (- 1.72%) 7.39s 7.61s
Emit Time 2.47s (± 0.87%) 2.27s (± 0.94%) 🟩-0.20s (- 8.09%) 2.23s 2.33s
Total Time 11.43s (± 0.42%) 11.07s (± 0.51%) 🟩-0.36s (- 3.11%) 10.91s 11.21s
Monaco - node (v10.16.3, x64)
Memory used 341,714k (± 0.02%) 341,640k (± 0.01%) -74k (- 0.02%) 341,533k 341,793k
Parse Time 1.57s (± 0.88%) 1.56s (± 0.30%) -0.01s (- 0.45%) 1.55s 1.57s
Bind Time 0.74s (± 0.75%) 0.74s (± 0.95%) -0.00s (- 0.13%) 0.73s 0.76s
Check Time 5.41s (± 0.51%) 5.36s (± 0.39%) -0.06s (- 1.03%) 5.29s 5.38s
Emit Time 2.98s (± 1.12%) 2.96s (± 0.40%) -0.02s (- 0.67%) 2.94s 2.99s
Total Time 10.70s (± 0.43%) 10.62s (± 0.25%) -0.08s (- 0.73%) 10.57s 10.69s
TFS - node (v10.16.3, x64)
Memory used 304,233k (± 0.02%) 304,230k (± 0.02%) -3k (- 0.00%) 304,045k 304,386k
Parse Time 1.22s (± 0.67%) 1.21s (± 0.37%) -0.01s (- 0.41%) 1.20s 1.22s
Bind Time 0.70s (± 0.71%) 0.71s (± 0.78%) +0.00s (+ 0.43%) 0.70s 0.72s
Check Time 4.80s (± 0.58%) 4.81s (± 0.50%) +0.01s (+ 0.15%) 4.76s 4.87s
Emit Time 3.13s (± 0.96%) 3.10s (± 1.23%) -0.03s (- 0.83%) 3.01s 3.17s
Total Time 9.85s (± 0.47%) 9.83s (± 0.57%) -0.02s (- 0.22%) 9.71s 9.96s
material-ui - node (v10.16.3, x64)
Memory used 473,753k (± 0.01%) 473,741k (± 0.01%) -12k (- 0.00%) 473,610k 473,907k
Parse Time 1.96s (± 0.67%) 1.94s (± 0.45%) -0.02s (- 1.22%) 1.92s 1.96s
Bind Time 0.66s (± 0.91%) 0.65s (± 1.03%) -0.01s (- 1.37%) 0.63s 0.66s
Check Time 14.85s (± 0.62%) 14.77s (± 0.45%) -0.08s (- 0.55%) 14.65s 14.94s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 17.47s (± 0.59%) 17.36s (± 0.41%) -0.12s (- 0.66%) 17.22s 17.51s
Angular - node (v12.1.0, x64)
Memory used 322,362k (± 0.04%) 322,283k (± 0.02%) -79k (- 0.02%) 322,083k 322,405k
Parse Time 1.91s (± 0.58%) 1.90s (± 0.50%) -0.00s (- 0.10%) 1.89s 1.93s
Bind Time 0.83s (± 0.85%) 0.82s (± 0.45%) -0.01s (- 1.57%) 0.81s 0.82s
Check Time 5.16s (± 0.47%) 5.13s (± 0.23%) -0.03s (- 0.62%) 5.10s 5.15s
Emit Time 5.82s (± 0.68%) 5.72s (± 0.83%) -0.10s (- 1.69%) 5.63s 5.87s
Total Time 13.71s (± 0.35%) 13.56s (± 0.36%) -0.15s (- 1.07%) 13.46s 13.72s
Compiler-Unions - node (v12.1.0, x64)
Memory used 187,395k (± 0.14%) 187,465k (± 0.13%) +70k (+ 0.04%) 186,717k 187,769k
Parse Time 0.78s (± 0.79%) 0.77s (± 0.61%) -0.01s (- 1.41%) 0.76s 0.78s
Bind Time 0.53s (± 1.25%) 0.53s (± 1.14%) -0.01s (- 1.50%) 0.51s 0.54s
Check Time 7.07s (± 0.83%) 7.02s (± 0.50%) -0.05s (- 0.78%) 6.94s 7.09s
Emit Time 2.47s (± 2.08%) 2.25s (± 0.85%) 🟩-0.22s (- 8.91%) 2.19s 2.28s
Total Time 10.85s (± 0.72%) 10.56s (± 0.34%) -0.29s (- 2.67%) 10.50s 10.67s
Monaco - node (v12.1.0, x64)
Memory used 324,020k (± 0.02%) 323,895k (± 0.08%) -125k (- 0.04%) 323,143k 324,217k
Parse Time 1.56s (± 0.44%) 1.53s (± 0.74%) -0.02s (- 1.48%) 1.51s 1.56s
Bind Time 0.72s (± 0.66%) 0.71s (± 0.48%) -0.00s (- 0.56%) 0.71s 0.72s
Check Time 5.21s (± 0.41%) 5.19s (± 0.46%) -0.02s (- 0.38%) 5.16s 5.25s
Emit Time 3.03s (± 0.44%) 3.04s (± 1.05%) +0.01s (+ 0.33%) 2.99s 3.14s
Total Time 10.52s (± 0.18%) 10.48s (± 0.34%) -0.04s (- 0.37%) 10.41s 10.59s
TFS - node (v12.1.0, x64)
Memory used 288,749k (± 0.03%) 288,711k (± 0.04%) -38k (- 0.01%) 288,608k 289,102k
Parse Time 1.22s (± 0.84%) 1.21s (± 0.54%) -0.01s (- 0.90%) 1.20s 1.22s
Bind Time 0.69s (± 0.80%) 0.69s (± 0.00%) -0.00s (- 0.29%) 0.69s 0.69s
Check Time 4.71s (± 0.58%) 4.70s (± 0.43%) -0.01s (- 0.21%) 4.65s 4.73s
Emit Time 3.12s (± 1.21%) 3.08s (± 0.68%) -0.04s (- 1.19%) 3.05s 3.13s
Total Time 9.74s (± 0.52%) 9.68s (± 0.37%) -0.06s (- 0.62%) 9.60s 9.75s
material-ui - node (v12.1.0, x64)
Memory used 451,578k (± 0.06%) 451,759k (± 0.02%) +181k (+ 0.04%) 451,550k 451,995k
Parse Time 1.95s (± 0.46%) 1.94s (± 0.52%) -0.01s (- 0.51%) 1.92s 1.97s
Bind Time 0.65s (± 0.58%) 0.64s (± 0.57%) -0.01s (- 1.40%) 0.63s 0.64s
Check Time 13.49s (± 0.88%) 13.28s (± 0.41%) -0.21s (- 1.54%) 13.14s 13.40s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 16.09s (± 0.76%) 15.86s (± 0.36%) -0.23s (- 1.43%) 15.70s 15.97s
Angular - node (v14.15.1, x64)
Memory used 321,014k (± 0.00%) 321,016k (± 0.01%) +2k (+ 0.00%) 320,956k 321,049k
Parse Time 1.92s (± 0.39%) 1.91s (± 0.53%) -0.01s (- 0.63%) 1.89s 1.92s
Bind Time 0.87s (± 0.54%) 0.86s (± 0.55%) -0.01s (- 1.15%) 0.86s 0.88s
Check Time 5.18s (± 0.49%) 5.16s (± 0.48%) -0.02s (- 0.31%) 5.11s 5.21s
Emit Time 5.86s (± 0.43%) 5.76s (± 0.67%) -0.10s (- 1.66%) 5.68s 5.84s
Total Time 13.83s (± 0.37%) 13.69s (± 0.41%) -0.13s (- 0.96%) 13.59s 13.82s
Compiler-Unions - node (v14.15.1, x64)
Memory used 188,025k (± 0.63%) 188,038k (± 0.63%) +14k (+ 0.01%) 186,390k 189,658k
Parse Time 0.81s (± 0.72%) 0.80s (± 0.42%) -0.01s (- 0.87%) 0.79s 0.81s
Bind Time 0.56s (± 0.71%) 0.55s (± 0.66%) -0.01s (- 1.25%) 0.55s 0.56s
Check Time 7.18s (± 0.68%) 7.13s (± 0.43%) -0.05s (- 0.72%) 7.07s 7.22s
Emit Time 2.46s (± 1.26%) 2.26s (± 0.65%) 🟩-0.20s (- 8.29%) 2.23s 2.29s
Total Time 11.01s (± 0.57%) 10.74s (± 0.29%) -0.27s (- 2.45%) 10.69s 10.83s
Monaco - node (v14.15.1, x64)
Memory used 323,137k (± 0.00%) 323,125k (± 0.00%) -12k (- 0.00%) 323,090k 323,155k
Parse Time 1.58s (± 0.69%) 1.57s (± 0.38%) -0.02s (- 1.07%) 1.56s 1.58s
Bind Time 0.75s (± 0.53%) 0.75s (± 0.74%) -0.00s (- 0.13%) 0.74s 0.76s
Check Time 5.21s (± 0.65%) 5.17s (± 0.50%) -0.04s (- 0.75%) 5.12s 5.23s
Emit Time 3.09s (± 0.86%) 3.07s (± 0.63%) -0.02s (- 0.52%) 3.04s 3.11s
Total Time 10.63s (± 0.56%) 10.56s (± 0.35%) -0.07s (- 0.69%) 10.49s 10.63s
TFS - node (v14.15.1, x64)
Memory used 287,667k (± 0.00%) 287,636k (± 0.01%) -31k (- 0.01%) 287,587k 287,707k
Parse Time 1.27s (± 1.17%) 1.26s (± 1.00%) -0.01s (- 0.55%) 1.23s 1.29s
Bind Time 0.72s (± 0.72%) 0.71s (± 0.42%) -0.01s (- 0.97%) 0.71s 0.72s
Check Time 4.74s (± 0.49%) 4.71s (± 0.47%) -0.03s (- 0.63%) 4.67s 4.76s
Emit Time 3.24s (± 1.21%) 3.21s (± 0.50%) -0.03s (- 1.02%) 3.17s 3.25s
Total Time 9.97s (± 0.55%) 9.89s (± 0.39%) -0.08s (- 0.77%) 9.81s 10.01s
material-ui - node (v14.15.1, x64)
Memory used 449,982k (± 0.01%) 449,813k (± 0.06%) -170k (- 0.04%) 448,667k 450,058k
Parse Time 2.00s (± 0.69%) 1.98s (± 0.55%) -0.03s (- 1.35%) 1.96s 2.01s
Bind Time 0.70s (± 0.74%) 0.70s (± 0.52%) -0.00s (- 0.43%) 0.69s 0.70s
Check Time 13.62s (± 1.03%) 13.50s (± 0.84%) -0.12s (- 0.88%) 13.32s 13.92s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 16.33s (± 0.84%) 16.18s (± 0.70%) -0.15s (- 0.91%) 15.99s 16.59s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-206-generic
Architecturex64
Available Memory16 GB
Available Memory6 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v10.16.3, x64)
  • Compiler-Unions - node (v12.1.0, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v10.16.3, x64)
  • material-ui - node (v12.1.0, x64)
  • material-ui - node (v14.15.1, x64)
Benchmark Name Iterations
Current 44031 10
Baseline master 10

Developer Information:

Download Benchmark

@dmichon-msft dmichon-msft marked this pull request as ready for review May 11, 2021 02:48
DanielRosenwasser
DanielRosenwasser requested changes May 11, 2021
View reviewed changes
@dmichon-msft
Copy link
Contributor Author

A bit of poking in my microbenchmarks suggests that the majority of the time is now spent on the String.fromCharCode and append calls, so we probably stand to save quite a bit if we can keep the string UTF-8 encoded all the way through.

amcasey
amcasey approved these changes May 11, 2021
View reviewed changes
Copy link
Member

@amcasey amcasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My vote is for this clean, simple change over the Uint8Array and I think it's great as-is, but I'm open to poking around some more to see if there's something cheaper than fromCharCode.

This was referenced May 11, 2021
Closed
Closed
@DanielRosenwasser
Copy link
Member

@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented May 11, 2021 •
edited
Loading

Heya @DanielRosenwasser, I've started to run the perf test suite on this PR at 0d5b285. You can monitor the build here.

Update: The results are in!

@DanielRosenwasser
Copy link
Member

I trust it'll be fine but let's run one last one.

@typescript-bot
Copy link
Collaborator

@DanielRosenwasser
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..44031

Metric master 44031 Delta Best Worst
Angular - node (v10.16.3, x64)
Memory used 344,738k (± 0.01%) 344,683k (± 0.03%) -55k (- 0.02%) 344,516k 344,944k
Parse Time 1.91s (± 0.50%) 1.91s (± 0.43%) -0.00s (- 0.05%) 1.89s 1.93s
Bind Time 0.83s (± 0.70%) 0.84s (± 0.57%) +0.00s (+ 0.48%) 0.83s 0.85s
Check Time 5.23s (± 0.28%) 5.25s (± 0.54%) +0.02s (+ 0.40%) 5.17s 5.30s
Emit Time 5.57s (± 0.34%) 5.52s (± 0.51%) -0.05s (- 0.92%) 5.46s 5.57s
Total Time 13.55s (± 0.20%) 13.52s (± 0.39%) -0.03s (- 0.22%) 13.40s 13.63s
Compiler-Unions - node (v10.16.3, x64)
Memory used 200,233k (± 0.06%) 200,198k (± 0.04%) -36k (- 0.02%) 199,951k 200,368k
Parse Time 0.78s (± 0.71%) 0.78s (± 0.63%) +0.00s (+ 0.26%) 0.77s 0.79s
Bind Time 0.53s (± 1.09%) 0.52s (± 1.11%) -0.01s (- 1.32%) 0.51s 0.53s
Check Time 7.51s (± 0.37%) 7.53s (± 0.39%) +0.02s (+ 0.32%) 7.44s 7.60s
Emit Time 2.45s (± 0.78%) 2.23s (± 0.62%) 🟩-0.22s (- 8.83%) 2.21s 2.26s
Total Time 11.26s (± 0.27%) 11.06s (± 0.21%) -0.20s (- 1.75%) 11.02s 11.13s
Monaco - node (v10.16.3, x64)
Memory used 341,668k (± 0.03%) 341,671k (± 0.02%) +3k (+ 0.00%) 341,451k 341,810k
Parse Time 1.56s (± 0.43%) 1.55s (± 0.43%) -0.00s (- 0.26%) 1.53s 1.56s
Bind Time 0.74s (± 0.88%) 0.74s (± 0.80%) +0.01s (+ 0.81%) 0.73s 0.76s
Check Time 5.36s (± 0.21%) 5.37s (± 0.62%) +0.01s (+ 0.19%) 5.29s 5.44s
Emit Time 2.97s (± 0.61%) 2.96s (± 0.68%) -0.01s (- 0.37%) 2.91s 3.00s
Total Time 10.63s (± 0.19%) 10.63s (± 0.44%) -0.00s (- 0.02%) 10.50s 10.70s
TFS - node (v10.16.3, x64)
Memory used 304,195k (± 0.01%) 304,210k (± 0.02%) +16k (+ 0.01%) 304,048k 304,320k
Parse Time 1.21s (± 0.58%) 1.21s (± 0.48%) +0.00s (+ 0.08%) 1.20s 1.22s
Bind Time 0.71s (± 0.73%) 0.70s (± 0.48%) -0.01s (- 0.85%) 0.70s 0.71s
Check Time 4.81s (± 0.41%) 4.77s (± 0.39%) -0.04s (- 0.77%) 4.74s 4.84s
Emit Time 3.11s (± 1.80%) 3.15s (± 1.47%) +0.04s (+ 1.19%) 3.06s 3.25s
Total Time 9.84s (± 0.56%) 9.84s (± 0.60%) -0.00s (- 0.05%) 9.71s 9.95s
material-ui - node (v10.16.3, x64)
Memory used 473,839k (± 0.01%) 473,819k (± 0.01%) -20k (- 0.00%) 473,705k 473,928k
Parse Time 1.93s (± 0.68%) 1.93s (± 0.69%) -0.00s (- 0.10%) 1.91s 1.96s
Bind Time 0.65s (± 0.85%) 0.65s (± 0.91%) +0.00s (+ 0.31%) 0.64s 0.67s
Check Time 14.71s (± 0.44%) 14.77s (± 0.35%) +0.05s (+ 0.37%) 14.64s 14.86s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 17.30s (± 0.42%) 17.35s (± 0.33%) +0.05s (+ 0.32%) 17.23s 17.47s
Angular - node (v12.1.0, x64)
Memory used 322,370k (± 0.04%) 322,281k (± 0.02%) -89k (- 0.03%) 322,117k 322,456k
Parse Time 1.91s (± 0.76%) 1.91s (± 0.74%) +0.00s (+ 0.05%) 1.88s 1.94s
Bind Time 0.83s (± 1.59%) 0.82s (± 0.72%) -0.01s (- 0.96%) 0.81s 0.84s
Check Time 5.13s (± 0.39%) 5.15s (± 0.59%) +0.01s (+ 0.19%) 5.07s 5.24s
Emit Time 5.78s (± 0.44%) 5.76s (± 0.50%) -0.02s (- 0.36%) 5.70s 5.83s
Total Time 13.66s (± 0.34%) 13.64s (± 0.27%) -0.02s (- 0.12%) 13.55s 13.71s
Compiler-Unions - node (v12.1.0, x64)
Memory used 187,445k (± 0.20%) 187,555k (± 0.10%) +110k (+ 0.06%) 187,087k 187,865k
Parse Time 0.77s (± 0.68%) 0.77s (± 0.76%) -0.00s (- 0.26%) 0.76s 0.78s
Bind Time 0.53s (± 1.13%) 0.53s (± 0.76%) +0.00s (+ 0.57%) 0.52s 0.54s
Check Time 6.98s (± 0.45%) 6.96s (± 0.32%) -0.03s (- 0.40%) 6.88s 6.98s
Emit Time 2.44s (± 1.06%) 2.27s (± 0.73%) 🟩-0.17s (- 6.85%) 2.24s 2.31s
Total Time 10.72s (± 0.45%) 10.52s (± 0.26%) -0.20s (- 1.87%) 10.43s 10.56s
Monaco - node (v12.1.0, x64)
Memory used 324,050k (± 0.01%) 324,058k (± 0.02%) +8k (+ 0.00%) 323,837k 324,215k
Parse Time 1.54s (± 0.42%) 1.53s (± 0.87%) -0.00s (- 0.26%) 1.51s 1.57s
Bind Time 0.72s (± 0.62%) 0.72s (± 1.23%) +0.01s (+ 0.84%) 0.71s 0.74s
Check Time 5.21s (± 0.36%) 5.21s (± 0.34%) +0.00s (+ 0.06%) 5.18s 5.27s
Emit Time 3.02s (± 0.64%) 3.02s (± 0.83%) +0.00s (+ 0.03%) 2.98s 3.09s
Total Time 10.48s (± 0.25%) 10.48s (± 0.37%) +0.01s (+ 0.06%) 10.42s 10.61s
TFS - node (v12.1.0, x64)
Memory used 288,744k (± 0.02%) 288,709k (± 0.02%) -35k (- 0.01%) 288,584k 288,828k
Parse Time 1.21s (± 0.43%) 1.21s (± 0.78%) -0.00s (- 0.17%) 1.19s 1.23s
Bind Time 0.69s (± 0.72%) 0.69s (± 1.08%) -0.00s (- 0.29%) 0.68s 0.72s
Check Time 4.70s (± 0.45%) 4.70s (± 0.38%) 0.00s ( 0.00%) 4.65s 4.74s
Emit Time 3.12s (± 0.93%) 3.12s (± 1.11%) -0.00s (- 0.10%) 3.05s 3.18s
Total Time 9.72s (± 0.36%) 9.72s (± 0.41%) -0.00s (- 0.05%) 9.63s 9.81s
material-ui - node (v12.1.0, x64)
Memory used 451,510k (± 0.07%) 451,572k (± 0.07%) +62k (+ 0.01%) 450,326k 451,838k
Parse Time 1.94s (± 0.43%) 1.95s (± 0.56%) +0.01s (+ 0.46%) 1.93s 1.98s
Bind Time 0.64s (± 0.87%) 0.64s (± 0.73%) +0.00s (+ 0.31%) 0.63s 0.65s
Check Time 13.35s (± 0.53%) 13.32s (± 0.54%) -0.02s (- 0.18%) 13.19s 13.50s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.93s (± 0.41%) 15.91s (± 0.48%) -0.01s (- 0.09%) 15.76s 16.09s
Angular - node (v14.15.1, x64)
Memory used 321,018k (± 0.00%) 321,014k (± 0.01%) -4k (- 0.00%) 320,985k 321,062k
Parse Time 1.90s (± 0.70%) 1.90s (± 0.55%) +0.00s (+ 0.16%) 1.88s 1.93s
Bind Time 0.87s (± 0.46%) 0.87s (± 0.46%) +0.00s (+ 0.00%) 0.86s 0.88s
Check Time 5.13s (± 0.24%) 5.15s (± 0.48%) +0.02s (+ 0.37%) 5.09s 5.20s
Emit Time 5.81s (± 0.75%) 5.81s (± 0.56%) +0.00s (+ 0.02%) 5.73s 5.90s
Total Time 13.71s (± 0.35%) 13.73s (± 0.31%) +0.03s (+ 0.18%) 13.65s 13.81s
Compiler-Unions - node (v14.15.1, x64)
Memory used 187,720k (± 0.62%) 189,316k (± 0.38%) +1,595k (+ 0.85%) 186,448k 189,678k
Parse Time 0.80s (± 0.45%) 0.80s (± 0.72%) -0.00s (- 0.12%) 0.79s 0.82s
Bind Time 0.55s (± 0.67%) 0.55s (± 0.66%) -0.00s (- 0.18%) 0.55s 0.56s
Check Time 7.11s (± 0.42%) 7.15s (± 0.56%) +0.04s (+ 0.53%) 7.07s 7.23s
Emit Time 2.46s (± 0.80%) 2.26s (± 1.01%) 🟩-0.20s (- 8.06%) 2.23s 2.34s
Total Time 10.92s (± 0.34%) 10.77s (± 0.41%) -0.15s (- 1.41%) 10.67s 10.89s
Monaco - node (v14.15.1, x64)
Memory used 323,126k (± 0.01%) 323,138k (± 0.01%) +12k (+ 0.00%) 323,087k 323,190k
Parse Time 1.56s (± 0.59%) 1.56s (± 0.54%) -0.00s (- 0.19%) 1.55s 1.58s
Bind Time 0.75s (± 0.64%) 0.75s (± 0.50%) -0.00s (- 0.27%) 0.74s 0.75s
Check Time 5.17s (± 0.33%) 5.19s (± 0.44%) +0.02s (+ 0.39%) 5.14s 5.23s
Emit Time 3.07s (± 0.78%) 3.08s (± 0.59%) +0.02s (+ 0.55%) 3.03s 3.11s
Total Time 10.55s (± 0.36%) 10.58s (± 0.37%) +0.03s (+ 0.28%) 10.46s 10.66s
TFS - node (v14.15.1, x64)
Memory used 287,665k (± 0.01%) 287,646k (± 0.01%) -19k (- 0.01%) 287,607k 287,667k
Parse Time 1.27s (± 1.21%) 1.27s (± 0.78%) +0.00s (+ 0.16%) 1.25s 1.30s
Bind Time 0.72s (± 0.80%) 0.71s (± 0.63%) -0.01s (- 1.11%) 0.70s 0.72s
Check Time 4.73s (± 0.30%) 4.74s (± 0.69%) +0.02s (+ 0.34%) 4.67s 4.80s
Emit Time 3.21s (± 0.61%) 3.22s (± 1.28%) +0.01s (+ 0.44%) 3.15s 3.36s
Total Time 9.92s (± 0.27%) 9.94s (± 0.49%) +0.03s (+ 0.27%) 9.79s 10.04s
material-ui - node (v14.15.1, x64)
Memory used 449,978k (± 0.01%) 449,848k (± 0.06%) -129k (- 0.03%) 448,695k 450,099k
Parse Time 1.98s (± 0.69%) 1.98s (± 0.86%) +0.00s (+ 0.10%) 1.95s 2.02s
Bind Time 0.70s (± 0.49%) 0.70s (± 0.68%) 0.00s ( 0.00%) 0.69s 0.71s
Check Time 13.41s (± 0.32%) 13.52s (± 0.93%) +0.11s (+ 0.83%) 13.32s 13.78s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 16.09s (± 0.30%) 16.21s (± 0.83%) +0.12s (+ 0.73%) 16.01s 16.49s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-206-generic
Architecturex64
Available Memory16 GB
Available Memory6 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v10.16.3, x64)
  • Compiler-Unions - node (v12.1.0, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v10.16.3, x64)
  • material-ui - node (v12.1.0, x64)
  • material-ui - node (v14.15.1, x64)
Benchmark Name Iterations
Current 44031 10
Baseline master 10

Developer Information:

Download Benchmark

DanielRosenwasser
DanielRosenwasser approved these changes May 11, 2021
View reviewed changes
Copy link
Member

@DanielRosenwasser DanielRosenwasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'm more than happy to take a simpler implementation.

@DanielRosenwasser
Copy link
Member

@jhutchings1 any idea why CodeQL analysis is OOMing?

@DanielRosenwasser DanielRosenwasser mentioned this pull request May 11, 2021
Closed
3 tasks
@rbuckton
Copy link
Member

I'm not sure if it would affect performance or memory usage at all, but I did notice that you can use Uint8Array with the String.fromCharCode trick:

String.fromCharCode.apply(undefined, new Uint8Array([0x61, 0x62, 0x63, 0x64])); // "abcd"

// or, if String.fromCodePoint is available:
String.fromCodePoint.apply(undefined, new Uint16Array([0x61, 0x62, 0x63, 0x64])); // "abcd"

@DanielRosenwasser
Copy link
Member

@rbuckton I did try that over at f850a85. I think it was maybe slightly better, and I'm not opposed to it. You can see the perf results over at #43987 (comment)

@dmichon-msft
Copy link
Contributor Author

@rbuckton , the reason this PR doesn't use Uint8Array or Uint16Array is to be maximally compatible with the ES5 target. Also, I should note that String.fromCharCode technically operates on UTF-16, and String.fromCodePoint actually operates on the full unicode code points, e.g. some emoji will have values >65535. I'd be curious to see if using Uint16Array is any faster, but ultimately it gets expanded to type number when written to the stack during the String.fromCharCode call.
Variadic functions: like taking an array but awkward to call with a dynamic number of inputs and you get to overflow the stack if you want to process too many inputs at once.

@DanielRosenwasser
Copy link
Member

the reason this PR doesn't use Uint8Array or Uint16Array is to be maximally compatible with the ES5 target

I don't even remember whether we really target ES6 or ES5 and just expect polyfills at this point

@dmichon-msft dmichon-msft changed the title Test normal char code array for source mappings Generate SourceMap mappings string using array of character codes and fewer String.fromCharCode calls May 12, 2021
@dmichon-msft
Copy link
Contributor Author

For the CodeQL check, likely was very close to running out of memory in the past and just ran over. Might need a --max-old-space-size= option somewhere. Can use the NODE_OPTIONS environment variable to set it if there is no obvious place to plumb it through.

@DanielRosenwasser
Copy link
Member

DanielRosenwasser commented May 14, 2021 •
edited
Loading

Looks like this should be fixed. github/codeql-action#498

@DanielRosenwasser DanielRosenwasser merged commit 9136bb1 into microsoft:master May 18, 2021
@DanielRosenwasser
Copy link
Member

Thanks @dmichon-msft!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielRosenwasser DanielRosenwasser DanielRosenwasser approved these changes

@amcasey amcasey amcasey approved these changes

@rbuckton rbuckton Awaiting requested review from rbuckton

@sheetalkamat sheetalkamat Awaiting requested review from sheetalkamat

Assignees

@DanielRosenwasser DanielRosenwasser

Labels
For Milestone Bug PRs that fix a bug with a specific milestone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Running compiler on itself allocates a lot in addMapping
5 participants
@dmichon-msft @DanielRosenwasser @typescript-bot @rbuckton @amcasey