Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use 'abstract new' in InstanceType and ConstructorParameters #43380

Merged
merged 1 commit into from
Mar 25, 2021
Merged

Use 'abstract new' in InstanceType and ConstructorParameters #43380

merged 1 commit into from
Mar 25, 2021

Conversation

rbuckton
Copy link
Member

This finishes up the remaining work from #36392 to update ConstructorParameters and InstanceType to use abstract constructor types so that you can retrieve parameter lists and instance types from abstract classes:

abstract class C {
  constructor(x: number) {}
}

// before: error
// after: [x: number]
type P = ConstructorParameters<C>;

// before: error
// after: C
type I = InstanceType<C>;

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Mar 25, 2021
This was referenced Mar 25, 2021
Merged
Merged
@rbuckton
Copy link
Member Author

Looks like we still need to update typescript-eslint. Fix for that is up in #43381

weswigham
weswigham approved these changes Mar 25, 2021
View reviewed changes
Copy link
Member

@weswigham weswigham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine, but it looks like our linter does need to get its deps updated first.

@rbuckton
Copy link
Member Author

This looks fine, but it looks like our linter does need to get its deps updated first.

That's what #43381 is for.

@rbuckton rbuckton merged commit e10a325 into master Mar 25, 2021
@rbuckton rbuckton deleted the use-abstract-new branch March 25, 2021 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weswigham weswigham weswigham approved these changes

@sandersn sandersn Awaiting requested review from sandersn

@ahejlsberg ahejlsberg Awaiting requested review from ahejlsberg

Assignees

@rbuckton rbuckton

Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rbuckton @weswigham @typescript-bot