Only skip any checks for unwrapped tuples in conditionals, rather than all nondistributive conditionals for backcompat#42447
Merged
weswigham merged 1 commit intomicrosoft:masterfrom Jan 29, 2021
Conversation
…n all nondistributive conditionals for backcompat
typescript-bot
added
Author: Team
For Milestone Bug
This was referenced Jan 22, 2021
17 tasks
sandersn
approved these changes
Jan 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #42337 - thanks @xandris for the small repro.
Fixes #42336
Notably, as the test demonstrates, our old behavior is inconsistent between equivalent forms of non-distributive conditional; so I feel like limiting the any-picks-both-branches behavior to only distributive conditionals might be a worthwhile future intentional break.