Reuse input nodes where possible when serializing jsdoc implements clauses #41783
Conversation
typescript-bot
added
Author: Team
For Milestone Bug
weswigham
force-pushed
the
implements-jsdoc-type-params
branch
from
6e9b462 to
d5280d0
Compare
sandersn
left a comment
sandersn
left a comment
There was a problem hiding this comment.
One question about what trackExistingEntityName can do
src/compiler/checker.ts
Outdated
| return cleanup(/*result*/ undefined); | ||
| } | ||
| } | ||
| return cleanup(factory.createExpressionWithTypeArguments(expr, map(e.typeArguments, a => serializeExistingTypeNode(context, a, includePrivateSymbol, bundled) || typeToTypeNodeHelper(getTypeFromTypeNode(a), context)))); |
There was a problem hiding this comment.
I'm not sure this is the best way to break up this line, but it's what I ended up doing so I could read it.
| return cleanup(factory.createExpressionWithTypeArguments(expr, map(e.typeArguments, a => serializeExistingTypeNode(context, a, includePrivateSymbol, bundled) || typeToTypeNodeHelper(getTypeFromTypeNode(a), context)))); | |
| return cleanup(factory.createExpressionWithTypeArguments(expr, | |
| map(e.typeArguments, a => | |
| serializeExistingTypeNode(context, a, includePrivateSymbol, bundled) | |
| || typeToTypeNodeHelper(getTypeFromTypeNode(a), context)))); |
| return cleanup(factory.createExpressionWithTypeArguments(expr, map(e.typeArguments, a => serializeExistingTypeNode(context, a, includePrivateSymbol, bundled) || typeToTypeNodeHelper(getTypeFromTypeNode(a), context)))); | ||
|
|
||
| function cleanup<T>(result: T): T { | ||
| context.enclosingDeclaration = oldEnclosing; |
There was a problem hiding this comment.
I mean... try...finally is that, but has bad perf implications last I checked.
There was a problem hiding this comment.
that gives you the control flow, but not the scoping behaviour for variables. I'm talking something like special in Common Lisp, which would allow the assignment to context.enclosingDeclaration on line 6733 to be popped off the stack at the end of the scope instead of requiring the oldEnclosing=context.enclosing/context.enclosing=oldEnclosing bracketing to be manually written.
src/compiler/checker.ts
Outdated
| const baseTypes = getBaseTypes(classType); | ||
| const implementsExpressions = mapDefined(getImplementsTypes(classType), serializeImplementedType); | ||
| const originalImplements = originalDecl && getEffectiveImplementsTypeNodes(originalDecl); | ||
| const implementsExpressions = originalImplements && sanitizeJSDocImplements(originalImplements) || mapDefined(getImplementsTypes(classType), serializeImplementedType); |
There was a problem hiding this comment.
might be nice to break this line too
4 participants
Fixes #41258