Skip to content

Add tracing support to tsserver#41374

Merged
amcasey merged 21 commits intomicrosoft:masterfrom
amcasey:ServerTracing
Nov 16, 2020
Merged

Add tracing support to tsserver#41374
amcasey merged 21 commits intomicrosoft:masterfrom
amcasey:ServerTracing

Conversation

@amcasey
Copy link
Member

@amcasey amcasey commented Nov 3, 2020

Read the TSS_TRACE environment variable to determine which directory trace files should be written to.

Notable changes from tsc tracing:

  1. Drop all tracepoints that depend on type IDs
  2. Write output to trace.PID.json
  3. New, server-specific events (request/response, cancellation, etc)

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Nov 3, 2020
@typescript-bot
Copy link
Collaborator

typescript-bot commented Nov 3, 2020

The PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

@amcasey
Copy link
Member Author

amcasey commented Nov 3, 2020 •
edited
Loading

I'm a little nervous about the perf implications of the try-finally blocks, but the change is largely useless without them.

Oh wait: I can probably drop them from all the checker tracepoints that are ignored.

Edit: They were (a) fast and (b) unnecessary.

@amcasey
Copy link
Member Author

amcasey commented Nov 3, 2020

@sheetalkamat If you know that some of these other try-finally unblocks are unnecessary, because they're wrapping uncancellable code, please let me know.

amcasey
amcasey commented Nov 3, 2020
View reviewed changes
amcasey
amcasey commented Nov 3, 2020
View reviewed changes
@amcasey
Copy link
Member Author

amcasey commented Nov 3, 2020

Seems to work in both VS and VS Code without editor changes (though both might want to control it directly).

@amcasey
Copy link
Member Author

amcasey commented Nov 3, 2020

@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Nov 3, 2020 •
edited
Loading

Heya @amcasey, I've started to run the perf test suite on this PR at cea3fc0. You can monitor the build here.

Update: The results are in!

@amcasey
Copy link
Member Author

amcasey commented Nov 3, 2020

@typescript-bot pack this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Nov 3, 2020 •
edited
Loading

Heya @amcasey, I've started to run the tarball bundle task on this PR at cea3fc0. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Nov 3, 2020

@amcasey
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..41374

Metric master 41374 Delta Best Worst
Angular - node (v10.16.3, x64)
Memory used 344,955k (± 0.02%) 344,896k (± 0.02%) -59k (- 0.02%) 344,785k 345,059k
Parse Time 2.00s (± 0.41%) 1.97s (± 0.44%) -0.03s (- 1.40%) 1.95s 1.99s
Bind Time 0.84s (± 0.69%) 0.83s (± 1.02%) -0.01s (- 1.42%) 0.82s 0.86s
Check Time 4.97s (± 0.41%) 4.94s (± 0.53%) -0.03s (- 0.66%) 4.88s 4.97s
Emit Time 5.38s (± 0.76%) 5.34s (± 0.46%) -0.04s (- 0.78%) 5.29s 5.39s
Total Time 13.19s (± 0.47%) 13.08s (± 0.38%) -0.12s (- 0.88%) 12.99s 13.21s
Monaco - node (v10.16.3, x64)
Memory used 354,699k (± 0.02%) 354,703k (± 0.02%) +5k (+ 0.00%) 354,544k 354,882k
Parse Time 1.61s (± 0.63%) 1.61s (± 0.42%) -0.01s (- 0.31%) 1.59s 1.62s
Bind Time 0.73s (± 0.91%) 0.73s (± 0.85%) -0.00s (- 0.14%) 0.72s 0.75s
Check Time 5.14s (± 0.49%) 5.13s (± 0.47%) -0.01s (- 0.18%) 5.07s 5.18s
Emit Time 2.83s (± 0.91%) 2.80s (± 0.78%) -0.03s (- 1.09%) 2.76s 2.87s
Total Time 10.32s (± 0.49%) 10.27s (± 0.33%) -0.05s (- 0.46%) 10.19s 10.34s
TFS - node (v10.16.3, x64)
Memory used 307,920k (± 0.02%) 307,900k (± 0.01%) -21k (- 0.01%) 307,782k 307,960k
Parse Time 1.24s (± 0.82%) 1.24s (± 0.48%) -0.00s (- 0.24%) 1.22s 1.25s
Bind Time 0.68s (± 0.87%) 0.68s (± 0.91%) -0.00s (- 0.44%) 0.66s 0.69s
Check Time 4.58s (± 0.45%) 4.56s (± 0.45%) -0.01s (- 0.26%) 4.50s 4.60s
Emit Time 2.94s (± 1.26%) 2.95s (± 0.86%) +0.01s (+ 0.24%) 2.89s 2.99s
Total Time 9.44s (± 0.47%) 9.43s (± 0.33%) -0.01s (- 0.11%) 9.36s 9.47s
material-ui - node (v10.16.3, x64)
Memory used 489,261k (± 0.01%) 489,212k (± 0.01%) -49k (- 0.01%) 489,119k 489,322k
Parse Time 2.07s (± 0.50%) 2.06s (± 0.58%) -0.01s (- 0.39%) 2.04s 2.10s
Bind Time 0.66s (± 0.88%) 0.66s (± 0.84%) +0.00s (+ 0.15%) 0.65s 0.67s
Check Time 13.62s (± 0.66%) 13.52s (± 0.88%) -0.11s (- 0.78%) 13.32s 13.88s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 16.35s (± 0.63%) 16.24s (± 0.80%) -0.11s (- 0.70%) 16.03s 16.64s
Angular - node (v12.1.0, x64)
Memory used 322,741k (± 0.02%) 322,818k (± 0.03%) +77k (+ 0.02%) 322,575k 322,987k
Parse Time 1.98s (± 0.64%) 1.97s (± 0.77%) -0.01s (- 0.61%) 1.93s 2.00s
Bind Time 0.82s (± 0.94%) 0.81s (± 0.90%) -0.01s (- 1.10%) 0.80s 0.83s
Check Time 4.91s (± 0.19%) 4.87s (± 0.53%) -0.04s (- 0.90%) 4.82s 4.94s
Emit Time 5.52s (± 0.76%) 5.52s (± 1.09%) -0.01s (- 0.11%) 5.45s 5.73s
Total Time 13.23s (± 0.42%) 13.17s (± 0.55%) -0.07s (- 0.51%) 13.08s 13.39s
Monaco - node (v12.1.0, x64)
Memory used 336,784k (± 0.03%) 336,848k (± 0.01%) +64k (+ 0.02%) 336,752k 336,962k
Parse Time 1.60s (± 1.03%) 1.58s (± 0.73%) -0.02s (- 1.06%) 1.56s 1.61s
Bind Time 0.71s (± 0.87%) 0.71s (± 0.73%) -0.00s (- 0.28%) 0.70s 0.72s
Check Time 4.93s (± 0.30%) 4.94s (± 0.57%) +0.01s (+ 0.24%) 4.88s 5.00s
Emit Time 2.89s (± 0.77%) 2.87s (± 0.47%) -0.02s (- 0.52%) 2.84s 2.91s
Total Time 10.13s (± 0.37%) 10.11s (± 0.40%) -0.02s (- 0.16%) 10.04s 10.19s
TFS - node (v12.1.0, x64)
Memory used 292,143k (± 0.03%) 292,171k (± 0.02%) +28k (+ 0.01%) 291,965k 292,330k
Parse Time 1.26s (± 0.72%) 1.25s (± 0.94%) -0.01s (- 0.64%) 1.23s 1.28s
Bind Time 0.66s (± 0.94%) 0.66s (± 1.05%) -0.00s (- 0.61%) 0.64s 0.67s
Check Time 4.52s (± 0.53%) 4.51s (± 0.53%) -0.01s (- 0.20%) 4.46s 4.57s
Emit Time 2.98s (± 0.85%) 2.97s (± 1.14%) -0.01s (- 0.40%) 2.89s 3.06s
Total Time 9.41s (± 0.52%) 9.39s (± 0.50%) -0.03s (- 0.30%) 9.27s 9.45s
material-ui - node (v12.1.0, x64)
Memory used 467,066k (± 0.08%) 467,336k (± 0.01%) +270k (+ 0.06%) 467,232k 467,480k
Parse Time 2.08s (± 0.73%) 2.08s (± 0.24%) -0.01s (- 0.43%) 2.06s 2.08s
Bind Time 0.65s (± 0.89%) 0.65s (± 0.46%) -0.00s (- 0.31%) 0.64s 0.65s
Check Time 12.16s (± 1.04%) 12.04s (± 0.98%) -0.12s (- 1.02%) 11.90s 12.40s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 14.90s (± 0.88%) 14.76s (± 0.81%) -0.14s (- 0.95%) 14.62s 15.12s
Angular - node (v8.9.0, x64)
Memory used 347,472k (± 0.01%) 347,471k (± 0.02%) -1k (- 0.00%) 347,346k 347,566k
Parse Time 2.53s (± 0.49%) 2.52s (± 0.54%) -0.01s (- 0.40%) 2.49s 2.56s
Bind Time 0.87s (± 0.76%) 0.87s (± 0.26%) -0.00s (- 0.11%) 0.86s 0.87s
Check Time 5.62s (± 0.51%) 5.60s (± 0.96%) -0.02s (- 0.39%) 5.49s 5.71s
Emit Time 6.33s (± 1.29%) 6.34s (± 1.31%) +0.01s (+ 0.11%) 6.16s 6.55s
Total Time 15.35s (± 0.66%) 15.32s (± 0.84%) -0.03s (- 0.18%) 15.09s 15.60s
Monaco - node (v8.9.0, x64)
Memory used 358,482k (± 0.01%) 358,540k (± 0.01%) +59k (+ 0.02%) 358,442k 358,665k
Parse Time 1.94s (± 0.36%) 1.93s (± 0.32%) -0.01s (- 0.62%) 1.92s 1.94s
Bind Time 0.92s (± 0.87%) 0.91s (± 0.68%) -0.01s (- 0.98%) 0.90s 0.92s
Check Time 5.66s (± 0.36%) 5.64s (± 0.45%) -0.02s (- 0.35%) 5.58s 5.71s
Emit Time 3.41s (± 1.08%) 3.41s (± 1.10%) -0.00s (- 0.03%) 3.27s 3.46s
Total Time 11.93s (± 0.40%) 11.89s (± 0.51%) -0.04s (- 0.34%) 11.70s 12.03s
TFS - node (v8.9.0, x64)
Memory used 310,354k (± 0.02%) 310,420k (± 0.02%) +65k (+ 0.02%) 310,292k 310,524k
Parse Time 1.57s (± 0.59%) 1.57s (± 0.52%) -0.00s (- 0.13%) 1.55s 1.59s
Bind Time 0.69s (± 1.05%) 0.69s (± 0.50%) -0.01s (- 0.72%) 0.68s 0.69s
Check Time 5.34s (± 0.71%) 5.35s (± 0.77%) +0.01s (+ 0.15%) 5.29s 5.45s
Emit Time 2.99s (± 0.74%) 2.98s (± 0.74%) -0.02s (- 0.53%) 2.93s 3.01s
Total Time 10.60s (± 0.54%) 10.58s (± 0.56%) -0.02s (- 0.15%) 10.45s 10.73s
material-ui - node (v8.9.0, x64)
Memory used 496,208k (± 0.02%) 496,250k (± 0.01%) +43k (+ 0.01%) 496,183k 496,348k
Parse Time 2.50s (± 0.85%) 2.49s (± 0.44%) -0.01s (- 0.48%) 2.46s 2.52s
Bind Time 0.82s (± 1.83%) 0.81s (± 1.04%) -0.01s (- 1.22%) 0.79s 0.83s
Check Time 17.97s (± 1.42%) 18.04s (± 0.76%) +0.07s (+ 0.37%) 17.73s 18.32s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 21.30s (± 1.29%) 21.34s (± 0.62%) +0.04s (+ 0.21%) 21.04s 21.61s
Angular - node (v8.9.0, x86)
Memory used 199,172k (± 0.03%) 199,201k (± 0.02%) +28k (+ 0.01%) 199,103k 199,268k
Parse Time 2.43s (± 0.75%) 2.44s (± 1.16%) +0.00s (+ 0.21%) 2.38s 2.51s
Bind Time 1.02s (± 0.87%) 1.02s (± 0.66%) -0.00s (- 0.10%) 1.01s 1.04s
Check Time 5.03s (± 0.62%) 5.05s (± 0.51%) +0.01s (+ 0.30%) 5.00s 5.11s
Emit Time 6.12s (± 0.51%) 6.13s (± 1.11%) +0.01s (+ 0.15%) 5.95s 6.24s
Total Time 14.61s (± 0.35%) 14.64s (± 0.65%) +0.03s (+ 0.22%) 14.39s 14.83s
Monaco - node (v8.9.0, x86)
Memory used 203,000k (± 0.02%) 202,999k (± 0.01%) -1k (- 0.00%) 202,949k 203,071k
Parse Time 1.97s (± 0.43%) 1.98s (± 1.14%) +0.01s (+ 0.66%) 1.95s 2.05s
Bind Time 0.72s (± 0.77%) 0.72s (± 1.03%) -0.00s (- 0.28%) 0.71s 0.74s
Check Time 5.78s (± 1.01%) 5.67s (± 1.84%) -0.11s (- 1.85%) 5.41s 5.89s
Emit Time 2.80s (± 2.75%) 2.82s (± 3.89%) +0.02s (+ 0.57%) 2.70s 3.12s
Total Time 11.27s (± 0.38%) 11.19s (± 0.60%) -0.08s (- 0.70%) 11.08s 11.38s
TFS - node (v8.9.0, x86)
Memory used 177,449k (± 0.02%) 177,507k (± 0.02%) +58k (+ 0.03%) 177,455k 177,563k
Parse Time 1.61s (± 0.62%) 1.61s (± 0.72%) +0.00s (+ 0.25%) 1.60s 1.65s
Bind Time 0.66s (± 0.91%) 0.65s (± 0.80%) -0.00s (- 0.61%) 0.64s 0.67s
Check Time 4.85s (± 0.46%) 4.86s (± 0.49%) +0.01s (+ 0.19%) 4.82s 4.93s
Emit Time 2.84s (± 1.17%) 2.84s (± 0.96%) -0.00s (- 0.04%) 2.78s 2.90s
Total Time 9.96s (± 0.42%) 9.97s (± 0.52%) +0.01s (+ 0.08%) 9.88s 10.07s
material-ui - node (v8.9.0, x86)
Memory used 279,272k (± 0.01%) 279,280k (± 0.02%) +8k (+ 0.00%) 279,160k 279,370k
Parse Time 2.55s (± 0.47%) 2.55s (± 0.68%) -0.00s (- 0.04%) 2.52s 2.60s
Bind Time 0.75s (± 7.20%) 0.74s (± 7.34%) -0.01s (- 0.67%) 0.69s 0.87s
Check Time 16.50s (± 0.81%) 16.35s (± 0.90%) -0.15s (- 0.94%) 16.09s 16.77s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 19.81s (± 0.66%) 19.64s (± 0.69%) -0.16s (- 0.82%) 19.44s 20.08s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-166-generic
Architecturex64
Available Memory16 GB
Available Memory1 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v8.9.0, x64)
  • node (v8.9.0, x86)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v8.9.0, x64)
  • Angular - node (v8.9.0, x86)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v8.9.0, x64)
  • Monaco - node (v8.9.0, x86)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v8.9.0, x64)
  • TFS - node (v8.9.0, x86)
  • material-ui - node (v10.16.3, x64)
  • material-ui - node (v12.1.0, x64)
  • material-ui - node (v8.9.0, x64)
  • material-ui - node (v8.9.0, x86)
Benchmark Name Iterations
Current 41374 10
Baseline master 10

sheetalkamat
sheetalkamat reviewed Nov 3, 2020
View reviewed changes
@amcasey
Copy link
Member Author

amcasey commented Nov 4, 2020

@typescript-bot pack this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Nov 4, 2020 •
edited
Loading

Heya @amcasey, I've started to run the tarball bundle task on this PR at c60456d. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Nov 4, 2020 •
edited
Loading

Hey @amcasey, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/88579/artifacts?artifactName=tgz&fileId=668AF4AB043F3F2A99570C28347E2256FA0C009811ED4FFAF93B8389D3D5362402&fileName=/typescript-4.2.0-insiders.20201104.tgz"
    }
}

and then running npm install.

There is also a playground for this build.

@amcasey
Copy link
Member Author

amcasey commented Nov 4, 2020

FYI @mjbvz, in case a corresponding VS Code setting is desirable.

elibarzilay
elibarzilay suggested changes Nov 6, 2020
View reviewed changes
Copy link
Contributor

@elibarzilay elibarzilay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The thing that bugs me most is the thing about the nested try-catch-es.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Nov 9, 2020

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

amcasey
amcasey commented Nov 9, 2020
View reviewed changes
@amcasey amcasey requested a review from elibarzilay November 10, 2020 18:38
@amcasey
Copy link
Member Author

amcasey commented Nov 10, 2020

@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Nov 10, 2020 •
edited
Loading

Heya @amcasey, I've started to run the perf test suite on this PR at 90dde84. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Nov 10, 2020

@amcasey
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..41374

Metric master 41374 Delta Best Worst
Angular - node (v10.16.3, x64)
Memory used 344,436k (± 0.02%) 344,501k (± 0.02%) +65k (+ 0.02%) 344,393k 344,635k
Parse Time 1.98s (± 0.47%) 1.99s (± 0.58%) +0.01s (+ 0.25%) 1.96s 2.02s
Bind Time 0.83s (± 1.33%) 0.83s (± 0.93%) -0.00s (- 0.24%) 0.81s 0.84s
Check Time 4.95s (± 0.37%) 4.95s (± 0.43%) 0.00s ( 0.00%) 4.90s 5.00s
Emit Time 5.34s (± 0.50%) 5.34s (± 0.64%) +0.00s (+ 0.04%) 5.28s 5.44s
Total Time 13.10s (± 0.40%) 13.11s (± 0.43%) +0.01s (+ 0.05%) 12.98s 13.23s
Monaco - node (v10.16.3, x64)
Memory used 354,708k (± 0.03%) 354,655k (± 0.01%) -53k (- 0.02%) 354,561k 354,753k
Parse Time 1.60s (± 0.51%) 1.61s (± 0.72%) +0.00s (+ 0.19%) 1.57s 1.62s
Bind Time 0.73s (± 0.45%) 0.73s (± 0.88%) +0.00s (+ 0.27%) 0.72s 0.75s
Check Time 5.12s (± 0.54%) 5.15s (± 0.40%) +0.03s (+ 0.49%) 5.11s 5.20s
Emit Time 2.81s (± 0.62%) 2.82s (± 1.04%) +0.01s (+ 0.50%) 2.76s 2.88s
Total Time 10.26s (± 0.35%) 10.30s (± 0.50%) +0.05s (+ 0.45%) 10.21s 10.41s
TFS - node (v10.16.3, x64)
Memory used 307,850k (± 0.02%) 307,912k (± 0.03%) +62k (+ 0.02%) 307,792k 308,065k
Parse Time 1.24s (± 0.77%) 1.23s (± 0.57%) -0.00s (- 0.40%) 1.22s 1.25s
Bind Time 0.68s (± 0.65%) 0.68s (± 0.49%) -0.00s (- 0.29%) 0.67s 0.69s
Check Time 4.58s (± 0.34%) 4.58s (± 0.42%) -0.01s (- 0.11%) 4.54s 4.62s
Emit Time 2.93s (± 0.82%) 2.96s (± 1.22%) +0.03s (+ 0.96%) 2.86s 3.03s
Total Time 9.43s (± 0.33%) 9.45s (± 0.57%) +0.02s (+ 0.21%) 9.35s 9.57s
material-ui - node (v10.16.3, x64)
Memory used 489,213k (± 0.01%) 489,228k (± 0.01%) +15k (+ 0.00%) 489,099k 489,333k
Parse Time 2.06s (± 0.40%) 2.06s (± 0.43%) +0.00s (+ 0.05%) 2.04s 2.08s
Bind Time 0.65s (± 1.00%) 0.65s (± 0.99%) +0.00s (+ 0.62%) 0.63s 0.66s
Check Time 13.52s (± 0.47%) 13.61s (± 0.74%) +0.09s (+ 0.68%) 13.41s 13.86s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 16.23s (± 0.41%) 16.32s (± 0.67%) +0.09s (+ 0.57%) 16.09s 16.59s
Angular - node (v12.1.0, x64)
Memory used 322,323k (± 0.02%) 322,323k (± 0.03%) 0k ( 0.00%) 322,126k 322,533k
Parse Time 1.96s (± 0.34%) 1.97s (± 0.76%) +0.01s (+ 0.51%) 1.93s 2.01s
Bind Time 0.81s (± 0.58%) 0.81s (± 0.73%) +0.00s (+ 0.49%) 0.80s 0.83s
Check Time 4.89s (± 0.52%) 4.89s (± 0.69%) +0.00s (+ 0.04%) 4.83s 4.98s
Emit Time 5.49s (± 0.36%) 5.50s (± 0.85%) +0.01s (+ 0.16%) 5.44s 5.66s
Total Time 13.15s (± 0.27%) 13.18s (± 0.54%) +0.03s (+ 0.22%) 13.03s 13.37s
Monaco - node (v12.1.0, x64)
Memory used 336,813k (± 0.02%) 336,826k (± 0.03%) +13k (+ 0.00%) 336,611k 337,031k
Parse Time 1.59s (± 0.60%) 1.58s (± 0.71%) -0.01s (- 0.57%) 1.56s 1.61s
Bind Time 0.71s (± 0.99%) 0.71s (± 0.52%) -0.00s (- 0.70%) 0.70s 0.71s
Check Time 4.90s (± 0.62%) 4.92s (± 0.44%) +0.02s (+ 0.47%) 4.87s 4.99s
Emit Time 2.85s (± 0.63%) 2.88s (± 0.76%) +0.02s (+ 0.88%) 2.83s 2.92s
Total Time 10.05s (± 0.38%) 10.08s (± 0.32%) +0.03s (+ 0.34%) 10.02s 10.16s
TFS - node (v12.1.0, x64)
Memory used 292,016k (± 0.02%) 292,107k (± 0.04%) +91k (+ 0.03%) 291,918k 292,422k
Parse Time 1.25s (± 0.70%) 1.26s (± 0.67%) +0.01s (+ 0.88%) 1.24s 1.28s
Bind Time 0.66s (± 0.91%) 0.66s (± 0.87%) +0.01s (+ 0.76%) 0.65s 0.67s
Check Time 4.49s (± 0.42%) 4.51s (± 0.65%) +0.02s (+ 0.53%) 4.47s 4.60s
Emit Time 2.99s (± 1.18%) 2.96s (± 1.17%) -0.03s (- 0.97%) 2.89s 3.06s
Total Time 9.38s (± 0.50%) 9.39s (± 0.50%) +0.01s (+ 0.12%) 9.28s 9.49s
material-ui - node (v12.1.0, x64)
Memory used 467,205k (± 0.05%) 467,060k (± 0.07%) -145k (- 0.03%) 466,064k 467,344k
Parse Time 2.07s (± 0.43%) 2.08s (± 0.50%) +0.01s (+ 0.24%) 2.05s 2.10s
Bind Time 0.65s (± 0.53%) 0.65s (± 0.89%) +0.00s (+ 0.46%) 0.64s 0.66s
Check Time 12.00s (± 0.67%) 12.12s (± 1.33%) +0.12s (+ 0.98%) 11.91s 12.63s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 14.72s (± 0.58%) 14.85s (± 1.16%) +0.13s (+ 0.87%) 14.61s 15.39s
Angular - node (v8.9.0, x64)
Memory used 347,048k (± 0.02%) 347,053k (± 0.02%) +5k (+ 0.00%) 346,916k 347,213k
Parse Time 2.51s (± 0.44%) 2.53s (± 0.38%) +0.01s (+ 0.48%) 2.50s 2.55s
Bind Time 0.87s (± 0.76%) 0.87s (± 0.79%) -0.00s (- 0.46%) 0.85s 0.88s
Check Time 5.61s (± 0.69%) 5.61s (± 0.72%) -0.00s (- 0.05%) 5.51s 5.69s
Emit Time 6.31s (± 1.13%) 6.40s (± 1.32%) +0.08s (+ 1.28%) 6.26s 6.56s
Total Time 15.31s (± 0.58%) 15.39s (± 0.69%) +0.08s (+ 0.55%) 15.15s 15.61s
Monaco - node (v8.9.0, x64)
Memory used 358,492k (± 0.01%) 358,507k (± 0.01%) +15k (+ 0.00%) 358,407k 358,619k
Parse Time 1.93s (± 0.32%) 1.93s (± 0.49%) +0.01s (+ 0.31%) 1.92s 1.96s
Bind Time 0.91s (± 0.82%) 0.91s (± 0.52%) +0.01s (+ 0.66%) 0.90s 0.92s
Check Time 5.63s (± 0.27%) 5.67s (± 0.46%) +0.04s (+ 0.69%) 5.59s 5.71s
Emit Time 3.42s (± 0.29%) 3.43s (± 0.78%) +0.01s (+ 0.44%) 3.37s 3.51s
Total Time 11.89s (± 0.17%) 11.95s (± 0.47%) +0.07s (+ 0.56%) 11.79s 12.06s
TFS - node (v8.9.0, x64)
Memory used 310,316k (± 0.02%) 310,326k (± 0.01%) +10k (+ 0.00%) 310,238k 310,398k
Parse Time 1.57s (± 0.54%) 1.57s (± 0.52%) +0.00s (+ 0.06%) 1.55s 1.59s
Bind Time 0.69s (± 0.69%) 0.68s (± 1.00%) -0.00s (- 0.29%) 0.67s 0.70s
Check Time 5.34s (± 0.65%) 5.33s (± 0.68%) -0.00s (- 0.06%) 5.27s 5.44s
Emit Time 3.00s (± 0.88%) 2.97s (± 0.92%) -0.03s (- 1.03%) 2.87s 3.01s
Total Time 10.59s (± 0.58%) 10.56s (± 0.56%) -0.03s (- 0.31%) 10.39s 10.71s
material-ui - node (v8.9.0, x64)
Memory used 496,244k (± 0.01%) 496,253k (± 0.01%) +9k (+ 0.00%) 496,142k 496,328k
Parse Time 2.49s (± 0.26%) 2.49s (± 0.59%) 0.00s ( 0.00%) 2.47s 2.54s
Bind Time 0.81s (± 1.22%) 0.80s (± 1.25%) -0.00s (- 0.50%) 0.79s 0.84s
Check Time 18.07s (± 0.83%) 18.07s (± 0.62%) +0.00s (+ 0.02%) 17.88s 18.30s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 21.37s (± 0.70%) 21.37s (± 0.51%) -0.00s (- 0.00%) 21.18s 21.60s
Angular - node (v8.9.0, x86)
Memory used 198,993k (± 0.02%) 198,989k (± 0.03%) -4k (- 0.00%) 198,897k 199,080k
Parse Time 2.44s (± 0.53%) 2.44s (± 0.58%) +0.00s (+ 0.16%) 2.42s 2.49s
Bind Time 1.01s (± 0.94%) 1.02s (± 1.08%) +0.01s (+ 0.79%) 1.00s 1.05s
Check Time 5.07s (± 0.45%) 5.04s (± 0.57%) -0.03s (- 0.61%) 4.97s 5.08s
Emit Time 6.11s (± 0.78%) 6.15s (± 0.83%) +0.05s (+ 0.74%) 6.02s 6.24s
Total Time 14.63s (± 0.48%) 14.65s (± 0.38%) +0.03s (+ 0.18%) 14.50s 14.78s
Monaco - node (v8.9.0, x86)
Memory used 203,076k (± 0.02%) 203,049k (± 0.03%) -27k (- 0.01%) 202,936k 203,166k
Parse Time 1.98s (± 0.76%) 1.97s (± 0.70%) -0.00s (- 0.10%) 1.95s 2.01s
Bind Time 0.72s (± 0.72%) 0.72s (± 1.17%) +0.00s (+ 0.00%) 0.70s 0.74s
Check Time 5.73s (± 1.26%) 5.76s (± 0.42%) +0.03s (+ 0.54%) 5.71s 5.82s
Emit Time 2.77s (± 2.64%) 2.78s (± 1.52%) +0.01s (+ 0.29%) 2.72s 2.93s
Total Time 11.19s (± 0.35%) 11.23s (± 0.29%) +0.04s (+ 0.38%) 11.17s 11.32s
TFS - node (v8.9.0, x86)
Memory used 177,506k (± 0.02%) 177,498k (± 0.02%) -9k (- 0.00%) 177,410k 177,602k
Parse Time 1.61s (± 1.17%) 1.63s (± 1.05%) +0.01s (+ 0.74%) 1.59s 1.67s
Bind Time 0.65s (± 0.91%) 0.66s (± 1.26%) +0.00s (+ 0.31%) 0.64s 0.68s
Check Time 4.87s (± 0.65%) 4.86s (± 0.61%) -0.01s (- 0.21%) 4.80s 4.91s
Emit Time 2.85s (± 1.04%) 2.84s (± 0.98%) -0.01s (- 0.28%) 2.77s 2.90s
Total Time 9.99s (± 0.65%) 9.98s (± 0.51%) -0.01s (- 0.06%) 9.84s 10.07s
material-ui - node (v8.9.0, x86)
Memory used 279,330k (± 0.01%) 279,333k (± 0.01%) +4k (+ 0.00%) 279,245k 279,423k
Parse Time 2.54s (± 0.61%) 2.55s (± 0.46%) +0.01s (+ 0.35%) 2.53s 2.58s
Bind Time 0.77s (± 7.15%) 0.77s (± 7.16%) -0.00s (- 0.13%) 0.69s 0.86s
Check Time 16.45s (± 0.57%) 16.49s (± 1.12%) +0.05s (+ 0.28%) 15.94s 16.79s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 19.76s (± 0.40%) 19.82s (± 0.89%) +0.06s (+ 0.30%) 19.32s 20.10s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-166-generic
Architecturex64
Available Memory16 GB
Available Memory1 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v8.9.0, x64)
  • node (v8.9.0, x86)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v8.9.0, x64)
  • Angular - node (v8.9.0, x86)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v8.9.0, x64)
  • Monaco - node (v8.9.0, x86)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v8.9.0, x64)
  • TFS - node (v8.9.0, x86)
  • material-ui - node (v10.16.3, x64)
  • material-ui - node (v12.1.0, x64)
  • material-ui - node (v8.9.0, x64)
  • material-ui - node (v8.9.0, x86)
Benchmark Name Iterations
Current 41374 10
Baseline master 10

sheetalkamat
sheetalkamat requested changes Nov 11, 2020
View reviewed changes
elibarzilay
elibarzilay reviewed Nov 11, 2020
View reviewed changes
@amcasey
Copy link
Member Author

amcasey commented Nov 11, 2020

@elibarzilay I've pulled out a shared helper from pop and popAll because it now has additional logic for E vs X events.

sheetalkamat
sheetalkamat requested changes Nov 12, 2020
View reviewed changes
@amcasey amcasey mentioned this pull request Nov 13, 2020
Merged
@amcasey amcasey merged commit 79ffd03 into microsoft:master Nov 16, 2020
@amcasey amcasey deleted the ServerTracing branch November 16, 2020 17:26
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sheetalkamat sheetalkamat sheetalkamat approved these changes

@elibarzilay elibarzilay Awaiting requested review from elibarzilay

Assignees

@amcasey amcasey

Labels

Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@amcasey @typescript-bot @elibarzilay @sheetalkamat