Skip to content

Consistent errors on circular base types - #39675

Merged
Anders Hejlsberg (ahejlsberg) merged 3 commits into
masterfrom
fix38098
Jul 21, 2020
Merged

Anders Hejlsberg (ahejlsberg) merged 3 commits into
masterfrom
fix38098

Conversation

@ahejlsberg

Copy link
Copy Markdown
Member

Fixes #38098.

@ahejlsberg

Copy link
Copy Markdown
Member Author

@typescript-bot

TypeScript Bot (typescript-bot) commented Jul 20, 2020 •

Copy link
Copy Markdown
Contributor

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the parallelized Definitely Typed test suite on this PR at 983ab3b. You can monitor the build here.

@typescript-bot

TypeScript Bot (typescript-bot) commented Jul 20, 2020 •

Copy link
Copy Markdown
Contributor

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the extended test suite on this PR at 983ab3b. You can monitor the build here.

@typescript-bot

TypeScript Bot (typescript-bot) commented Jul 20, 2020 •

Copy link
Copy Markdown
Contributor

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the parallelized community code test suite on this PR at 983ab3b. You can monitor the build here.

@typescript-bot

Copy link
Copy Markdown
Contributor

The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master.

@ahejlsberg

Copy link
Copy Markdown
Member Author

Tests are clean (or preexisting conditions) except for one failure in chrome-apps on Definitely Typed. This is the code:

interface DeviceFilter extends Partial<DeviceFilter> { }

That clearly isn't right and it's definitely good that we're flagging it now. Not sure what the intent actually is. Any ideas for a fix?

@weswigham

Wesley Wigham (weswigham) commented Jul 21, 2020 •

Copy link
Copy Markdown
Member

Honestly no idea what that's supposed to imply. The type extends the partial of itself? That's... Just trivially always true.

Maybe just delete the constraint?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

For Milestone Bug PRs that fix a bug with a specific milestone

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inconsistent recursive type allowed by Typescript

3 participants