Make hasCorrectArity handle tuples properly#38795
Merged
elibarzilay merged 2 commits intomicrosoft:masterfrom Jun 5, 2020
Merged
Make hasCorrectArity handle tuples properly#38795elibarzilay merged 2 commits intomicrosoft:masterfrom
hasCorrectArity handle tuples properly#38795elibarzilay merged 2 commits intomicrosoft:masterfrom
Conversation
Member
|
@typescript-bot test this |
Collaborator
|
Heya @RyanCavanaugh, I've started to run the extended test suite on this PR at 3d08da4. You can monitor the build here. |
Collaborator
|
Heya @RyanCavanaugh, I've started to run the parallelized community code test suite on this PR at 3d08da4. You can monitor the build here. |
Collaborator
|
The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master. |
This completes the work that started in PR microsoft#33069, and fixes microsoft#32835. There are probably two additional related changes that are needed to make this more complete: * Fix the code that composes the error message (see the first two `FIXME`s in `callWithSpread3.ts`). * Fix the code that checks the argument types (second two `FIXME`s). * There is also an error in `genericRestParameters1.ts` which changed but should not be an error in the first place. Added a `FIXME` there too. (Probably will work if the previous iterm is done.) In addition, `getEffectiveCallArguments` munges the arguments in case of a spread in the last argument which might be better to avoid. (I think that there are cases where it wouldn't work anyway, such as a spread of an array followed by a spread of an empty array.)
Contributor
Author
|
(After this is merged, there should be two new issues for the |
Member
|
I just looked at the user test failures and there's nothing new there. |
Member
|
Nothing in the RWC failures either. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This completes the work that started in PR #33069, and fixes #32835.
(Includes that PR in a separate commit.)
There are probably two additional related changes that are needed to
make this more complete:
Fix the code that composes the error message (see the first two
FIXMEs incallWithSpread3.ts).Fix the code that checks the argument types (second two
FIXMEs).There is also an error in
genericRestParameters1.tswhich changedbut should not be an error in the first place. Added a
FIXMEtheretoo. (Probably will work if the previous iterm is done.)
In addition,
getEffectiveCallArgumentsmunges the arguments in case ofa spread in the last argument which might be better to avoid. (I think
that there are cases where it wouldn't work anyway, such as a spread of
an array followed by a spread of an empty array.)