Report time spent in updateGraph #35675
Conversation
Add a response property indicating how much of the elapsed time (from `onMessage` to `doOutput`) was spent in `updateGraph` calls. If there's no `updateGraph` call, the property is undefined, to save space (with the downside that it's harder to tell whether a given telemetry event could have had the property). Fixes microsoft#34774
|
Thanks for the PR! It looks like you've changed the TSServer protocol in some way. Please ensure that any changes here don't break consumers of the current TSServer API. For some extra review, we'll ping @sheetalkamat, @amcasey, @mjbvz, @minestarks for you. Feel free to loop in other consumers/maintainers if necessary |
|
Just to clarify - this reflects the time spent in updateGraph during a given request, regardless of whether or not that request actually triggered the updateGraph, right? |
|
@uniqueiniquity Yep |
|
Note to reviewers: this looks over-engineered for a single property because it used to be for two properties and I decided the second one needed more refinement than would fit in the 3.8 timeframe. |
amcasey
left a comment
amcasey
left a comment
There was a problem hiding this comment.
Force pushed a rebase. Changes addressing PR feedback are in a separate commit.
5 participants
Add a response property indicating how much of the elapsed time (from
onMessagetodoOutput) was spent inupdateGraphcalls. If there'snoupdateGraphcall, the property is undefined, to save space (with the downside that it's harder to tell whether a given telemetry event could have had the property).Fixes #34774