Skip to content

Sort extract constant above extract function #35580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
andrewbranch merged 1 commit into from
Dec 9, 2019
Merged

Sort extract constant above extract function #35580

andrewbranch merged 1 commit into from
Dec 9, 2019

Conversation

@andrewbranch
Copy link
Member

@andrewbranch andrewbranch commented Dec 9, 2019

Fixes #29589

@andrewbranch andrewbranch requested a review from amcasey December 9, 2019 16:22
@amcasey
Copy link
Member

amcasey commented Dec 9, 2019

FYI @mjbvz

@andrewbranch andrewbranch merged commit 9a9baeb into microsoft:master Dec 9, 2019
@DanielRosenwasser
Copy link
Member

DanielRosenwasser commented Dec 9, 2019

No associated test change?

@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mjbvz mjbvz mjbvz approved these changes

+1 more reviewer

@amcasey amcasey amcasey approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Sort extract constant refactoring before extract function

4 participants

@andrewbranch @amcasey @DanielRosenwasser @mjbvz