Fix the build protocol script#33691
Conversation
| if (s.name === "Array" || s.name === "ReadOnlyArray") { | ||
| // we should process type argument instead | ||
| return this.processType((<any>type).typeArguments[0]); | ||
| const typeArgs = this.typeChecker.getTypeArguments(type as ts.TypeReference); |
There was a problem hiding this comment.
Ideally we'd probably also check if type.flags & ts.TypeFlags.TypeReference just to be sure, but I don't think we'll do something stupid like enum Array {} anywhere, so it's likely safe to assume it's a TypeReference.
|
For the record: this can only be merged into |
|
@weswigham your previous comment about when to merge this PR is now really old. Is it safe to merge now?
This, uh, makes me think that this should already have been merged. |
|
We no longer need it because we removed the API break in the services layer by keeping a getter for type arguments around. |
|
huzzah! |
4 participants
anystrikes again. Fixes a crash in the protocol builder script introduced by the recursive type PR