Better Array.sort compareFn docs#33372
Merged
orta merged 5 commits intomicrosoft:masterfrom Sep 25, 2019
m1gu3l:patch-1
Merged
Conversation
Contributor
Contributor
Author
|
@orta I'm not sure if it's the most common case to be used as example. If you have numbers or strings, you don't usually use custom (a, b) => a.index - b.index |
Contributor
|
Afraid not, wish it were true: Because it's alphabetical, not numerical - I've made this mistake a lot! |
Contributor
Author
|
@orta you're right, of course - and certainly have a point that example is needed |
Contributor
|
Alright - that's the baselines updated (basically compiler snapshots which got updated because the line references changed) and I've merged master. Will merge this when it greens. Thanks @m1gu3l :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes #33046