Include fewer paths in exception#32785
Merged
amcasey merged 3 commits intomicrosoft:masterfrom Aug 9, 2019
Merged
Conversation
It's sufficient to append them to the log.
sheetalkamat
approved these changes
Aug 9, 2019
Member
|
you need to update the failing test case |
sheetalkamat
reviewed
Aug 9, 2019
This was referenced Aug 9, 2019
Tyriar
pushed a commit
to microsoft/vscode
that referenced
this pull request
Aug 13, 2019
The error, which happens quite frequently, contains an excessively long path list. The message itself was cleaned up in microsoft/TypeScript#32785 but we add some additional filtering to the editor since older server versions are still in use.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's sufficient to add them to the log.