Clean up amalgamatedDuplicates#27285
Merged
2 commits merged intomasterfrom Oct 1, 2018
Merged
Conversation
ghost
force-pushed
the
duplicateDuplicates
branch
from
e4a7b02 to
9c388fa
Compare
sandersn
reviewed
Sep 28, 2018
| return a === b || typeof a === "object" && a !== null && typeof b === "object" && b !== null && equalOwnProperties(a as MapLike<unknown>, b as MapLike<unknown>, isJsonEqual); | ||
| } | ||
|
|
||
| export function getOrUpdate<T>(map: Map<T>, key: string, getValue: () => T): T { |
Member
There was a problem hiding this comment.
getValue should probably be named getDefault.
sandersn
reviewed
Sep 28, 2018
sandersn
reviewed
Sep 28, 2018
sandersn
reviewed
Sep 28, 2018
| amalgamatedDuplicates.set(cacheKey, existing); | ||
| return target; | ||
| const filesDuplicates = getOrUpdate<DuplicateInfoForFiles>(amalgamatedDuplicates, `${firstFile.path}|${secondFile.path}`, () => | ||
| ({ firstFile, secondFile, conflictingSymbols: createMap() })); |
Member
There was a problem hiding this comment.
I'd prefer to see DuplicateInfoForFiles as an assertion on the object literal: { firstFile, secondFile, conflictingSymbols: createMap() } as DuplicateInfoForFiles
Author
There was a problem hiding this comment.
That would conflict with https://palantir.github.io/tslint/rules/no-object-literal-type-assertion/ -- it's unsafe to cast an object literal because that allows misspelled properties.
sandersn
reviewed
Sep 28, 2018
sandersn
reviewed
Sep 28, 2018
sandersn
requested changes
Sep 28, 2018
Member
sandersn
left a comment
sandersn
left a comment
There was a problem hiding this comment.
Some questions and suggestion.
sandersn
approved these changes
Oct 1, 2018
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #27280
Cleans up the way
amalgamatedDuplicatesstores data, which happens to fix a bug where it reported the same location multiple times.