Prefer elaborating on expressions which could be called to produce a correct type by suggesting such #27016
Conversation
…correct type by suggesting such
weswigham
requested review from
DanielRosenwasser,
RyanCavanaugh and
amcasey
src/compiler/checker.ts
Outdated
| const callSignatures = getSignaturesOfType(source, SignatureKind.Call); | ||
| const constructSignatures = getSignaturesOfType(source, SignatureKind.Construct); | ||
| for (const signatures of [constructSignatures, callSignatures]) { | ||
| if (length(signatures)) { |
There was a problem hiding this comment.
Do you need the length() call with some?
src/compiler/checker.ts
Outdated
|
|
||
| function elaborateError(node: Expression | undefined, source: Type, target: Type): boolean { | ||
| if (!node || isOrHasGenericConditional(target)) return false; | ||
| if (!isTypeAssignableTo(source, target) && elaborateDidYouMeanToCallOrConstruct(node, source, target)) { |
There was a problem hiding this comment.
This should ideally be cheap since the original call will have some of the relationships cached, right?
Also, technically I think you should be using the original relationship, not assignability, right?
src/compiler/checker.ts
Outdated
| return !(returnType.flags & (TypeFlags.Any | TypeFlags.Never)) && isTypeAssignableTo(returnType, target); | ||
| })) { | ||
| const resultObj: { error?: Diagnostic } = {}; | ||
| checkTypeAssignableTo(source, target, node, /*errorMessage*/ undefined, /*containingChain*/ undefined, resultObj); |
There was a problem hiding this comment.
TIL errorOutputContainer
There was a problem hiding this comment.
Yeah, I added that awhile ago. Not the happiest about it, but a side channel's a side channel, since most callers just need the boolean return.
src/compiler/checker.ts
Outdated
| checkTypeAssignableTo(source, target, node, /*errorMessage*/ undefined, /*containingChain*/ undefined, resultObj); | ||
| const diagnostic = resultObj.error!; | ||
| addRelatedInfo(diagnostic, createDiagnosticForNode( | ||
| node, |
There was a problem hiding this comment.
Kind of funny that the "related span" is the same span.
There was a problem hiding this comment.
I think it's still probably the best place to put it. Wanna do something else?
| "category": "Message", | ||
| "code": 6212 | ||
| }, | ||
| "Did you mean to use `new` with this expression?": { |
There was a problem hiding this comment.
new[](start = 25, length = 5)
Elsewhere, "new" is in single quotes.
3 participants
Fixes #25308
(Note that this adds the messages, not a potential quickfix. A quickfix should be more narrow than the suggestion, as only a 0-argument call/construct has an obvious quickfix)