Allow isSymbolAccessible to paint object literal declarations as visible #24668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on - use checkExpression and resolvedSymbol instead
src/compiler/checker.ts
Outdated
| symbol = getContainerOfSymbol(symbol); | ||
| const container = getContainerOfSymbol(symbol); | ||
| // If we're trying to reference some object literal in, eg `var a = { x: 1 }`, the symbol for the literal, `__object`, is distinct | ||
| // from the symbol of the declaration it is beign assigned to. Since we can use the declaration to refer to the literal, however, |
RyanCavanaugh
approved these changes
Sep 5, 2018
Member
RyanCavanaugh
left a comment
RyanCavanaugh
left a comment
There was a problem hiding this comment.
LGTM; please merge after resolving conflicts
weswigham
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I've modified
isSymbolAccessibleto recognizevar a = { ... }as something that allows us to possibly reference the members of the object literal in the initializer (allowing the example to generate a declaration file without error, as suggested in the associated issue).Fixes #24632