Support exclamationToken in updateProperty and createProperty#21577
Merged
1 commit merged intomasterfrom Feb 2, 2018
Merged
Conversation
ghost
requested a review
from 
mhegazy
approved these changes
Feb 2, 2018
ghost
mentioned this pull request
Author
|
Waiting for @rbuckton to review too |
rbuckton
approved these changes
Feb 2, 2018
| node.modifiers = asNodeArray(modifiers); | ||
| node.name = asName(name); | ||
| node.questionToken = questionToken; | ||
| node.questionToken = questionOrExclamationToken !== undefined && questionOrExclamationToken.kind === SyntaxKind.QuestionToken ? questionOrExclamationToken : undefined; |
Contributor
There was a problem hiding this comment.
This leads me to wonder why we have two separate properties for this on PropertyDeclaration.
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I figured it would be easier to have a
questionOrExclamationTokenparameter instead of two separate ones if we don't plan on having those ever both present at the same time.