Remove unneeded ExportType and ExportNamespace flags #16766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
symbolFlags_export
branch
from
8594005 to
0df3263
Compare
ghost
force-pushed
the
symbolFlags_export
branch
from
0df3263 to
ffcb546
Compare
sandersn
requested changes
Jul 13, 2017
| ExportType = 1 << 1, | ||
| ExportNamespace = 1 << 2, | ||
| } | ||
| function getDeclarationSpaces(d: Declaration): DeclarationSpaces { |
There was a problem hiding this comment.
Where is this called? Why doesn't it have to change to accommodate the new enum?
There was a problem hiding this comment.
This is internal to checkExportsOnMergedDeclarations. It was just re-using the SymbolFlags enum, but these weren't really symbol flags. So I just gave it its own enum.
There was a problem hiding this comment.
Never mind, I missed the call on line 18827 (search and context weren't easy to get on the bus). Now it makes sense.
sandersn
approved these changes
Jul 13, 2017
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only use of these flags was actually re-using them for a different purpose; replaced that with a more specific enum.
I had noticed in #16742 that checking for
SymbolFlags.Exportwas not a reliable way of knowing whetherexportSymbolwill be present, since we now setSymbolFlags.Exporton CommonJS exports too.