Allow export default interface. Related to issue 3792.#15076
Closed
erikmcc wants to merge 1 commit intomicrosoft:masterfrom
erikmcc:master
Closed
Allow export default interface. Related to issue 3792.#15076erikmcc wants to merge 1 commit intomicrosoft:masterfrom erikmcc:master
erikmcc wants to merge 1 commit intomicrosoft:masterfrom
erikmcc:master
Conversation
Contributor
Author
|
Has the CLA changed? I am pretty sure I signed it before... |
|
@erikmcc, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request. |
mhegazy
reviewed
May 22, 2017
| export default interface A {} | ||
|
|
||
| //// [b.ts] | ||
| import A from './a' |
Contributor
There was a problem hiding this comment.
Please add a test where A is actually used.
Contributor
|
@Andy-MS can you please review this change. |
ghost
approved these changes
May 23, 2017
Contributor
|
I pushed tests and fixed resolveName in #16040 |
Contributor
|
closing in favor of #16040 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3792.