Repository navigation
Labels
BugA bug in TypeScriptA bug in TypeScriptDomain: check: Variance RelationshipsThe issue relates to variance relationships between typesThe issue relates to variance relationships between types
Milestone
Description
π Search Terms
error, nested, array, order
π Version & Regression Information
- This changed between versions 4.4.4 and 4.5.5 (from playground testing - all later version exhibit this behaviour).
β― Playground Link
π» Code
type TypeA = number;
type TypeB = boolean;
type DataTypeTwo<T extends TypeA | TypeB> = {
one: Array<{ two: Array<T> }>;
};
type DataTypeThree<T extends TypeA | TypeB> = {
one: Array<{ two: Array<{ three: Array<T> }> }>;
};
let testingThreeErr: DataTypeThree<TypeA> = {
one: [{ two: [ {three: [ true ] } ]}] // errors as expected
};
let testingTwoErr: DataTypeTwo<TypeA> = {
one: [{ two: [ false ] }] // errors as expected
};
// Uncomment these lines to see all errors
// let testingTwoPre: DataTypeTwo<TypeA> = {
// one: [{ two: [ 5 ] }]
// };
// let t2aPre: DataTypeTwo<TypeB> = testingTwoPre;
let testingThree: DataTypeThree<TypeA> = {
one: [{ two: [ {three: [ 5 ] } ]}]
};
// Comment out this line to see error for t2a assignment
let t3a: DataTypeThree<TypeB> = testingThree; // Should error, but does not
let testingTwo: DataTypeTwo<TypeA> = {
one: [{ two: [ 5 ] }]
};
let t2a: DataTypeTwo<TypeB> = testingTwo; // errors only if section above commented out
let check: number = "asdf"; // always errors, as it should
// Comment out L27 to see correct error on L32
// Uncomment L27 and lines 18-21 to see all errors correctly
// Works as expected in v4.4.4, but not any later versionsπ Actual behavior
No errors on lines 27 and 32 (assigning an incompatible type).
π Expected behavior
Should error on those lines.
Additional information about the issue
The code works (i.e. gives correct errors) in version 4.4.4 (pg).
I assume this is to with depth limits, as it works fine for the two level case (DataTypeTwo) - though if the bad assignment comes after the three level case then even this error is not shown. (i.e. need to comment out line 27 in the example for the bad assignment to the DataTypeTwo variable to correctly error).
Even more oddly, if a bad assignment to a DataTypeTwo variable is made before the bad assignment to a DataTypeThree, the DataTypeThree assignment begins to error correctly. (Uncomment lines 18-21 in the example).
Possibly related to #56291.
Metadata
Metadata
Assignees
Labels
BugA bug in TypeScriptA bug in TypeScriptDomain: check: Variance RelationshipsThe issue relates to variance relationships between typesThe issue relates to variance relationships between types
Activity
RyanCavanaugh commentedon Nov 7, 2024
Looks like variance measurement has gone badly off the rails here (we're incorrectly allowing
in Tas a possible annotation).Straightforward workaround is to add a variance annotation
thscott commentedon Nov 7, 2024
Thanks for that workaround, though upon investigating it, it still doesn't seem to always work, such as when assigning a name to those generic types (i.e.
type DataTypeThreeA = DataTypeThree<TypeA>).In this pg an error isn't generated, unless lines 10-15 aren't commented out (or lines 18-21 as before).
Add failing test for variance measurement with nested generic type alβ¦