Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

angle brackets formatting problem #5890

Closed
zpdDG4gta8XKpMCd opened this issue Dec 2, 2015 · 4 comments · Fixed by #28340
Closed

angle brackets formatting problem #5890

zpdDG4gta8XKpMCd opened this issue Dec 2, 2015 · 4 comments · Fixed by #28340
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue Help Wanted You can do this
Milestone
TypeScript 3.2

Comments

@zpdDG4gta8XKpMCd
Copy link 

// given
export type All = Map<
    number, {
        type: zit.Type;
        index: number;
    }
>;

// actual
export type All = Map<
    number, {
        type: zit.Type;
        index: number;
    }
    >;

// expected
export type All = Map<
    number, {
        type: zit.Type;
        index: number;
    }
>;
@mhegazy mhegazy added Bug A bug in TypeScript Help Wanted You can do this labels Dec 2, 2015
@mhegazy mhegazy added this to the Community milestone Dec 2, 2015
@DanCorder
Copy link
Contributor

@saschanaz has made a lot of changes to import and export formatting on #4609 that appear to fix this.
I checked out the fixImportExportFormatting branch from https://github.com/SaschaNaz/TypeScript, made a test for this exact case and it passed.

@saschanaz
Copy link
Contributor

@DanCorder I checked out the branch with a bit surprise but I don't see this fixed. Maybe a comment on a wrong issue?

@DanCorder
Copy link
Contributor

@saschanaz Sorry, you are correct. This is the issue I meant to comment on, but my test was broken. This is still an issue.

@mhegazy mhegazy added Help Wanted You can do this and removed Help Wanted You can do this labels Feb 20, 2016
@saschanaz saschanaz mentioned this issue Jan 19, 2017
Closed
@saschanaz saschanaz mentioned this issue Nov 5, 2018
Merged
@DanielRosenwasser DanielRosenwasser added the Fixed A PR has been merged for this issue label Nov 9, 2018
@DanielRosenwasser
Copy link
Member

Thanks @saschanaz!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue Help Wanted You can do this
Projects
None yet
Milestone
TypeScript 3.2
5 participants
@zpdDG4gta8XKpMCd @DanielRosenwasser @saschanaz @DanCorder @mhegazy