Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The child class should not be able to access the class field defined by the parent class via super #54054

Closed
Jack-Works opened this issue Apr 28, 2023 · 6 comments · Fixed by #54056
Closed

The child class should not be able to access the class field defined by the parent class via super #54054

Jack-Works opened this issue Apr 28, 2023 · 6 comments · Fixed by #54056
Labels
Duplicate An existing issue was already created
Milestone
TypeScript 5.3.0

Comments

@Jack-Works
Copy link
Contributor

Bug Report

The child class should not be able to access the class field defined by the parent class via super

🔎 Search Terms

class field super parent

🕗 Version & Regression Information

Happens on 5.1.0-beta

⏯ Playground Link

Playground link with relevant code

💻 Code

class T {
    field = () => {}
}
class T2 extends T {
    f() {
        super.field()
//      ~~~~~~~~~~~
    }
}

new T2().f()

🙁 Actual behavior

No type error

🙂 Expected behavior

Type error.

super will look for the parent class, but the class field is always defined on the current instance.
@fatcerberus
Copy link

fatcerberus commented Apr 28, 2023 •
edited
Loading

I don’t think the type system can make this distinction of “it’s an instance property of T except in cases where T is accessed through super” so this will likely be closed as a design limitation.

@Jack-Works Jack-Works mentioned this issue Apr 28, 2023
Merged
@Jack-Works
Copy link
Contributor Author

fix is available

@Jack-Works
Copy link
Contributor Author

I don’t think the type system can make this distinction of “it’s an instance property of T except in cases where T is accessed through super” so this will likely be closed as a design limitation.

image

TypeScript can

@Josh-Cena
Copy link
Contributor

Duplicate of #35314

@RyanCavanaugh RyanCavanaugh added the Duplicate An existing issue was already created label Jun 1, 2023
@microsoft-github-policy-service
Copy link

This issue has been marked as a 'Duplicate' and has seen no recent activity. It has been automatically closed for house-keeping purposes.

@microsoft-github-policy-service
Copy link

This issue has been marked as a 'Duplicate' and has seen no recent activity. It has been automatically closed for house-keeping purposes.

@ekilah ekilah mentioned this issue Jul 6, 2023
Closed
@DanielRosenwasser DanielRosenwasser added this to the TypeScript 5.3.0 milestone Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Duplicate An existing issue was already created
Projects
None yet
Milestone
TypeScript 5.3.0
Development

Successfully merging a pull request may close this issue.

fix: class field is not accessible via super Jack-Works/TypeScript
5 participants
@DanielRosenwasser @fatcerberus @Jack-Works @RyanCavanaugh @Josh-Cena