-
Notifications
You must be signed in to change notification settings - Fork 13.2k
Description
Bug Report
🔎 Search Terms
tuple elements label reserved word
named tuple elements
🕗 Version & Regression Information
- This is the behavior in every version I tried, and I reviewed the FAQ for entries about "Common "Bugs" That Aren't Bugs"
⏯ Playground Link
Playground link with relevant code
💻 Code
type x = [if: any]
// but some keywords are allowed, e.g.
type y = [void: any]🙁 Actual behavior
Unused label.
'any' only refers to a type, but is being used as a value here.
Type expected.
'(' expected.
Unexpected keyword or identifier.
Declaration or statement expected.
🙂 Expected behavior
No errors. As a label it should allow any identifiers, including reserved words.
👩💻 Possible solution
Although parseTupleElementNameOrTupleElementType allows any identifier as its name:
TypeScript/src/compiler/parser.ts
Line 3559 in 0af2497
| const name = parseIdentifierName(); |
before it is invoked, the isListElement requires a tuple member start a type:
TypeScript/src/compiler/parser.ts
Line 2091 in 0af2497
| return token() === SyntaxKind.CommaToken || isStartOfType(); |
This is no longer true after we support named tuple member after 4.0, which should start with any valid identifiers / keywords. Because isListElement returns false, the parser does not parse them as tuple elements, which results to confusing parsing errors.
We can create a new ParsingContext for named tuple members, and returns token() === SyntaxKind.CommaToken || tokenIsIdentifierOrKeyword(token()) in isListElement.