-
Notifications
You must be signed in to change notification settings - Fork 13.2k
Closed
Labels
BugA bug in TypeScriptA bug in TypeScriptDomain: LS: Symbol NavigationRelates to go-to-definition, find-all-references, highlighting/occurrences.Relates to go-to-definition, find-all-references, highlighting/occurrences.VS Code PriorityCritical issues that VS Code needs fixed in the current TypeScript milestoneCritical issues that VS Code needs fixed in the current TypeScript milestoneVS Code TrackedThere is a VS Code equivalent to this issueThere is a VS Code equivalent to this issue
Milestone
Description
Needed for microsoft/vscode#18205
TypeScript Version: 2.2.0-dev.20170104
class Foo {
public abc;
}
var foo = new Foo()
foo.abc = 10I'm trying to execute a references request against the TSServer for the property abc. Currently, this only works if the target location is somewhere within the string abc. I believe the references command should work if the target location is anywhere inside of public abc instead.
This blocks adopting a references code lens provider in VSCode. The problem is that when determining which symbols in the document we want to have show reference counts for, the navtree request for the document returns abc with the entire public abc span. This span does not work with the references request that we later fire off.
Metadata
Metadata
Assignees
Labels
BugA bug in TypeScriptA bug in TypeScriptDomain: LS: Symbol NavigationRelates to go-to-definition, find-all-references, highlighting/occurrences.Relates to go-to-definition, find-all-references, highlighting/occurrences.VS Code PriorityCritical issues that VS Code needs fixed in the current TypeScript milestoneCritical issues that VS Code needs fixed in the current TypeScript milestoneVS Code TrackedThere is a VS Code equivalent to this issueThere is a VS Code equivalent to this issue